AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Lin, Amber" <Amber.Lin-5C7GfCeVMHo@public.gmane.org>
To: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
	<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu/soc15: skip reset on init
Date: Fri, 17 May 2019 14:47:34 +0000	[thread overview]
Message-ID: <a986c8b7-4255-e70b-4e39-102cc57cda92@amd.com> (raw)
In-Reply-To: <20190517142647.26034-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>



On 2019-05-17 10:26 a.m., Alex Deucher wrote:
> [CAUTION: External Email]
>
> Not necessary on soc15 and breaks driver reload on server cards.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@vger.kernel.org
> ---
>   drivers/gpu/drm/amd/amdgpu/soc15.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
> index 32dc5a128249..78bd4fc07bab 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
> @@ -761,6 +761,11 @@ static bool soc15_need_reset_on_init(struct amdgpu_device *adev)
>   {
>          u32 sol_reg;
>
> +       /* Just return false for soc15 GPUs.  Reset does not seem to
> +        * be necessary.
> +        */
> +       return false;
> +
>          if (adev->flags & AMD_IS_APU)
>                  return false;
Should remove the rest of code in this function and sol_reg as well? 
Simply return false?
>
> --
> 2.20.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2019-05-17 14:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17 14:26 [PATCH] drm/amdgpu/soc15: skip reset on init Alex Deucher
2019-05-18 12:22 ` Sasha Levin
     [not found] ` <20190517142647.26034-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2019-05-17 14:47   ` Lin, Amber [this message]
     [not found]     ` <a986c8b7-4255-e70b-4e39-102cc57cda92-5C7GfCeVMHo@public.gmane.org>
2019-05-17 17:02       ` Alex Deucher
     [not found]         ` <CADnq5_PKFA62OMa4H9gKy4R9rk38mY0EKhZGxf51N36DkTEavQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-05-17 19:15           ` Lin, Amber
2019-05-18 12:22   ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a986c8b7-4255-e70b-4e39-102cc57cda92@amd.com \
    --to=amber.lin-5c7gfcevmho@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox