From: zhoucm1 <zhoucm1@amd.com>
To: christian.koenig@amd.com, Chunming Zhou <david1.zhou@amd.com>,
dri-devel@lists.freedesktop.org,
Daniel Rakos <Daniel.Rakos@amd.com>
Cc: Dave Airlie <airlied@redhat.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] [RFC]drm: add syncobj timeline support v5
Date: Wed, 19 Sep 2018 11:20:06 +0800 [thread overview]
Message-ID: <0231250d-0ed0-e99b-84c6-166b47a0b9cc@amd.com> (raw)
In-Reply-To: <2bea4bc7-ce1f-e1ff-8308-d932d108f237@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 888 bytes --]
On 2018年09月18日 16:32, Christian König wrote:
>>>> + for (i = 0; i < args->count_handles; i++) {
>>>> + if (syncobjs[i]->type == DRM_SYNCOBJ_TYPE_TIMELINE) {
>>>> + DRM_ERROR("timeline syncobj cannot reset!\n");
>>>
>>> Why not? I mean that should still work or do I miss anything?
>> timeline semaphore spec doesn't require reset interface, it says the
>> timeline value only can be changed by signal operations.
>
> Yeah, but we don't care about the timeline spec in the kernel.
>
> Question is rather if that still makes sense to support that and as
> far as I can see it should be trivial to reinitialize the object.
Hi Daniel Rakos,
Could you give a comment on this question? Is it necessary to support
timeline reset interface? I only see the timeline value can be changed
by signal operations in Spec.
Thanks,
David Zhou
[-- Attachment #1.2: Type: text/html, Size: 1729 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-09-19 3:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 10:37 [PATCH] [RFC]drm: add syncobj timeline support v5 Chunming Zhou
2018-09-14 10:49 ` Christian König
[not found] ` <9a07a371-8de1-2ebf-66e7-23b93c1bc1c3-5C7GfCeVMHo@public.gmane.org>
2018-09-14 16:10 ` Daniel Vetter
[not found] ` <20180914161059.GR11082-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org>
2018-09-14 16:43 ` Christian König
2018-09-14 18:24 ` Daniel Vetter
[not found] ` <CAKMK7uH9jLO0bJe8ek-JyK3u1jbKY6Jk6xgT9ifgcko7Hi2URA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-09-14 18:27 ` Christian König
2018-09-17 2:23 ` Zhou, David(ChunMing)
2018-09-17 8:37 ` Christian König
[not found] ` <a5d2d299-4360-4267-046e-40b550239524-5C7GfCeVMHo@public.gmane.org>
2018-09-17 9:33 ` zhoucm1
2018-09-18 8:32 ` Christian König
2018-09-19 3:20 ` zhoucm1 [this message]
[not found] ` <0231250d-0ed0-e99b-84c6-166b47a0b9cc-5C7GfCeVMHo@public.gmane.org>
2018-09-19 7:21 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0231250d-0ed0-e99b-84c6-166b47a0b9cc@amd.com \
--to=zhoucm1@amd.com \
--cc=Daniel.Rakos@amd.com \
--cc=airlied@redhat.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=david1.zhou@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox