Re: [PATCH] [RFC]drm: add syncobj timeline support v5

From: "Christian König" <ckoenig.leichtzumerken-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: zhoucm1 <zhoucm1-5C7GfCeVMHo@public.gmane.org>,
	christian.koenig-5C7GfCeVMHo@public.gmane.org,
	Chunming Zhou <david1.zhou-5C7GfCeVMHo@public.gmane.org>,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Daniel Rakos <Daniel.Rakos-5C7GfCeVMHo@public.gmane.org>
Cc: Dave Airlie <airlied-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] [RFC]drm: add syncobj timeline support v5
Date: Wed, 19 Sep 2018 09:21:51 +0200	[thread overview]
Message-ID: <cd57779c-ab9b-c12e-8287-f858ce850500@gmail.com> (raw)
In-Reply-To: <0231250d-0ed0-e99b-84c6-166b47a0b9cc-5C7GfCeVMHo@public.gmane.org>

[-- Attachment #1.1: Type: text/plain, Size: 1398 bytes --]

Am 19.09.2018 um 05:20 schrieb zhoucm1:
>
>
>
> On 2018年09月18日 16:32, Christian König wrote:
>>>>> +    for (i = 0; i < args->count_handles; i++) {
>>>>> +        if (syncobjs[i]->type == DRM_SYNCOBJ_TYPE_TIMELINE) {
>>>>> +            DRM_ERROR("timeline syncobj cannot reset!\n");
>>>>
>>>> Why not? I mean that should still work or do I miss anything?
>>> timeline semaphore spec doesn't require reset interface, it says the 
>>> timeline value only can be changed by signal operations.
>>
>> Yeah, but we don't care about the timeline spec in the kernel.
>>
>> Question is rather if that still makes sense to support that and as 
>> far as I can see it should be trivial to reinitialize the object. 
> Hi Daniel Rakos,
>
> Could you give a comment on this question? Is it necessary to support 
> timeline reset interface?  I only see the timeline value can be 
> changed by signal operations in Spec.

I think the Vulkan spec is rather irrelevant here. We added the reset 
operation because of drivers which wanted to re-use an existing syncobj.

That is still a valid use case even when Vulkan doesn't have an 
interface for it.

Christian.

>
>
> Thanks,
> David Zhou
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[-- Attachment #1.2: Type: text/html, Size: 3036 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx