* [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"
[not found] <20230710074943.54300-1-xujianghui@cdjrlc.com>
@ 2023-07-10 7:51 ` sunran001
2023-07-10 17:21 ` Alex Deucher
0 siblings, 1 reply; 6+ messages in thread
From: sunran001 @ 2023-07-10 7:51 UTC (permalink / raw)
To: airlied, daniel; +Cc: dri-devel, amd-gfx, linux-kernel
Fix four occurrences of the checkpatch.pl error:
ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/radeon/radeon_test.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_test.c
b/drivers/gpu/drm/radeon/radeon_test.c
index a5e1d2139e80..c9fef9b61ced 100644
--- a/drivers/gpu/drm/radeon/radeon_test.c
+++ b/drivers/gpu/drm/radeon/radeon_test.c
@@ -156,10 +156,10 @@ static void radeon_do_test_moves(struct
radeon_device *rdev, int flag)
i, *vram_start, gtt_start,
(unsigned long long)
(gtt_addr - rdev->mc.gtt_start +
- (void*)gtt_start - gtt_map),
+ (void *)gtt_start - gtt_map),
(unsigned long long)
(vram_addr - rdev->mc.vram_start +
- (void*)gtt_start - gtt_map));
+ (void *)gtt_start - gtt_map));
radeon_bo_kunmap(vram_obj);
goto out_lclean_unpin;
}
@@ -207,10 +207,10 @@ static void radeon_do_test_moves(struct
radeon_device *rdev, int flag)
i, *gtt_start, vram_start,
(unsigned long long)
(vram_addr - rdev->mc.vram_start +
- (void*)vram_start - vram_map),
+ (void *)vram_start - vram_map),
(unsigned long long)
(gtt_addr - rdev->mc.gtt_start +
- (void*)vram_start - vram_map));
+ (void *)vram_start - vram_map));
radeon_bo_kunmap(gtt_obj[i]);
goto out_lclean_unpin;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"
[not found] <20230710082515.54604-1-xujianghui@cdjrlc.com>
@ 2023-07-10 8:26 ` sunran001
2023-07-10 17:25 ` Alex Deucher
0 siblings, 1 reply; 6+ messages in thread
From: sunran001 @ 2023-07-10 8:26 UTC (permalink / raw)
To: airlied, daniel; +Cc: dri-devel, amd-gfx, linux-kernel
Fix four occurrences of the checkpatch.pl error:
ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/radeon/radeon_atombios.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c
b/drivers/gpu/drm/radeon/radeon_atombios.c
index bf3c411a55c5..85c4bb186203 100644
--- a/drivers/gpu/drm/radeon/radeon_atombios.c
+++ b/drivers/gpu/drm/radeon/radeon_atombios.c
@@ -1389,7 +1389,7 @@ bool radeon_atombios_get_ppll_ss_info(struct
radeon_device *rdev,
num_indices = (size - sizeof(ATOM_COMMON_TABLE_HEADER)) /
sizeof(ATOM_SPREAD_SPECTRUM_ASSIGNMENT);
- ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT*)
+ ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT *)
((u8 *)&ss_info->asSS_Info[0]);
for (i = 0; i < num_indices; i++) {
if (ss_assign->ucSS_Id == id) {
@@ -1402,7 +1402,7 @@ bool radeon_atombios_get_ppll_ss_info(struct
radeon_device *rdev,
ss->refdiv = ss_assign->ucRecommendedRef_Div;
return true;
}
- ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT*)
+ ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT *)
((u8 *)ss_assign + sizeof(struct
_ATOM_SPREAD_SPECTRUM_ASSIGNMENT));
}
}
@@ -3406,7 +3406,7 @@ static ATOM_VOLTAGE_OBJECT_V2
*atom_lookup_voltage_object_v2(ATOM_VOLTAGE_OBJECT
{
u32 size = le16_to_cpu(v2->sHeader.usStructureSize);
u32 offset = offsetof(ATOM_VOLTAGE_OBJECT_INFO_V2,
asVoltageObj[0]);
- u8 *start = (u8*)v2;
+ u8 *start = (u8 *)v2;
while (offset < size) {
ATOM_VOLTAGE_OBJECT_V2 *vo = (ATOM_VOLTAGE_OBJECT_V2 *)(start +
offset);
@@ -3423,7 +3423,7 @@ static ATOM_VOLTAGE_OBJECT_V3
*atom_lookup_voltage_object_v3(ATOM_VOLTAGE_OBJECT
{
u32 size = le16_to_cpu(v3->sHeader.usStructureSize);
u32 offset = offsetof(ATOM_VOLTAGE_OBJECT_INFO_V3_1,
asVoltageObj[0]);
- u8 *start = (u8*)v3;
+ u8 *start = (u8 *)v3;
while (offset < size) {
ATOM_VOLTAGE_OBJECT_V3 *vo = (ATOM_VOLTAGE_OBJECT_V3 *)(start +
offset);
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"
2023-07-10 7:51 ` sunran001
@ 2023-07-10 17:21 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2023-07-10 17:21 UTC (permalink / raw)
To: sunran001; +Cc: amd-gfx, airlied, dri-devel, daniel, linux-kernel
Applied. Thanks!
Alex
On Mon, Jul 10, 2023 at 3:52 AM <sunran001@208suo.com> wrote:
>
> Fix four occurrences of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> drivers/gpu/drm/radeon/radeon_test.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_test.c
> b/drivers/gpu/drm/radeon/radeon_test.c
> index a5e1d2139e80..c9fef9b61ced 100644
> --- a/drivers/gpu/drm/radeon/radeon_test.c
> +++ b/drivers/gpu/drm/radeon/radeon_test.c
> @@ -156,10 +156,10 @@ static void radeon_do_test_moves(struct
> radeon_device *rdev, int flag)
> i, *vram_start, gtt_start,
> (unsigned long long)
> (gtt_addr - rdev->mc.gtt_start +
> - (void*)gtt_start - gtt_map),
> + (void *)gtt_start - gtt_map),
> (unsigned long long)
> (vram_addr - rdev->mc.vram_start +
> - (void*)gtt_start - gtt_map));
> + (void *)gtt_start - gtt_map));
> radeon_bo_kunmap(vram_obj);
> goto out_lclean_unpin;
> }
> @@ -207,10 +207,10 @@ static void radeon_do_test_moves(struct
> radeon_device *rdev, int flag)
> i, *gtt_start, vram_start,
> (unsigned long long)
> (vram_addr - rdev->mc.vram_start +
> - (void*)vram_start - vram_map),
> + (void *)vram_start - vram_map),
> (unsigned long long)
> (gtt_addr - rdev->mc.gtt_start +
> - (void*)vram_start - vram_map));
> + (void *)vram_start - vram_map));
> radeon_bo_kunmap(gtt_obj[i]);
> goto out_lclean_unpin;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"
2023-07-10 8:26 ` [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)" sunran001
@ 2023-07-10 17:25 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2023-07-10 17:25 UTC (permalink / raw)
To: sunran001; +Cc: amd-gfx, airlied, dri-devel, daniel, linux-kernel
Applied. Thanks!
On Mon, Jul 10, 2023 at 4:27 AM <sunran001@208suo.com> wrote:
>
> Fix four occurrences of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> drivers/gpu/drm/radeon/radeon_atombios.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c
> b/drivers/gpu/drm/radeon/radeon_atombios.c
> index bf3c411a55c5..85c4bb186203 100644
> --- a/drivers/gpu/drm/radeon/radeon_atombios.c
> +++ b/drivers/gpu/drm/radeon/radeon_atombios.c
> @@ -1389,7 +1389,7 @@ bool radeon_atombios_get_ppll_ss_info(struct
> radeon_device *rdev,
>
> num_indices = (size - sizeof(ATOM_COMMON_TABLE_HEADER)) /
> sizeof(ATOM_SPREAD_SPECTRUM_ASSIGNMENT);
> - ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT*)
> + ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT *)
> ((u8 *)&ss_info->asSS_Info[0]);
> for (i = 0; i < num_indices; i++) {
> if (ss_assign->ucSS_Id == id) {
> @@ -1402,7 +1402,7 @@ bool radeon_atombios_get_ppll_ss_info(struct
> radeon_device *rdev,
> ss->refdiv = ss_assign->ucRecommendedRef_Div;
> return true;
> }
> - ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT*)
> + ss_assign = (struct _ATOM_SPREAD_SPECTRUM_ASSIGNMENT *)
> ((u8 *)ss_assign + sizeof(struct
> _ATOM_SPREAD_SPECTRUM_ASSIGNMENT));
> }
> }
> @@ -3406,7 +3406,7 @@ static ATOM_VOLTAGE_OBJECT_V2
> *atom_lookup_voltage_object_v2(ATOM_VOLTAGE_OBJECT
> {
> u32 size = le16_to_cpu(v2->sHeader.usStructureSize);
> u32 offset = offsetof(ATOM_VOLTAGE_OBJECT_INFO_V2,
> asVoltageObj[0]);
> - u8 *start = (u8*)v2;
> + u8 *start = (u8 *)v2;
>
> while (offset < size) {
> ATOM_VOLTAGE_OBJECT_V2 *vo = (ATOM_VOLTAGE_OBJECT_V2 *)(start +
> offset);
> @@ -3423,7 +3423,7 @@ static ATOM_VOLTAGE_OBJECT_V3
> *atom_lookup_voltage_object_v3(ATOM_VOLTAGE_OBJECT
> {
> u32 size = le16_to_cpu(v3->sHeader.usStructureSize);
> u32 offset = offsetof(ATOM_VOLTAGE_OBJECT_INFO_V3_1,
> asVoltageObj[0]);
> - u8 *start = (u8*)v3;
> + u8 *start = (u8 *)v3;
>
> while (offset < size) {
> ATOM_VOLTAGE_OBJECT_V3 *vo = (ATOM_VOLTAGE_OBJECT_V3 *)(start +
> offset);
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"
[not found] <tencent_16FACBDCDA61595C4219E185613C85C8BF0A@qq.com>
@ 2023-07-14 5:35 ` shijie001
2023-07-14 7:21 ` Christian König
0 siblings, 1 reply; 6+ messages in thread
From: shijie001 @ 2023-07-14 5:35 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel
Cc: dri-devel, amd-gfx, linux-kernel
Fix one occurrence of the checkpatch.pl error:
ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Jie Shi <shijie001@208suo.com>
---
drivers/gpu/drm/radeon/uvd_v1_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/uvd_v1_0.c
b/drivers/gpu/drm/radeon/uvd_v1_0.c
index 58557c2263a7..5684639d20a6 100644
--- a/drivers/gpu/drm/radeon/uvd_v1_0.c
+++ b/drivers/gpu/drm/radeon/uvd_v1_0.c
@@ -142,7 +142,7 @@ int uvd_v1_0_resume(struct radeon_device *rdev)
addr = (rdev->uvd.gpu_addr >> 32) & 0xFF;
WREG32(UVD_LMI_EXT40_ADDR, addr | (0x9 << 16) | (0x1 << 31));
- WREG32(UVD_FW_START, *((uint32_t*)rdev->uvd.cpu_addr));
+ WREG32(UVD_FW_START, *((uint32_t *)rdev->uvd.cpu_addr));
return 0;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)"
2023-07-14 5:35 ` shijie001
@ 2023-07-14 7:21 ` Christian König
0 siblings, 0 replies; 6+ messages in thread
From: Christian König @ 2023-07-14 7:21 UTC (permalink / raw)
To: shijie001, alexander.deucher, Xinhui.Pan, airlied, daniel
Cc: dri-devel, amd-gfx, linux-kernel
Am 14.07.23 um 07:35 schrieb shijie001@208suo.com:
> Fix one occurrence of the checkpatch.pl error:
> ERROR: "(foo*)" should be "(foo *)"
It's nice to see all those little typos fixed, but I'm not sure how
feasible it is to send patches for each type individually.
Maybe just merge them together into one patch for the whole radeon code
base.
Additional to that I'm pretty sure that most of that stuff is already
fixed, so what base do you use for this?
Regards,
Christian.
>
> Signed-off-by: Jie Shi <shijie001@208suo.com>
> ---
> drivers/gpu/drm/radeon/uvd_v1_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/uvd_v1_0.c
> b/drivers/gpu/drm/radeon/uvd_v1_0.c
> index 58557c2263a7..5684639d20a6 100644
> --- a/drivers/gpu/drm/radeon/uvd_v1_0.c
> +++ b/drivers/gpu/drm/radeon/uvd_v1_0.c
> @@ -142,7 +142,7 @@ int uvd_v1_0_resume(struct radeon_device *rdev)
> addr = (rdev->uvd.gpu_addr >> 32) & 0xFF;
> WREG32(UVD_LMI_EXT40_ADDR, addr | (0x9 << 16) | (0x1 << 31));
>
> - WREG32(UVD_FW_START, *((uint32_t*)rdev->uvd.cpu_addr));
> + WREG32(UVD_FW_START, *((uint32_t *)rdev->uvd.cpu_addr));
>
> return 0;
> }
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-14 7:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230710082515.54604-1-xujianghui@cdjrlc.com>
2023-07-10 8:26 ` [PATCH] drm/radeon: ERROR: "(foo*)" should be "(foo *)" sunran001
2023-07-10 17:25 ` Alex Deucher
[not found] <tencent_16FACBDCDA61595C4219E185613C85C8BF0A@qq.com>
2023-07-14 5:35 ` shijie001
2023-07-14 7:21 ` Christian König
[not found] <20230710074943.54300-1-xujianghui@cdjrlc.com>
2023-07-10 7:51 ` sunran001
2023-07-10 17:21 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox