AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Feifei Xu <Feifei.Xu-5C7GfCeVMHo@public.gmane.org>
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Feifei.Xu-5C7GfCeVMHo@public.gmane.org,
	Hawking Zhang <Hawking.Zhang-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH 8/8] drm/amdgpu: program system bit for pte/pde when ZFB is enabled
Date: Thu, 15 Mar 2018 14:12:04 +0800	[thread overview]
Message-ID: <1521094324-23252-8-git-send-email-Feifei.Xu@amd.com> (raw)
In-Reply-To: <1521094324-23252-1-git-send-email-Feifei.Xu-5C7GfCeVMHo@public.gmane.org>

Change-Id: I9e4babf1e91855fb66e65cf2f82db64a1cd6fc97
Signed-off-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Feifei Xu <Feifei.Xu@amd.com>
Acked-by: John Bridgman <john.bridgman@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 2 ++
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c    | 6 ++++++
 drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c  | 2 ++
 3 files changed, 10 insertions(+)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c
index 3689f1d..6b172ca 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c
@@ -44,6 +44,8 @@ static void gfxhub_v1_0_init_gart_pt_regs(struct amdgpu_device *adev)
 		+ adev->vm_manager.vram_base_offset;
 	value &= 0x0000FFFFFFFFF000ULL;
 	value |= 0x1; /*valid bit*/
+	if (adev->gmc.zfb_size > 0)
+		value |= 0x2; /*system bit*/
 
 	WREG32_SOC15(GC, 0, mmVM_CONTEXT0_PAGE_TABLE_BASE_ADDR_LO32,
 		     lower_32_bits(value));
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 94e13c8..f3b6a5f 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -480,6 +480,9 @@ static uint64_t gmc_v9_0_get_vm_pte_flags(struct amdgpu_device *adev,
 	if (flags & AMDGPU_VM_PAGE_WRITEABLE)
 		pte_flag |= AMDGPU_PTE_WRITEABLE;
 
+	if (adev->gmc.zfb_size > 0)
+		pte_flag |= AMDGPU_PTE_SYSTEM;
+
 	switch (flags & AMDGPU_VM_MTYPE_MASK) {
 	case AMDGPU_VM_MTYPE_DEFAULT:
 		pte_flag |= AMDGPU_PTE_MTYPE(MTYPE_NC);
@@ -515,6 +518,9 @@ static void gmc_v9_0_get_vm_pde(struct amdgpu_device *adev, int level,
 			adev->gmc.vram_start;
 	BUG_ON(*addr & 0xFFFF00000000003FULL);
 
+	if (adev->gmc.zfb_size > 0)
+		*flags |= AMDGPU_PTE_SYSTEM;
+
 	if (!adev->gmc.translate_further)
 		return;
 
diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
index ef79d49..471a59b 100644
--- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c
@@ -54,6 +54,8 @@ static void mmhub_v1_0_init_gart_pt_regs(struct amdgpu_device *adev)
 		adev->vm_manager.vram_base_offset;
 	value &= 0x0000FFFFFFFFF000ULL;
 	value |= 0x1; /* valid bit */
+	if (adev->gmc.zfb_size > 0)
+		value |= 0x2; /* system bit*/
 
 	WREG32_SOC15(MMHUB, 0, mmVM_CONTEXT0_PAGE_TABLE_BASE_ADDR_LO32,
 		     lower_32_bits(value));
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2018-03-15  6:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15  6:11 [PATCH 1/8] drm/amdgpu: Fix hardcoded base offset of vram pages Feifei Xu
     [not found] ` <1521094324-23252-1-git-send-email-Feifei.Xu-5C7GfCeVMHo@public.gmane.org>
2018-03-15  6:11   ` [PATCH 2/8] drm/amdgpu: add new member in amdgpu_mc for zfb support Feifei Xu
     [not found]     ` <1521094324-23252-2-git-send-email-Feifei.Xu-5C7GfCeVMHo@public.gmane.org>
2018-03-15  8:10       ` Christian König
2018-03-15  6:11   ` [PATCH 3/8] drm/amdgpu: add amdgpu module parameter for zfb Feifei Xu
     [not found]     ` <1521094324-23252-3-git-send-email-Feifei.Xu-5C7GfCeVMHo@public.gmane.org>
2018-03-15  8:11       ` Christian König
2018-03-15  6:12   ` [PATCH 4/8] drm/amdgpu: init zfb start address and size Feifei Xu
     [not found]     ` <1521094324-23252-4-git-send-email-Feifei.Xu-5C7GfCeVMHo@public.gmane.org>
2018-03-15  8:13       ` Christian König
2018-03-15  6:12   ` [PATCH 5/8] drm/amdgpu: user reserved zfb to init vram base offset " Feifei Xu
     [not found]     ` <1521094324-23252-5-git-send-email-Feifei.Xu-5C7GfCeVMHo@public.gmane.org>
2018-03-15  8:15       ` Christian König
2018-03-15  6:12   ` [PATCH 6/8] drm/amdgpu: enable physical transaction for ptd/pde when ZFB is enabled Feifei Xu
     [not found]     ` <1521094324-23252-6-git-send-email-Feifei.Xu-5C7GfCeVMHo@public.gmane.org>
2018-03-15  8:17       ` Christian König
2018-03-15  6:12   ` [PATCH 7/8] drm/amdgpu: program AGP aperture as frame buffer " Feifei Xu
     [not found]     ` <1521094324-23252-7-git-send-email-Feifei.Xu-5C7GfCeVMHo@public.gmane.org>
2018-03-15  8:18       ` Christian König
2018-03-15  6:12   ` Feifei Xu [this message]
     [not found]     ` <1521094324-23252-8-git-send-email-Feifei.Xu-5C7GfCeVMHo@public.gmane.org>
2018-03-15  8:19       ` [PATCH 8/8] drm/amdgpu: program system bit for pte/pde " Christian König
2018-03-15  8:09   ` [PATCH 1/8] drm/amdgpu: Fix hardcoded base offset of vram pages Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521094324-23252-8-git-send-email-Feifei.Xu@amd.com \
    --to=feifei.xu-5c7gfcevmho@public.gmane.org \
    --cc=Hawking.Zhang-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox