* [PATCH] drm/amd/display: remove assert around dpp_base replacement
@ 2026-01-16 15:50 Melissa Wen
2026-02-03 5:31 ` Alex Hung
0 siblings, 1 reply; 2+ messages in thread
From: Melissa Wen @ 2026-01-16 15:50 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, siqueira, alexander.deucher,
christian.koenig, airlied, simona
Cc: amd-gfx, dri-devel, kernel-dev
There is nothing wrong if in_shaper_func type is DISTRIBUTED POINTS.
Remove the assert placed for a TODO to avoid misinterpretations.
Signed-off-by: Melissa Wen <mwen@igalia.com>
---
drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
index 3cd44c6602b3..4dfd22bc00c4 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
@@ -507,7 +507,6 @@ bool dcn32_set_mcm_luts(
lut_params = &plane_state->in_shaper_func.pwl;
else if (plane_state->in_shaper_func.type == TF_TYPE_DISTRIBUTED_POINTS) {
// TODO: dpp_base replace
- ASSERT(false);
cm3_helper_translate_curve_to_hw_format(&plane_state->in_shaper_func,
&dpp_base->shaper_params, true);
lut_params = &dpp_base->shaper_params;
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/amd/display: remove assert around dpp_base replacement
2026-01-16 15:50 [PATCH] drm/amd/display: remove assert around dpp_base replacement Melissa Wen
@ 2026-02-03 5:31 ` Alex Hung
0 siblings, 0 replies; 2+ messages in thread
From: Alex Hung @ 2026-02-03 5:31 UTC (permalink / raw)
To: Melissa Wen, harry.wentland, sunpeng.li, siqueira,
alexander.deucher, christian.koenig, airlied, simona
Cc: amd-gfx, dri-devel, kernel-dev
Reviewed-by: Alex Hung <alex.hung@amd.com>
On 1/16/26 08:50, Melissa Wen wrote:
> There is nothing wrong if in_shaper_func type is DISTRIBUTED POINTS.
> Remove the assert placed for a TODO to avoid misinterpretations.
>
> Signed-off-by: Melissa Wen <mwen@igalia.com>
> ---
> drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
> index 3cd44c6602b3..4dfd22bc00c4 100644
> --- a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
> +++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_hwseq.c
> @@ -507,7 +507,6 @@ bool dcn32_set_mcm_luts(
> lut_params = &plane_state->in_shaper_func.pwl;
> else if (plane_state->in_shaper_func.type == TF_TYPE_DISTRIBUTED_POINTS) {
> // TODO: dpp_base replace
> - ASSERT(false);
> cm3_helper_translate_curve_to_hw_format(&plane_state->in_shaper_func,
> &dpp_base->shaper_params, true);
> lut_params = &dpp_base->shaper_params;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-03 5:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-16 15:50 [PATCH] drm/amd/display: remove assert around dpp_base replacement Melissa Wen
2026-02-03 5:31 ` Alex Hung
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox