* [PATCH] drm/amd/display: remove redundant check
@ 2023-10-29 12:44 José Pekkarinen
2023-10-30 13:52 ` Aurabindo Pillai
0 siblings, 1 reply; 4+ messages in thread
From: José Pekkarinen @ 2023-10-29 12:44 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, skhan
Cc: dillon.varone, linux-kernel-mentees, dri-devel, Xinhui.Pan,
linux-kernel, samson.tam, SyedSaaem.Rizvi, aurabindo.pillai,
José Pekkarinen, amd-gfx, daniel, george.shen,
alexander.deucher, Jun.Lei, airlied, christian.koenig
This patch addresses the following warning spotted by
using coccinelle where the case checked does the same
than the else case.
drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no effect (if == else)
Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
---
.../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
index ecea008f19d3..d940dfa5ae43 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
@@ -4661,10 +4661,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
} else if (AllowForPStateChangeOrStutterInVBlankFinal == dm_prefetch_support_uclk_fclk_and_stutter) {
*MinPrefetchMode = 0;
*MaxPrefetchMode = 0;
- } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
- dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
- *MinPrefetchMode = 0;
- *MaxPrefetchMode = 3;
} else {
*MinPrefetchMode = 0;
*MaxPrefetchMode = 3;
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/display: remove redundant check
2023-10-29 12:44 [PATCH] drm/amd/display: remove redundant check José Pekkarinen
@ 2023-10-30 13:52 ` Aurabindo Pillai
2023-10-30 16:26 ` José Pekkarinen
0 siblings, 1 reply; 4+ messages in thread
From: Aurabindo Pillai @ 2023-10-30 13:52 UTC (permalink / raw)
To: José Pekkarinen, harry.wentland, sunpeng.li,
Rodrigo.Siqueira, skhan
Cc: dillon.varone, linux-kernel-mentees, dri-devel, Xinhui.Pan,
linux-kernel, samson.tam, SyedSaaem.Rizvi, amd-gfx, daniel,
george.shen, alexander.deucher, Jun.Lei, airlied,
christian.koenig
On 10/29/2023 8:44 AM, José Pekkarinen wrote:
> This patch addresses the following warning spotted by
> using coccinelle where the case checked does the same
> than the else case.
>
> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no effect (if == else)
>
> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
> ---
> .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> index ecea008f19d3..d940dfa5ae43 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> @@ -4661,10 +4661,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
> } else if (AllowForPStateChangeOrStutterInVBlankFinal == dm_prefetch_support_uclk_fclk_and_stutter) {
> *MinPrefetchMode = 0;
> *MaxPrefetchMode = 0;
> - } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
> - dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
> - *MinPrefetchMode = 0;
> - *MaxPrefetchMode = 3;
> } else {
> *MinPrefetchMode = 0;
> *MaxPrefetchMode = 3;
What tree did you use to generate the patch? On amd-staging-drm-next,
MaxPrefetchMode is 0 for the second last branch, which is the correct
one, so this patch isnt needed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/display: remove redundant check
2023-10-30 13:52 ` Aurabindo Pillai
@ 2023-10-30 16:26 ` José Pekkarinen
2023-10-30 16:53 ` Aurabindo Pillai
0 siblings, 1 reply; 4+ messages in thread
From: José Pekkarinen @ 2023-10-30 16:26 UTC (permalink / raw)
To: Aurabindo Pillai
Cc: dillon.varone, george.shen, sunpeng.li, airlied, dri-devel,
Xinhui.Pan, Rodrigo.Siqueira, linux-kernel, samson.tam,
SyedSaaem.Rizvi, amd-gfx, daniel, skhan, alexander.deucher,
Jun.Lei, harry.wentland, christian.koenig, linux-kernel-mentees
On 2023-10-30 15:52, Aurabindo Pillai wrote:
> On 10/29/2023 8:44 AM, José Pekkarinen wrote:
>> This patch addresses the following warning spotted by
>> using coccinelle where the case checked does the same
>> than the else case.
>>
>> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10:
>> WARNING: possible condition with no effect (if == else)
>>
>> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
>> ---
>> .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4
>> ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git
>> a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>> b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>> index ecea008f19d3..d940dfa5ae43 100644
>> ---
>> a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>> +++
>> b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>> @@ -4661,10 +4661,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
>> } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
>> dm_prefetch_support_uclk_fclk_and_stutter) {
>> *MinPrefetchMode = 0;
>> *MaxPrefetchMode = 0;
>> - } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
>> - dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
>> - *MinPrefetchMode = 0;
>> - *MaxPrefetchMode = 3;
>> } else {
>> *MinPrefetchMode = 0;
>> *MaxPrefetchMode = 3;
>
> What tree did you use to generate the patch? On amd-staging-drm-next,
> MaxPrefetchMode is 0 for the second last branch, which is the correct
> one, so this patch isnt needed.
I'm using the stable tree, sorry, if it is out of
date just ignore it then.
Thanks!
José.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/display: remove redundant check
2023-10-30 16:26 ` José Pekkarinen
@ 2023-10-30 16:53 ` Aurabindo Pillai
0 siblings, 0 replies; 4+ messages in thread
From: Aurabindo Pillai @ 2023-10-30 16:53 UTC (permalink / raw)
To: José Pekkarinen
Cc: dillon.varone, george.shen, sunpeng.li, airlied, dri-devel,
Xinhui.Pan, Rodrigo.Siqueira, linux-kernel, samson.tam,
SyedSaaem.Rizvi, amd-gfx, daniel, skhan, alexander.deucher,
Jun.Lei, harry.wentland, christian.koenig, linux-kernel-mentees
On 2023-10-30 12:26, José Pekkarinen wrote:
> On 2023-10-30 15:52, Aurabindo Pillai wrote:
>> On 10/29/2023 8:44 AM, José Pekkarinen wrote:
>>> This patch addresses the following warning spotted by
>>> using coccinelle where the case checked does the same
>>> than the else case.
>>>
>>> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no effect (if == else)
>>>
>>> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
>>> ---
>>> .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 ----
>>> 1 file changed, 4 deletions(-)
>>>
>>> diff --git
>>> a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>>> b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>>> index ecea008f19d3..d940dfa5ae43 100644
>>> ---
>>> a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>>> +++
>>> b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
>>> @@ -4661,10 +4661,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
>>> } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
>>> dm_prefetch_support_uclk_fclk_and_stutter) {
>>> *MinPrefetchMode = 0;
>>> *MaxPrefetchMode = 0;
>>> - } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
>>> - dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
>>> - *MinPrefetchMode = 0;
>>> - *MaxPrefetchMode = 3;
>>> } else {
>>> *MinPrefetchMode = 0;
>>> *MaxPrefetchMode = 3;
>>
>> What tree did you use to generate the patch? On amd-staging-drm-next,
>> MaxPrefetchMode is 0 for the second last branch, which is the correct
>> one, so this patch isnt needed.
>
> I'm using the stable tree, sorry, if it is out of
> date just ignore it then.
>
> Thanks!
>
> José.
Actually, you're right - the patch's limited context mislead me, sorry.
But please add the following tag and sent it to stable@vger.kernel.org
instead:
Fixes: 974ce181 ("drm/amd/display: Add check for PState change in DCN32")
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-31 9:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-29 12:44 [PATCH] drm/amd/display: remove redundant check José Pekkarinen
2023-10-30 13:52 ` Aurabindo Pillai
2023-10-30 16:26 ` José Pekkarinen
2023-10-30 16:53 ` Aurabindo Pillai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox