* [bug report] drm/amd/display: Implement interface for CRC on CRTC
@ 2018-03-02 10:51 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2018-03-02 10:51 UTC (permalink / raw)
To: sunpeng.li-5C7GfCeVMHo; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Hello Leo (Sunpeng) Li,
This is a semi-automatic email about new static checker warnings.
The patch 31aec354f92c: "drm/amd/display: Implement interface for CRC
on CRTC" from Dec 18, 2017, leads to the following Smatch complaint:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:323 dm_crtc_high_irq()
error: we previously assumed 'acrtc' could be null (see line 319)
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c
318
319 if (acrtc)
^^^^^
Old code checked for NULL
320 crtc_index = acrtc->crtc_id;
321
322 drm_handle_vblank(adev->ddev, crtc_index);
323 amdgpu_dm_crtc_handle_crc_irq(&acrtc->base);
^^^^^^^^^^^
The new code dereferences without checking (inside the function call).
324 }
325
regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-03-02 10:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-02 10:51 [bug report] drm/amd/display: Implement interface for CRC on CRTC Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox