From: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
To: Rex Zhu <Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amd/pp: Clean header file in vega12_smumgr.c
Date: Wed, 28 Mar 2018 11:03:32 +0800 [thread overview]
Message-ID: <20180328030331.GA9500@hr-amur2> (raw)
In-Reply-To: <1522146825-16458-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
On Tue, Mar 27, 2018 at 06:33:45PM +0800, Rex Zhu wrote:
> Change-Id: I736fe788980823d12c217cbaba8946d63c9e21da
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> index 55cd204..651a3f2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> @@ -30,8 +30,7 @@
>
> #include "ppatomctrl.h"
> #include "pp_debug.h"
> -#include "smu_ucode_xfer_vi.h"
> -#include "smu7_smumgr.h"
> +
>
> /* MP Apertures */
> #define MP0_Public 0x03800000
> @@ -392,8 +391,7 @@ static int vega12_smu_init(struct pp_hwmgr *hwmgr)
> struct cgs_firmware_info info = {0};
> int ret;
>
> - ret = cgs_get_firmware_info(hwmgr->device,
> - smu7_convert_fw_type_to_cgs(UCODE_ID_SMU),
> + ret = cgs_get_firmware_info(hwmgr->device, CGS_UCODE_ID_SMU,
> &info);
> if (ret || !info.kptr)
> return -EINVAL;
> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2018-03-28 3:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 10:33 [PATCH] drm/amd/pp: Clean header file in vega12_smumgr.c Rex Zhu
[not found] ` <1522146825-16458-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
2018-03-27 22:41 ` Alex Deucher
2018-03-28 3:03 ` Huang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328030331.GA9500@hr-amur2 \
--to=ray.huang-5c7gfcevmho@public.gmane.org \
--cc=Rex.Zhu-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox