* [PATCH] drm/amd/pp: Clean header file in vega12_smumgr.c
@ 2018-03-27 10:33 Rex Zhu
[not found] ` <1522146825-16458-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Rex Zhu @ 2018-03-27 10:33 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Rex Zhu
Change-Id: I736fe788980823d12c217cbaba8946d63c9e21da
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
---
drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
index 55cd204..651a3f2 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
@@ -30,8 +30,7 @@
#include "ppatomctrl.h"
#include "pp_debug.h"
-#include "smu_ucode_xfer_vi.h"
-#include "smu7_smumgr.h"
+
/* MP Apertures */
#define MP0_Public 0x03800000
@@ -392,8 +391,7 @@ static int vega12_smu_init(struct pp_hwmgr *hwmgr)
struct cgs_firmware_info info = {0};
int ret;
- ret = cgs_get_firmware_info(hwmgr->device,
- smu7_convert_fw_type_to_cgs(UCODE_ID_SMU),
+ ret = cgs_get_firmware_info(hwmgr->device, CGS_UCODE_ID_SMU,
&info);
if (ret || !info.kptr)
return -EINVAL;
--
1.9.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/pp: Clean header file in vega12_smumgr.c
[not found] ` <1522146825-16458-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
@ 2018-03-27 22:41 ` Alex Deucher
2018-03-28 3:03 ` Huang Rui
1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2018-03-27 22:41 UTC (permalink / raw)
To: Rex Zhu; +Cc: amd-gfx list
On Tue, Mar 27, 2018 at 6:33 AM, Rex Zhu <Rex.Zhu@amd.com> wrote:
> Change-Id: I736fe788980823d12c217cbaba8946d63c9e21da
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> index 55cd204..651a3f2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> @@ -30,8 +30,7 @@
>
> #include "ppatomctrl.h"
> #include "pp_debug.h"
> -#include "smu_ucode_xfer_vi.h"
> -#include "smu7_smumgr.h"
> +
>
> /* MP Apertures */
> #define MP0_Public 0x03800000
> @@ -392,8 +391,7 @@ static int vega12_smu_init(struct pp_hwmgr *hwmgr)
> struct cgs_firmware_info info = {0};
> int ret;
>
> - ret = cgs_get_firmware_info(hwmgr->device,
> - smu7_convert_fw_type_to_cgs(UCODE_ID_SMU),
> + ret = cgs_get_firmware_info(hwmgr->device, CGS_UCODE_ID_SMU,
> &info);
> if (ret || !info.kptr)
> return -EINVAL;
> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/pp: Clean header file in vega12_smumgr.c
[not found] ` <1522146825-16458-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
2018-03-27 22:41 ` Alex Deucher
@ 2018-03-28 3:03 ` Huang Rui
1 sibling, 0 replies; 3+ messages in thread
From: Huang Rui @ 2018-03-28 3:03 UTC (permalink / raw)
To: Rex Zhu; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Tue, Mar 27, 2018 at 06:33:45PM +0800, Rex Zhu wrote:
> Change-Id: I736fe788980823d12c217cbaba8946d63c9e21da
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> index 55cd204..651a3f2 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/vega12_smumgr.c
> @@ -30,8 +30,7 @@
>
> #include "ppatomctrl.h"
> #include "pp_debug.h"
> -#include "smu_ucode_xfer_vi.h"
> -#include "smu7_smumgr.h"
> +
>
> /* MP Apertures */
> #define MP0_Public 0x03800000
> @@ -392,8 +391,7 @@ static int vega12_smu_init(struct pp_hwmgr *hwmgr)
> struct cgs_firmware_info info = {0};
> int ret;
>
> - ret = cgs_get_firmware_info(hwmgr->device,
> - smu7_convert_fw_type_to_cgs(UCODE_ID_SMU),
> + ret = cgs_get_firmware_info(hwmgr->device, CGS_UCODE_ID_SMU,
> &info);
> if (ret || !info.kptr)
> return -EINVAL;
> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-28 3:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-27 10:33 [PATCH] drm/amd/pp: Clean header file in vega12_smumgr.c Rex Zhu
[not found] ` <1522146825-16458-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
2018-03-27 22:41 ` Alex Deucher
2018-03-28 3:03 ` Huang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox