From: Huang Rui <ray.huang-5C7GfCeVMHo@public.gmane.org>
To: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message
Date: Fri, 6 Jul 2018 17:57:38 +0800 [thread overview]
Message-ID: <20180706095737.GA1267@hr-amur2> (raw)
In-Reply-To: <20180705204633.20567-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
On Thu, Jul 05, 2018 at 03:46:33PM -0500, Alex Deucher wrote:
> Switching the firmware paths for CIK parts resulted
> in no need for this anymore.
>
> Fixes: "drm/amdgpu: switch firmware path for CIK parts"
> Noticed-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> index 2c2b93d4d63b..78339309a00c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
> @@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev)
> default: BUG();
> }
>
> - if (adev->asic_type == CHIP_TOPAZ)
> - snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
> - else
> - snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
> + snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
>
> err = request_firmware(&adev->gmc.fw, fw_name, adev->dev);
> if (err)
> --
> 2.13.6
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2018-07-06 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 20:46 [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message Alex Deucher
[not found] ` <20180705204633.20567-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2018-07-06 3:12 ` 答复: " Qu, Jim
[not found] ` <DM3PR12MB0873863D964AB302A611702699470-4hRkV8tDpBiYEITDcfEJ8AdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-07-06 8:03 ` Christian König
2018-07-06 8:26 ` Christian König
2018-07-06 9:57 ` Huang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180706095737.GA1267@hr-amur2 \
--to=ray.huang-5c7gfcevmho@public.gmane.org \
--cc=alexander.deucher-5C7GfCeVMHo@public.gmane.org \
--cc=alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox