* [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message
@ 2018-07-05 20:46 Alex Deucher
[not found] ` <20180705204633.20567-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2018-07-05 20:46 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
Switching the firmware paths for CIK parts resulted
in no need for this anymore.
Fixes: "drm/amdgpu: switch firmware path for CIK parts"
Noticed-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
index 2c2b93d4d63b..78339309a00c 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c
@@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev)
default: BUG();
}
- if (adev->asic_type == CHIP_TOPAZ)
- snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
- else
- snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
+ snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name);
err = request_firmware(&adev->gmc.fw, fw_name, adev->dev);
if (err)
--
2.13.6
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <20180705204633.20567-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>]
* 答复: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message [not found] ` <20180705204633.20567-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> @ 2018-07-06 3:12 ` Qu, Jim [not found] ` <DM3PR12MB0873863D964AB302A611702699470-4hRkV8tDpBiYEITDcfEJ8AdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2018-07-06 9:57 ` Huang Rui 1 sibling, 1 reply; 5+ messages in thread From: Qu, Jim @ 2018-07-06 3:12 UTC (permalink / raw) To: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Deucher, Alexander Reviewed-by: Jim Qu <Jim.Qu@amd.com> Thanks JimQu ________________________________________ 发件人: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> 代表 Alex Deucher <alexdeucher@gmail.com> 发送时间: 2018年7月6日 4:46:33 收件人: amd-gfx@lists.freedesktop.org 抄送: Deucher, Alexander 主题: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message Switching the firmware paths for CIK parts resulted in no need for this anymore. Fixes: "drm/amdgpu: switch firmware path for CIK parts" Noticed-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> --- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c index 2c2b93d4d63b..78339309a00c 100644 --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c @@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev) default: BUG(); } - if (adev->asic_type == CHIP_TOPAZ) - snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); - else - snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); + snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); err = request_firmware(&adev->gmc.fw, fw_name, adev->dev); if (err) -- 2.13.6 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 5+ messages in thread
[parent not found: <DM3PR12MB0873863D964AB302A611702699470-4hRkV8tDpBiYEITDcfEJ8AdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: 答复: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message [not found] ` <DM3PR12MB0873863D964AB302A611702699470-4hRkV8tDpBiYEITDcfEJ8AdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2018-07-06 8:03 ` Christian König 2018-07-06 8:26 ` Christian König 1 sibling, 0 replies; 5+ messages in thread From: Christian König @ 2018-07-06 8:03 UTC (permalink / raw) To: Qu, Jim, Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Deucher, Alexander Reviewed-by: Christian König <christian.koenig@amd.com> Am 06.07.2018 um 05:12 schrieb Qu, Jim: > Reviewed-by: Jim Qu <Jim.Qu@amd.com> > > Thanks > JimQu > > ________________________________________ > 发件人: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> 代表 Alex Deucher <alexdeucher@gmail.com> > 发送时间: 2018年7月6日 4:46:33 > 收件人: amd-gfx@lists.freedesktop.org > 抄送: Deucher, Alexander > 主题: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message > > Switching the firmware paths for CIK parts resulted > in no need for this anymore. > > Fixes: "drm/amdgpu: switch firmware path for CIK parts" > Noticed-by: Julia Lawall <Julia.Lawall@lip6.fr> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > index 2c2b93d4d63b..78339309a00c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > @@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev) > default: BUG(); > } > > - if (adev->asic_type == CHIP_TOPAZ) > - snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); > - else > - snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); > + snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); > > err = request_firmware(&adev->gmc.fw, fw_name, adev->dev); > if (err) > -- > 2.13.6 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: 答复: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message [not found] ` <DM3PR12MB0873863D964AB302A611702699470-4hRkV8tDpBiYEITDcfEJ8AdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2018-07-06 8:03 ` Christian König @ 2018-07-06 8:26 ` Christian König 1 sibling, 0 replies; 5+ messages in thread From: Christian König @ 2018-07-06 8:26 UTC (permalink / raw) To: Qu, Jim, Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Deucher, Alexander Reviewed-by: Christian König <christian.koenig@amd.com> Am 06.07.2018 um 05:12 schrieb Qu, Jim: > Reviewed-by: Jim Qu <Jim.Qu@amd.com> > > Thanks > JimQu > > ________________________________________ > 发件人: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> 代表 Alex Deucher <alexdeucher@gmail.com> > 发送时间: 2018年7月6日 4:46:33 > 收件人: amd-gfx@lists.freedesktop.org > 抄送: Deucher, Alexander > 主题: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message > > Switching the firmware paths for CIK parts resulted > in no need for this anymore. > > Fixes: "drm/amdgpu: switch firmware path for CIK parts" > Noticed-by: Julia Lawall <Julia.Lawall@lip6.fr> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > index 2c2b93d4d63b..78339309a00c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > @@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev) > default: BUG(); > } > > - if (adev->asic_type == CHIP_TOPAZ) > - snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); > - else > - snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); > + snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); > > err = request_firmware(&adev->gmc.fw, fw_name, adev->dev); > if (err) > -- > 2.13.6 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message [not found] ` <20180705204633.20567-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> 2018-07-06 3:12 ` 答复: " Qu, Jim @ 2018-07-06 9:57 ` Huang Rui 1 sibling, 0 replies; 5+ messages in thread From: Huang Rui @ 2018-07-06 9:57 UTC (permalink / raw) To: Alex Deucher; +Cc: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Thu, Jul 05, 2018 at 03:46:33PM -0500, Alex Deucher wrote: > Switching the firmware paths for CIK parts resulted > in no need for this anymore. > > Fixes: "drm/amdgpu: switch firmware path for CIK parts" > Noticed-by: Julia Lawall <Julia.Lawall@lip6.fr> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Reviewed-by: Huang Rui <ray.huang@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > index 2c2b93d4d63b..78339309a00c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c > @@ -147,10 +147,7 @@ static int gmc_v7_0_init_microcode(struct amdgpu_device *adev) > default: BUG(); > } > > - if (adev->asic_type == CHIP_TOPAZ) > - snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); > - else > - snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); > + snprintf(fw_name, sizeof(fw_name), "amdgpu/%s_mc.bin", chip_name); > > err = request_firmware(&adev->gmc.fw, fw_name, adev->dev); > if (err) > -- > 2.13.6 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-06 9:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-05 20:46 [PATCH] drm/amdgpu/gmc7: simplify logic in firmware message Alex Deucher
[not found] ` <20180705204633.20567-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2018-07-06 3:12 ` 答复: " Qu, Jim
[not found] ` <DM3PR12MB0873863D964AB302A611702699470-4hRkV8tDpBiYEITDcfEJ8AdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2018-07-06 8:03 ` Christian König
2018-07-06 8:26 ` Christian König
2018-07-06 9:57 ` Huang Rui
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox