AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
  • * [PATCH AUTOSEL 4.19 30/53] drm/amd/display: fix cursor black issue
           [not found] <20190427014051.7522-1-sashal@kernel.org>
           [not found] ` <20190427014051.7522-1-sashal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
    @ 2019-04-27  1:40 ` Sasha Levin
      1 sibling, 0 replies; 4+ messages in thread
    From: Sasha Levin @ 2019-04-27  1:40 UTC (permalink / raw)
      To: linux-kernel, stable
      Cc: Alex Deucher, Sasha Levin, tiancyin, dri-devel, amd-gfx
    
    From: tiancyin <tianci.yin@amd.com>
    
    [ Upstream commit c1cefe115d1cdc460014483319d440b2f0d07c68 ]
    
    [Why]
    the member sdr_white_level of struct dc_cursor_attributes was not
    initialized, then the random value result that
    dcn10_set_cursor_sdr_white_level() set error hw_scale value 0x20D9(normal
    value is 0x3c00), this cause the black cursor issue.
    
    [how]
    just initilize the obj of struct dc_cursor_attributes to zero to avoid
    the random value.
    
    Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
    Signed-off-by: Tianci Yin <tianci.yin@amd.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
     drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 +
     1 file changed, 1 insertion(+)
    
    diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    index 2b8b892eb846..76ee2de43ea6 100644
    --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    @@ -4028,6 +4028,7 @@ static void handle_cursor_update(struct drm_plane *plane,
     	amdgpu_crtc->cursor_width = plane->state->crtc_w;
     	amdgpu_crtc->cursor_height = plane->state->crtc_h;
     
    +	memset(&attributes, 0, sizeof(attributes));
     	attributes.address.high_part = upper_32_bits(address);
     	attributes.address.low_part  = lower_32_bits(address);
     	attributes.width             = plane->state->crtc_w;
    -- 
    2.19.1
    
    _______________________________________________
    dri-devel mailing list
    dri-devel@lists.freedesktop.org
    https://lists.freedesktop.org/mailman/listinfo/dri-devel
    
    ^ permalink raw reply related	[flat|nested] 4+ messages in thread

  • end of thread, other threads:[~2019-05-08 17:35 UTC | newest]
    
    Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
    -- links below jump to the message on this page --
         [not found] <20190427014051.7522-1-sashal@kernel.org>
         [not found] ` <20190427014051.7522-1-sashal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
    2019-04-27  1:40   ` [PATCH AUTOSEL 4.19 29/53] drm/amdkfd: Add picasso pci id Sasha Levin
         [not found]     ` <20190427014051.7522-29-sashal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
    2019-04-27 13:49       ` Deucher, Alexander
    2019-05-08 17:35         ` Sasha Levin
    2019-04-27  1:40 ` [PATCH AUTOSEL 4.19 30/53] drm/amd/display: fix cursor black issue Sasha Levin
    

    This is a public inbox, see mirroring instructions
    for how to clone and mirror all data and code used for this inbox