From: "Ville Syrjälä" <ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Lyude Paul <lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: sunpeng.li-5C7GfCeVMHo@public.gmane.org,
Daniel Vetter <daniel.vetter-/w4YWyX8dFk@public.gmane.org>,
Sean Paul <sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org>,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH 07/10] drm/i915: Implement MST Aux device registration
Date: Fri, 12 Jul 2019 23:15:25 +0300 [thread overview]
Message-ID: <20190712201525.GO5942@intel.com> (raw)
In-Reply-To: <20190712200559.GN5942-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Fri, Jul 12, 2019 at 11:05:59PM +0300, Ville Syrjälä wrote:
> On Fri, Jul 12, 2019 at 03:48:53PM -0400, Lyude Paul wrote:
> > BTW, I just tried these patches on my T450s (using i915) and I'm seeing some
> > kernel warnings with them when adding DP aux devices after connecting a new
> > MST topology to the system:
> >
> > [ 367.742571] WARNING: CPU: 2 PID: 442 at drivers/gpu/drm/drm_mode_object.c:45 __drm_mode_object_add+0xaa/0xb0 [drm]
>
> Looks like Daniel added that particular WARN in
> commit 4f5368b5541a ("drm/kms: Catch mode_object lifetime errors").
And I'm the one who added the max_bpc prop to the mst connectors, which
is a per-connector property (ie. a new one gets created for every
connecotor). So that could be a problem I suppose. I guess we may need
to create just one of these for MST and reuse it for every connector.
Could just point at the prop of the corresponding SST connector I
suppose...
+ /* Reuse the prop because blah */
+ connector->max_bpc_property =
+ intel_dp->attached_connector->base.max_bpc_property;
drm_connector_attach_max_bpc_property(connector, 6, 12);
--
Ville Syrjälä
Intel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-07-12 20:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 19:05 [PATCH 00/10] Enable MST Aux devices (v2) sunpeng.li-5C7GfCeVMHo
2019-07-04 19:05 ` [PATCH 03/10] drm/sysfs: Add mstpath attribute to connector devices sunpeng.li
[not found] ` <20190704190519.29525-4-sunpeng.li-5C7GfCeVMHo@public.gmane.org>
2019-07-04 19:33 ` Ville Syrjälä
2019-07-05 14:03 ` Li, Sun peng (Leo)
2019-07-05 14:32 ` [PATCH v2] " sunpeng.li-5C7GfCeVMHo
[not found] ` <20190705143220.11109-1-sunpeng.li-5C7GfCeVMHo@public.gmane.org>
2019-07-10 10:07 ` Ville Syrjälä
2019-07-10 22:50 ` Lyude Paul
[not found] ` <346980b73f3b1fbbc70cbf3771788cec0777d4c0.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2019-07-16 18:28 ` Li, Sun peng (Leo)
2019-07-16 20:28 ` Lyude Paul
[not found] ` <20190704190519.29525-1-sunpeng.li-5C7GfCeVMHo@public.gmane.org>
2019-07-04 19:05 ` [PATCH 01/10] drm/dp: Use non-cyclic idr sunpeng.li-5C7GfCeVMHo
2019-07-04 19:05 ` [PATCH 02/10] drm/dp_mst: Enable registration of AUX devices for MST ports (v2) sunpeng.li-5C7GfCeVMHo
[not found] ` <20190704190519.29525-3-sunpeng.li-5C7GfCeVMHo@public.gmane.org>
2019-07-10 19:51 ` Lyude Paul
2019-07-10 23:25 ` Lyude Paul
2019-07-04 19:05 ` [PATCH 04/10] drm/nouveau: Use connector kdev as aux device parent sunpeng.li-5C7GfCeVMHo
2019-07-12 19:55 ` Lyude Paul
2019-07-04 19:05 ` [PATCH 05/10] drm/bridge/analogix-anx78xx: " sunpeng.li-5C7GfCeVMHo
2019-07-04 19:05 ` [PATCH 06/10] drm/amd/display: " sunpeng.li-5C7GfCeVMHo
2019-07-04 19:05 ` [PATCH 07/10] drm/i915: Implement MST Aux device registration sunpeng.li-5C7GfCeVMHo
2019-07-10 10:06 ` Ville Syrjälä
2019-07-12 19:48 ` Lyude Paul
2019-07-12 20:05 ` Ville Syrjälä
[not found] ` <20190712200559.GN5942-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2019-07-12 20:15 ` Ville Syrjälä [this message]
2019-07-23 14:01 ` Li, Sun peng (Leo)
2019-07-04 19:05 ` [PATCH 08/10] drm/nouveau/kms/nv50: " sunpeng.li-5C7GfCeVMHo
2019-07-12 19:54 ` Lyude Paul
2019-07-04 19:05 ` [PATCH 09/10] drm/radeon: " sunpeng.li-5C7GfCeVMHo
2019-07-04 19:05 ` [PATCH 10/10] drm/amd/display: " sunpeng.li-5C7GfCeVMHo
2019-07-09 19:10 ` [PATCH 00/10] Enable MST Aux devices (v2) Li, Sun peng (Leo)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712201525.GO5942@intel.com \
--to=ville.syrjala-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=daniel.vetter-/w4YWyX8dFk@public.gmane.org \
--cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org \
--cc=sunpeng.li-5C7GfCeVMHo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox