* [PATCH] drm/amdgpu: Fix unaligned memory copies
@ 2019-07-13 6:42 Kuehling, Felix
[not found] ` <20190713064245.20097-1-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Kuehling, Felix @ 2019-07-13 6:42 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
When starting a new mm_node, the page_offset becomes 0.
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
index 37d9a3b09946..d0f6c23ec7cf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
@@ -386,6 +386,7 @@ int amdgpu_ttm_copy_mem_to_mem(struct amdgpu_device *adev,
src_node_start = amdgpu_mm_node_addr(src->bo, ++src_mm,
src->mem);
src_node_size = (src_mm->size << PAGE_SHIFT);
+ src_page_offset = 0;
} else {
src_node_start += cur_size;
src_page_offset = src_node_start & (PAGE_SIZE - 1);
@@ -395,6 +396,7 @@ int amdgpu_ttm_copy_mem_to_mem(struct amdgpu_device *adev,
dst_node_start = amdgpu_mm_node_addr(dst->bo, ++dst_mm,
dst->mem);
dst_node_size = (dst_mm->size << PAGE_SHIFT);
+ dst_page_offset = 0;
} else {
dst_node_start += cur_size;
dst_page_offset = dst_node_start & (PAGE_SIZE - 1);
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <20190713064245.20097-1-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: Fix unaligned memory copies [not found] ` <20190713064245.20097-1-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org> @ 2019-07-15 16:12 ` Alex Deucher [not found] ` <CADnq5_OCXiEoPU5+K2-NQ+9zNMVRd2mMwY6NYeK6Jp0ssLcjtg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Alex Deucher @ 2019-07-15 16:12 UTC (permalink / raw) To: Kuehling, Felix; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org On Sat, Jul 13, 2019 at 2:43 AM Kuehling, Felix <Felix.Kuehling@amd.com> wrote: > > When starting a new mm_node, the page_offset becomes 0. > > Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index 37d9a3b09946..d0f6c23ec7cf 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -386,6 +386,7 @@ int amdgpu_ttm_copy_mem_to_mem(struct amdgpu_device *adev, > src_node_start = amdgpu_mm_node_addr(src->bo, ++src_mm, > src->mem); > src_node_size = (src_mm->size << PAGE_SHIFT); > + src_page_offset = 0; > } else { > src_node_start += cur_size; > src_page_offset = src_node_start & (PAGE_SIZE - 1); > @@ -395,6 +396,7 @@ int amdgpu_ttm_copy_mem_to_mem(struct amdgpu_device *adev, > dst_node_start = amdgpu_mm_node_addr(dst->bo, ++dst_mm, > dst->mem); > dst_node_size = (dst_mm->size << PAGE_SHIFT); > + dst_page_offset = 0; > } else { > dst_node_start += cur_size; > dst_page_offset = dst_node_start & (PAGE_SIZE - 1); > -- > 2.17.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CADnq5_OCXiEoPU5+K2-NQ+9zNMVRd2mMwY6NYeK6Jp0ssLcjtg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: Fix unaligned memory copies [not found] ` <CADnq5_OCXiEoPU5+K2-NQ+9zNMVRd2mMwY6NYeK6Jp0ssLcjtg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2019-07-15 19:33 ` Christian König 0 siblings, 0 replies; 3+ messages in thread From: Christian König @ 2019-07-15 19:33 UTC (permalink / raw) To: Alex Deucher, Kuehling, Felix Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Am 15.07.19 um 18:12 schrieb Alex Deucher: > On Sat, Jul 13, 2019 at 2:43 AM Kuehling, Felix <Felix.Kuehling@amd.com> wrote: >> When starting a new mm_node, the page_offset becomes 0. >> >> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com> > Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Reviewed-by: Christian König <christian.koenig@amd.com> > >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >> index 37d9a3b09946..d0f6c23ec7cf 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >> @@ -386,6 +386,7 @@ int amdgpu_ttm_copy_mem_to_mem(struct amdgpu_device *adev, >> src_node_start = amdgpu_mm_node_addr(src->bo, ++src_mm, >> src->mem); >> src_node_size = (src_mm->size << PAGE_SHIFT); >> + src_page_offset = 0; >> } else { >> src_node_start += cur_size; >> src_page_offset = src_node_start & (PAGE_SIZE - 1); >> @@ -395,6 +396,7 @@ int amdgpu_ttm_copy_mem_to_mem(struct amdgpu_device *adev, >> dst_node_start = amdgpu_mm_node_addr(dst->bo, ++dst_mm, >> dst->mem); >> dst_node_size = (dst_mm->size << PAGE_SHIFT); >> + dst_page_offset = 0; >> } else { >> dst_node_start += cur_size; >> dst_page_offset = dst_node_start & (PAGE_SIZE - 1); >> -- >> 2.17.1 >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-15 19:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-13 6:42 [PATCH] drm/amdgpu: Fix unaligned memory copies Kuehling, Felix
[not found] ` <20190713064245.20097-1-Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>
2019-07-15 16:12 ` Alex Deucher
[not found] ` <CADnq5_OCXiEoPU5+K2-NQ+9zNMVRd2mMwY6NYeK6Jp0ssLcjtg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-07-15 19:33 ` Christian König
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox