From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jerome Glisse <jglisse@redhat.com>,
Ralph Campbell <rcampbell@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
Felix.Kuehling@amd.com
Cc: Andrea Arcangeli <aarcange@redhat.com>,
linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, dri-devel@lists.freedesktop.org,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH hmm 02/15] mm/mmu_notifier: add an interval tree notifier
Date: Sun, 27 Oct 2019 20:15:37 -0300 [thread overview]
Message-ID: <20191027231537.GA25385@ziepe.ca> (raw)
In-Reply-To: <20191015181242.8343-3-jgg@ziepe.ca>
On Tue, Oct 15, 2019 at 03:12:29PM -0300, Jason Gunthorpe wrote:
> +static void mn_itree_release(struct mmu_notifier_mm *mmn_mm,
> + struct mm_struct *mm)
> +{
> + struct mmu_notifier_range range = {
> + .flags = MMU_NOTIFIER_RANGE_BLOCKABLE,
> + .event = MMU_NOTIFY_RELEASE,
> + .mm = mm,
> + .start = 0,
> + .end = ULONG_MAX,
> + };
> + struct mmu_range_notifier *mrn;
> + unsigned long cur_seq;
> + bool ret;
> +
> + for (mrn = mn_itree_inv_start_range(mmn_mm, &range, &cur_seq); mrn;
> + mrn = mn_itree_inv_next(mrn, &range)) {
> + ret = mrn->ops->invalidate(mrn, &range);
> + WARN_ON(ret);
This should be
WARN_ON(!ret)
Jason
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jerome Glisse <jglisse@redhat.com>,
Ralph Campbell <rcampbell@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
Felix.Kuehling@amd.com
Cc: Andrea Arcangeli <aarcange@redhat.com>,
linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org,
Michal Hocko <mhocko@kernel.org>,
linux-mm@kvack.org, dri-devel@lists.freedesktop.org,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH hmm 02/15] mm/mmu_notifier: add an interval tree notifier
Date: Sun, 27 Oct 2019 20:15:37 -0300 [thread overview]
Message-ID: <20191027231537.GA25385@ziepe.ca> (raw)
Message-ID: <20191027231537.H79Td_QBsSFwziTYaSLxHW1mdodVMomxXSbDaa6xakQ@z> (raw)
In-Reply-To: <20191015181242.8343-3-jgg@ziepe.ca>
On Tue, Oct 15, 2019 at 03:12:29PM -0300, Jason Gunthorpe wrote:
> +static void mn_itree_release(struct mmu_notifier_mm *mmn_mm,
> + struct mm_struct *mm)
> +{
> + struct mmu_notifier_range range = {
> + .flags = MMU_NOTIFIER_RANGE_BLOCKABLE,
> + .event = MMU_NOTIFY_RELEASE,
> + .mm = mm,
> + .start = 0,
> + .end = ULONG_MAX,
> + };
> + struct mmu_range_notifier *mrn;
> + unsigned long cur_seq;
> + bool ret;
> +
> + for (mrn = mn_itree_inv_start_range(mmn_mm, &range, &cur_seq); mrn;
> + mrn = mn_itree_inv_next(mrn, &range)) {
> + ret = mrn->ops->invalidate(mrn, &range);
> + WARN_ON(ret);
This should be
WARN_ON(!ret)
Jason
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-10-27 23:15 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 18:12 [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER Jason Gunthorpe
2019-10-16 5:11 ` Jürgen Groß
2019-10-16 6:35 ` Oleksandr Andrushchenko
2019-10-21 19:12 ` Jason Gunthorpe
[not found] ` <20191021191219.GJ6285-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-28 6:25 ` [Xen-devel] " Oleksandr Andrushchenko
2019-10-28 6:25 ` Oleksandr Andrushchenko
2019-10-15 18:12 ` [PATCH hmm 09/15] xen/gntdev: use mmu_range_notifier_insert Jason Gunthorpe
[not found] ` <20191015181242.8343-1-jgg-uk2M96/98Pc@public.gmane.org>
2019-10-15 18:12 ` [PATCH hmm 01/15] mm/mmu_notifier: define the header pre-processor parts even if disabled Jason Gunthorpe
[not found] ` <20191015181242.8343-2-jgg-uk2M96/98Pc@public.gmane.org>
2019-10-21 18:32 ` Jerome Glisse
2019-10-15 18:12 ` [PATCH hmm 02/15] mm/mmu_notifier: add an interval tree notifier Jason Gunthorpe
2019-10-21 18:30 ` Jerome Glisse
2019-10-21 18:54 ` Jason Gunthorpe
2019-10-21 19:11 ` Jerome Glisse
2019-10-21 19:24 ` Jason Gunthorpe
[not found] ` <20191021192448.GK6285-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-21 19:47 ` Jerome Glisse
2019-10-27 23:15 ` Jason Gunthorpe [this message]
2019-10-27 23:15 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 03/15] mm/hmm: allow hmm_range to be used with a mmu_range_notifier or hmm_mirror Jason Gunthorpe
2019-10-21 18:33 ` Jerome Glisse
2019-10-15 18:12 ` [PATCH hmm 04/15] mm/hmm: define the pre-processor related parts of hmm.h even if disabled Jason Gunthorpe
[not found] ` <20191015181242.8343-5-jgg-uk2M96/98Pc@public.gmane.org>
2019-10-21 18:31 ` Jerome Glisse
2019-10-15 18:12 ` [PATCH hmm 05/15] RDMA/odp: Use mmu_range_notifier_insert() Jason Gunthorpe
[not found] ` <20191015181242.8343-6-jgg-uk2M96/98Pc@public.gmane.org>
2019-11-04 20:25 ` Jason Gunthorpe
2019-11-04 20:25 ` Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 06/15] RDMA/hfi1: Use mmu_range_notifier_inset for user_exp_rcv Jason Gunthorpe
2019-10-29 12:15 ` Dennis Dalessandro
2019-10-29 12:15 ` Dennis Dalessandro
2019-10-15 18:12 ` [PATCH hmm 07/15] drm/radeon: use mmu_range_notifier_insert Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 10/15] nouveau: use mmu_notifier directly for invalidate_range_start Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 11/15] nouveau: use mmu_range_notifier instead of hmm_mirror Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 12/15] drm/amdgpu: Call find_vma under mmap_sem Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 13/15] drm/amdgpu: Use mmu_range_insert instead of hmm_mirror Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 14/15] drm/amdgpu: Use mmu_range_notifier " Jason Gunthorpe
2019-10-15 18:12 ` [PATCH hmm 15/15] mm/hmm: remove hmm_mirror and related Jason Gunthorpe
[not found] ` <20191015181242.8343-16-jgg-uk2M96/98Pc@public.gmane.org>
2019-10-21 18:38 ` Jerome Glisse
2019-10-21 18:57 ` Jason Gunthorpe
[not found] ` <20191021185738.GH6285-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-21 19:19 ` Jerome Glisse
2019-10-16 8:58 ` [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking Christian König
[not found] ` <bc954d29-388b-9e29-f960-115ccc6b9fea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-10-16 16:04 ` Jason Gunthorpe
[not found] ` <20191016160444.GB3430-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-17 8:54 ` Christian König
2019-10-17 16:26 ` Yang, Philip
[not found] ` <2046e0b4-ba05-0683-5804-e9bbf903658d-5C7GfCeVMHo@public.gmane.org>
2019-10-17 16:47 ` Koenig, Christian
[not found] ` <d6bcbd2a-2519-8945-eaf5-4f4e738c7fa9-5C7GfCeVMHo@public.gmane.org>
2019-10-18 20:36 ` Jason Gunthorpe
2019-10-20 14:21 ` Koenig, Christian
2019-10-21 13:57 ` Jason Gunthorpe
[not found] ` <20191021135744.GA25164-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-21 14:28 ` Koenig, Christian
2019-10-21 15:12 ` Jason Gunthorpe
[not found] ` <20191021151221.GC25164-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-22 7:57 ` Daniel Vetter
2019-10-22 15:01 ` Jason Gunthorpe
2019-10-23 9:08 ` Daniel Vetter
2019-10-23 9:08 ` Daniel Vetter
2019-10-23 9:32 ` Christian König
2019-10-23 9:32 ` Christian König
[not found] ` <13edf841-421e-3522-fcec-ef919c2013ef-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-10-23 16:52 ` Jerome Glisse
2019-10-23 16:52 ` Jerome Glisse
2019-10-23 17:24 ` Jason Gunthorpe
2019-10-23 17:24 ` Jason Gunthorpe
[not found] ` <20191023172442.GX22766-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-24 2:16 ` Christoph Hellwig
2019-10-24 2:16 ` Christoph Hellwig
2019-10-21 18:40 ` Jerome Glisse
2019-10-21 19:06 ` Jason Gunthorpe
[not found] ` <20191021190556.GI6285-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2019-10-23 20:26 ` Jerome Glisse
2019-10-23 20:26 ` Jerome Glisse
2019-10-21 15:55 ` Dennis Dalessandro
2019-10-21 16:58 ` Jason Gunthorpe
2019-10-22 11:56 ` Dennis Dalessandro
2019-10-22 14:37 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191027231537.GA25385@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Felix.Kuehling@amd.com \
--cc=aarcange@redhat.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox