AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Make some function static
@ 2020-09-16  2:31 Ye Bin
  0 siblings, 0 replies; only message in thread
From: Ye Bin @ 2020-09-16  2:31 UTC (permalink / raw)
  To: alexander.deucher, christian.koenig, amd-gfx; +Cc: Hulk Robot, Ye Bin

This addresses the following gcc warning with "make W=1":
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:621:22: warning: no previous prototype for ‘dce100_link_encoder_create’ [-Wmissing-prototypes]
 struct link_encoder *dce100_link_encoder_create(
                      ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:660:32: warning: no previous prototype for ‘dce100_opp_create’ [-Wmissing-prototypes]
 struct output_pixel_processor *dce100_opp_create(
                                ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:675:17: warning: no previous prototype for ‘dce100_aux_engine_create’ [-Wmissing-prototypes]
 struct dce_aux *dce100_aux_engine_create(
                 ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:713:20: warning: no previous prototype for ‘dce100_i2c_hw_create’ [-Wmissing-prototypes]
 struct dce_i2c_hw *dce100_i2c_hw_create(
                    ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:728:22: warning: no previous prototype for ‘dce100_clock_source_create’ [-Wmissing-prototypes]
 struct clock_source *dce100_clock_source_create(
                      ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:752:6: warning: no previous prototype for ‘dce100_clock_source_destroy’ [-Wmissing-prototypes]
 void dce100_clock_source_destroy(struct clock_source **clk_src)
      ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:841:6: warning: no previous prototype for ‘dce100_validate_bandwidth’ [-Wmissing-prototypes]
 bool dce100_validate_bandwidth(
      ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:886:16: warning: no previous prototype for ‘dce100_validate_global’ [-Wmissing-prototypes]
 enum dc_status dce100_validate_global(
                ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:896:16: warning: no previous prototype for ‘dce100_add_stream_to_ctx’ [-Wmissing-prototypes]
 enum dc_status dce100_add_stream_to_ctx(
                ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:923:16: warning: no previous prototype for ‘dce100_validate_plane’ [-Wmissing-prototypes]
 enum dc_status dce100_validate_plane(const struct dc_plane_state *plane_state, struct dc_caps *caps)
                ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:932:24: warning: no previous prototype for ‘dce100_find_first_free_match_stream_enc_for_link’ [-Wmissing-prototypes]
 struct stream_encoder *dce100_find_first_free_match_stream_enc_for_link(
                        ^
drivers/gpu/drm/amd/amdgpu/../display/dc/dce100/dce100_resource.c:1161:23: warning: no previous prototype for ‘dce100_create_resource_pool’ [-Wmissing-prototypes]
 struct resource_pool *dce100_create_resource_pool(

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ye Bin <yebin10@huawei.com>
---
 .../amd/display/dc/dce100/dce100_resource.c   | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
index a28c4ae0f259..4061a3fadc61 100644
--- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c
@@ -618,7 +618,7 @@ static const struct encoder_feature_support link_enc_feature = {
 		.flags.bits.IS_TPS3_CAPABLE = true
 };
 
-struct link_encoder *dce100_link_encoder_create(
+static struct link_encoder *dce100_link_encoder_create(
 	const struct encoder_init_data *enc_init_data)
 {
 	struct dce110_link_encoder *enc110 =
@@ -657,7 +657,7 @@ static struct panel_cntl *dce100_panel_cntl_create(const struct panel_cntl_init_
 	return &panel_cntl->base;
 }
 
-struct output_pixel_processor *dce100_opp_create(
+static struct output_pixel_processor *dce100_opp_create(
 	struct dc_context *ctx,
 	uint32_t inst)
 {
@@ -672,7 +672,7 @@ struct output_pixel_processor *dce100_opp_create(
 	return &opp->base;
 }
 
-struct dce_aux *dce100_aux_engine_create(
+static struct dce_aux *dce100_aux_engine_create(
 	struct dc_context *ctx,
 	uint32_t inst)
 {
@@ -710,7 +710,7 @@ static const struct dce_i2c_mask i2c_masks = {
 		I2C_COMMON_MASK_SH_LIST_DCE_COMMON_BASE(_MASK)
 };
 
-struct dce_i2c_hw *dce100_i2c_hw_create(
+static struct dce_i2c_hw *dce100_i2c_hw_create(
 	struct dc_context *ctx,
 	uint32_t inst)
 {
@@ -725,7 +725,7 @@ struct dce_i2c_hw *dce100_i2c_hw_create(
 
 	return dce_i2c_hw;
 }
-struct clock_source *dce100_clock_source_create(
+static struct clock_source *dce100_clock_source_create(
 	struct dc_context *ctx,
 	struct dc_bios *bios,
 	enum clock_source_id id,
@@ -749,7 +749,7 @@ struct clock_source *dce100_clock_source_create(
 	return NULL;
 }
 
-void dce100_clock_source_destroy(struct clock_source **clk_src)
+static void dce100_clock_source_destroy(struct clock_source **clk_src)
 {
 	kfree(TO_DCE110_CLK_SRC(*clk_src));
 	*clk_src = NULL;
@@ -838,7 +838,7 @@ static enum dc_status build_mapped_resource(
 	return DC_OK;
 }
 
-bool dce100_validate_bandwidth(
+static bool dce100_validate_bandwidth(
 	struct dc  *dc,
 	struct dc_state *context,
 	bool fast_validate)
@@ -883,7 +883,7 @@ static bool dce100_validate_surface_sets(
 	return true;
 }
 
-enum dc_status dce100_validate_global(
+static enum dc_status dce100_validate_global(
 		struct dc  *dc,
 		struct dc_state *context)
 {
@@ -893,7 +893,7 @@ enum dc_status dce100_validate_global(
 	return DC_OK;
 }
 
-enum dc_status dce100_add_stream_to_ctx(
+static enum dc_status dce100_add_stream_to_ctx(
 		struct dc *dc,
 		struct dc_state *new_ctx,
 		struct dc_stream_state *dc_stream)
@@ -920,7 +920,7 @@ static void dce100_destroy_resource_pool(struct resource_pool **pool)
 	*pool = NULL;
 }
 
-enum dc_status dce100_validate_plane(const struct dc_plane_state *plane_state, struct dc_caps *caps)
+static enum dc_status dce100_validate_plane(const struct dc_plane_state *plane_state, struct dc_caps *caps)
 {
 
 	if (plane_state->format < SURFACE_PIXEL_FORMAT_VIDEO_BEGIN)
@@ -929,7 +929,7 @@ enum dc_status dce100_validate_plane(const struct dc_plane_state *plane_state, s
 	return DC_FAIL_SURFACE_VALIDATE;
 }
 
-struct stream_encoder *dce100_find_first_free_match_stream_enc_for_link(
+static struct stream_encoder *dce100_find_first_free_match_stream_enc_for_link(
 		struct resource_context *res_ctx,
 		const struct resource_pool *pool,
 		struct dc_stream_state *stream)
@@ -1158,7 +1158,7 @@ static bool dce100_resource_construct(
 	return false;
 }
 
-struct resource_pool *dce100_create_resource_pool(
+static struct resource_pool *dce100_create_resource_pool(
 	uint8_t num_virtual_links,
 	struct dc  *dc)
 {
-- 
2.25.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] only message in thread
only message in thread, other threads:[~2020-09-16  3:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-16  2:31 [PATCH] drm/amd/display: Make some function static Ye Bin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox