From: Huang Rui <ray.huang@amd.com>
To: "Hou, Xiaomeng (Matthew)" <Xiaomeng.Hou@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] Revert "drm/amdgpu: IP discovery table is not ready yet for VG"
Date: Fri, 23 Oct 2020 16:28:31 +0800 [thread overview]
Message-ID: <20201023082831.GA1424760@hr-amd> (raw)
In-Reply-To: <20201023082115.13573-1-Xiaomeng.Hou@amd.com>
On Fri, Oct 23, 2020 at 04:21:15PM +0800, Hou, Xiaomeng (Matthew) wrote:
> This reverts commit ba502322c9f216552485cea967aeb8adbaf03a02.
I suggest you didn't highlight to revert a patch. Becasue previous commit
was good before, because it's the gap that firmware/sbios support.
Just modify the subject as "drm/amdgpu: enable IP discovery for vangogh",
that's enough.
With that fixed, patch is Reviewed-by: Huang Rui <ray.huang@amd.com>
>
> IP discovery table has been verified on vangogh.
>
> Signed-off-by: Xiaomeng Hou <Xiaomeng.Hou@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/nv.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
> index 72435e0eb8b9..30ec826c8760 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nv.c
> @@ -449,10 +449,6 @@ static int nv_reg_base_init(struct amdgpu_device *adev)
> {
> int r;
>
> - /* IP discovery table is not available yet */
> - if (adev->asic_type == CHIP_VANGOGH)
> - goto legacy_init;
> -
> if (amdgpu_discovery) {
> r = amdgpu_discovery_reg_base_init(adev);
> if (r) {
> --
> 2.17.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-10-23 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 8:21 [PATCH] Revert "drm/amdgpu: IP discovery table is not ready yet for VG" Xiaomeng Hou
2020-10-23 8:28 ` Huang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201023082831.GA1424760@hr-amd \
--to=ray.huang@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Xiaomeng.Hou@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox