* [PATCH] Revert "drm/amdgpu: IP discovery table is not ready yet for VG"
@ 2020-10-23 8:21 Xiaomeng Hou
2020-10-23 8:28 ` Huang Rui
0 siblings, 1 reply; 2+ messages in thread
From: Xiaomeng Hou @ 2020-10-23 8:21 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Ray.Huang, Xiaomeng Hou
This reverts commit ba502322c9f216552485cea967aeb8adbaf03a02.
IP discovery table has been verified on vangogh.
Signed-off-by: Xiaomeng Hou <Xiaomeng.Hou@amd.com>
---
drivers/gpu/drm/amd/amdgpu/nv.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
index 72435e0eb8b9..30ec826c8760 100644
--- a/drivers/gpu/drm/amd/amdgpu/nv.c
+++ b/drivers/gpu/drm/amd/amdgpu/nv.c
@@ -449,10 +449,6 @@ static int nv_reg_base_init(struct amdgpu_device *adev)
{
int r;
- /* IP discovery table is not available yet */
- if (adev->asic_type == CHIP_VANGOGH)
- goto legacy_init;
-
if (amdgpu_discovery) {
r = amdgpu_discovery_reg_base_init(adev);
if (r) {
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Revert "drm/amdgpu: IP discovery table is not ready yet for VG"
2020-10-23 8:21 [PATCH] Revert "drm/amdgpu: IP discovery table is not ready yet for VG" Xiaomeng Hou
@ 2020-10-23 8:28 ` Huang Rui
0 siblings, 0 replies; 2+ messages in thread
From: Huang Rui @ 2020-10-23 8:28 UTC (permalink / raw)
To: Hou, Xiaomeng (Matthew); +Cc: Deucher, Alexander, amd-gfx@lists.freedesktop.org
On Fri, Oct 23, 2020 at 04:21:15PM +0800, Hou, Xiaomeng (Matthew) wrote:
> This reverts commit ba502322c9f216552485cea967aeb8adbaf03a02.
I suggest you didn't highlight to revert a patch. Becasue previous commit
was good before, because it's the gap that firmware/sbios support.
Just modify the subject as "drm/amdgpu: enable IP discovery for vangogh",
that's enough.
With that fixed, patch is Reviewed-by: Huang Rui <ray.huang@amd.com>
>
> IP discovery table has been verified on vangogh.
>
> Signed-off-by: Xiaomeng Hou <Xiaomeng.Hou@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/nv.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nv.c b/drivers/gpu/drm/amd/amdgpu/nv.c
> index 72435e0eb8b9..30ec826c8760 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nv.c
> @@ -449,10 +449,6 @@ static int nv_reg_base_init(struct amdgpu_device *adev)
> {
> int r;
>
> - /* IP discovery table is not available yet */
> - if (adev->asic_type == CHIP_VANGOGH)
> - goto legacy_init;
> -
> if (amdgpu_discovery) {
> r = amdgpu_discovery_reg_base_init(adev);
> if (r) {
> --
> 2.17.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-23 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-23 8:21 [PATCH] Revert "drm/amdgpu: IP discovery table is not ready yet for VG" Xiaomeng Hou
2020-10-23 8:28 ` Huang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox