* [PATCH] drm/amdgpu: remove unneeded semicolon
@ 2020-10-27 19:07 trix
2020-10-30 3:34 ` Alex Deucher
0 siblings, 1 reply; 7+ messages in thread
From: trix @ 2020-10-27 19:07 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel,
jonathan.kim, harish.kasiviswanathan, Felix.Kuehling, zhengbin13,
luben.tuikov, Joseph.Greathouse, Hawking.Zhang, guchun.chen,
john.clements, tao.zhou1, Dennis.Li, Stanley.Yang
Cc: Tom Rix, dri-devel, amd-gfx, linux-kernel
From: Tom Rix <trix@redhat.com>
A semicolon is not needed after a switch statement.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
index 1b213c4ddfcb..19c0a3655228 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
@@ -654,7 +654,7 @@ int amdgpu_pmu_init(struct amdgpu_device *adev)
default:
return 0;
- };
+ }
return ret;
}
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index 8bf6a7c056bc..a61cf8cfbfc3 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -953,7 +953,7 @@ static char *amdgpu_ras_badpage_flags_str(unsigned int flags)
case AMDGPU_RAS_RETIRE_PAGE_FAULT:
default:
return "F";
- };
+ }
}
/**
--
2.18.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded semicolon
2020-10-27 19:07 [PATCH] drm/amdgpu: remove unneeded semicolon trix
@ 2020-10-30 3:34 ` Alex Deucher
0 siblings, 0 replies; 7+ messages in thread
From: Alex Deucher @ 2020-10-30 3:34 UTC (permalink / raw)
To: trix
Cc: Kim, Jonathan, Joseph Greathouse, Chen, Guchun, Dave Airlie,
Kuehling, Felix, Tao Zhou, Harish Kasiviswanathan, LKML,
Maling list - DRI developers, zhengbin, Tuikov, Luben,
Stanley.Yang, amd-gfx list, Daniel Vetter, Deucher, Alexander,
John Clements, Christian Koenig, Dennis Li, Hawking Zhang
Applied. I dropped the first hunk as that fix had already been
submitted by someone else.
Alex
On Tue, Oct 27, 2020 at 3:07 PM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> index 1b213c4ddfcb..19c0a3655228 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> @@ -654,7 +654,7 @@ int amdgpu_pmu_init(struct amdgpu_device *adev)
>
> default:
> return 0;
> - };
> + }
>
> return ret;
> }
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index 8bf6a7c056bc..a61cf8cfbfc3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -953,7 +953,7 @@ static char *amdgpu_ras_badpage_flags_str(unsigned int flags)
> case AMDGPU_RAS_RETIRE_PAGE_FAULT:
> default:
> return "F";
> - };
> + }
> }
>
> /**
> --
> 2.18.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drm/amdgpu: remove unneeded semicolon
@ 2023-05-05 7:37 Jiapeng Chong
2023-05-05 18:51 ` Alex Deucher
0 siblings, 1 reply; 7+ messages in thread
From: Jiapeng Chong @ 2023-05-05 7:37 UTC (permalink / raw)
To: alexander.deucher
Cc: Jiapeng Chong, Xinhui.Pan, Abaci Robot, linux-kernel, amd-gfx,
dri-devel, daniel, airlied, christian.koenig
No functional modification involved.
./drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c:146:2-3: Unneeded semicolon.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4871
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c
index 24d12075ca3a..a331a59c49e3 100644
--- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c
+++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c
@@ -143,7 +143,7 @@ static void nbio_v7_9_sdma_doorbell_range(struct amdgpu_device *adev, int instan
break;
default:
break;
- };
+ }
return;
}
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amdgpu: remove unneeded semicolon
2023-05-05 7:37 Jiapeng Chong
@ 2023-05-05 18:51 ` Alex Deucher
0 siblings, 0 replies; 7+ messages in thread
From: Alex Deucher @ 2023-05-05 18:51 UTC (permalink / raw)
To: Jiapeng Chong
Cc: Xinhui.Pan, Abaci Robot, linux-kernel, dri-devel, amd-gfx,
alexander.deucher, christian.koenig
Applied. Thanks!
Alex
On Fri, May 5, 2023 at 3:43 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> No functional modification involved.
>
> ./drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c:146:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4871
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c
> index 24d12075ca3a..a331a59c49e3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c
> +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_9.c
> @@ -143,7 +143,7 @@ static void nbio_v7_9_sdma_doorbell_range(struct amdgpu_device *adev, int instan
> break;
> default:
> break;
> - };
> + }
>
> return;
> }
> --
> 2.20.1.7.g153144c
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] drm/amdgpu: Remove unneeded semicolon
@ 2020-04-24 7:56 Zheng Bin
2020-04-24 7:51 ` Christian König
0 siblings, 1 reply; 7+ messages in thread
From: Zheng Bin @ 2020-04-24 7:56 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel, dri-devel,
amd-gfx
Cc: zhengbin13
Fixes coccicheck warning:
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2534:2-3: Unneeded semicolon
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 09aa5f509bd2..43d84214995c 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -2531,7 +2531,7 @@ static void gfx_v9_0_init_sq_config(struct amdgpu_device *adev)
break;
default:
break;
- };
+ }
}
static void gfx_v9_0_constants_init(struct amdgpu_device *adev)
--
2.26.0.106.g9fadedd
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amdgpu: Remove unneeded semicolon
2020-04-24 7:56 [PATCH] drm/amdgpu: Remove " Zheng Bin
@ 2020-04-24 7:51 ` Christian König
2020-04-24 20:16 ` Alex Deucher
0 siblings, 1 reply; 7+ messages in thread
From: Christian König @ 2020-04-24 7:51 UTC (permalink / raw)
To: Zheng Bin, alexander.deucher, airlied, daniel, dri-devel, amd-gfx
Am 24.04.20 um 09:56 schrieb Zheng Bin:
> Fixes coccicheck warning:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2534:2-3: Unneeded semicolon
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> index 09aa5f509bd2..43d84214995c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> @@ -2531,7 +2531,7 @@ static void gfx_v9_0_init_sq_config(struct amdgpu_device *adev)
> break;
> default:
> break;
> - };
> + }
> }
>
> static void gfx_v9_0_constants_init(struct amdgpu_device *adev)
> --
> 2.26.0.106.g9fadedd
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/amdgpu: Remove unneeded semicolon
2020-04-24 7:51 ` Christian König
@ 2020-04-24 20:16 ` Alex Deucher
0 siblings, 0 replies; 7+ messages in thread
From: Alex Deucher @ 2020-04-24 20:16 UTC (permalink / raw)
To: Christian König
Cc: Dave Airlie, amd-gfx list, Zheng Bin,
Maling list - DRI developers, Daniel Vetter, Deucher, Alexander
Applied. Thanks!
Alex
On Fri, Apr 24, 2020 at 3:56 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 24.04.20 um 09:56 schrieb Zheng Bin:
> > Fixes coccicheck warning:
> >
> > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:2534:2-3: Unneeded semicolon
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> > index 09aa5f509bd2..43d84214995c 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
> > @@ -2531,7 +2531,7 @@ static void gfx_v9_0_init_sq_config(struct amdgpu_device *adev)
> > break;
> > default:
> > break;
> > - };
> > + }
> > }
> >
> > static void gfx_v9_0_constants_init(struct amdgpu_device *adev)
> > --
> > 2.26.0.106.g9fadedd
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-05-05 18:52 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-27 19:07 [PATCH] drm/amdgpu: remove unneeded semicolon trix
2020-10-30 3:34 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2023-05-05 7:37 Jiapeng Chong
2023-05-05 18:51 ` Alex Deucher
2020-04-24 7:56 [PATCH] drm/amdgpu: Remove " Zheng Bin
2020-04-24 7:51 ` Christian König
2020-04-24 20:16 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox