Re: [PATCH v3 02/12] drm: Unamp the entire device address space on device unplug

From: Daniel Vetter <daniel@ffwll.ch>
To: christian.koenig@amd.com
Cc: robh@kernel.org, Andrey Grodzovsky <andrey.grodzovsky@amd.com>,
	daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org,
	eric@anholt.net, ppaalanen@gmail.com,
	amd-gfx@lists.freedesktop.org, gregkh@linuxfoundation.org,
	Alexander.Deucher@amd.com, yuq825@gmail.com,
	Harry.Wentland@amd.com, l.stach@pengutronix.de
Subject: Re: [PATCH v3 02/12] drm: Unamp the entire device address space on device unplug
Date: Tue, 24 Nov 2020 15:44:43 +0100	[thread overview]
Message-ID: <20201124144443.GQ401619@phenom.ffwll.local> (raw)
In-Reply-To: <54329aa5-ef57-3209-13b7-abd02683f9fc@gmail.com>

On Sat, Nov 21, 2020 at 03:16:15PM +0100, Christian König wrote:
> Am 21.11.20 um 06:21 schrieb Andrey Grodzovsky:
> > Invalidate all BOs CPU mappings once device is removed.
> > 
> > v3: Move the code from TTM into drm_dev_unplug
> > 
> > Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
> 
> Reviewed-by: Christian König <christian.koenig@amd.com>

Was wondering for a moment whether this should be in drm_dev_unregister
instead, but then it's only one part of the coin really. So

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> 
> > ---
> >   drivers/gpu/drm/drm_drv.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> > index 13068fd..d550fd5 100644
> > --- a/drivers/gpu/drm/drm_drv.c
> > +++ b/drivers/gpu/drm/drm_drv.c
> > @@ -479,6 +479,9 @@ void drm_dev_unplug(struct drm_device *dev)
> >   	synchronize_srcu(&drm_unplug_srcu);
> >   	drm_dev_unregister(dev);
> > +
> > +	/* Clear all CPU mappings pointing to this device */
> > +	unmap_mapping_range(dev->anon_inode->i_mapping, 0, 0, 1);
> >   }
> >   EXPORT_SYMBOL(drm_dev_unplug);
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx