From: Huang Rui <ray.huang@amd.com>
To: "Hou, Xiaomeng (Matthew)" <Xiaomeng.Hou@amd.com>
Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/pm: add pmfw version check before issuing RlcPowerNotify message
Date: Thu, 17 Dec 2020 11:42:09 +0800 [thread overview]
Message-ID: <20201217034209.GA1849373@hr-amd> (raw)
In-Reply-To: <20201217025701.22622-1-Xiaomeng.Hou@amd.com>
On Thu, Dec 17, 2020 at 10:57:01AM +0800, Hou, Xiaomeng (Matthew) wrote:
> Only pmfw version behind v4.63.23.00 could support this message.
>
> Signed-off-by: Xiaomeng Hou <Xiaomeng.Hou@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> index 9bccf2ad038c..8cb4fcee9a2c 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> @@ -724,8 +724,13 @@ static int vangogh_set_fine_grain_gfx_freq_parameters(struct smu_context *smu)
>
> static int vangogh_system_features_control(struct smu_context *smu, bool en)
> {
> - return smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_RlcPowerNotify,
> - en ? RLC_STATUS_NORMAL : RLC_STATUS_OFF, NULL);
> + struct amdgpu_device *adev = smu->adev;
> +
> + if (adev->pm.fw_version >= 0x43f1700)
> + return smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_RlcPowerNotify,
> + en ? RLC_STATUS_NORMAL : RLC_STATUS_OFF, NULL);
> + else
> + return 0;
> }
>
> static const struct pptable_funcs vangogh_ppt_funcs = {
> --
> 2.17.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-12-17 3:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 2:57 [PATCH] drm/amd/pm: add pmfw version check before issuing RlcPowerNotify message Xiaomeng Hou
2020-12-17 3:42 ` Huang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201217034209.GA1849373@hr-amd \
--to=ray.huang@amd.com \
--cc=Xiaomeng.Hou@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox