* [PATCH] drm/amd/pm: add pmfw version check before issuing RlcPowerNotify message
@ 2020-12-17 2:57 Xiaomeng Hou
2020-12-17 3:42 ` Huang Rui
0 siblings, 1 reply; 2+ messages in thread
From: Xiaomeng Hou @ 2020-12-17 2:57 UTC (permalink / raw)
To: amd-gfx, Ray.Huang; +Cc: Xiaomeng Hou
Only pmfw version behind v4.63.23.00 could support this message.
Signed-off-by: Xiaomeng Hou <Xiaomeng.Hou@amd.com>
---
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
index 9bccf2ad038c..8cb4fcee9a2c 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
@@ -724,8 +724,13 @@ static int vangogh_set_fine_grain_gfx_freq_parameters(struct smu_context *smu)
static int vangogh_system_features_control(struct smu_context *smu, bool en)
{
- return smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_RlcPowerNotify,
- en ? RLC_STATUS_NORMAL : RLC_STATUS_OFF, NULL);
+ struct amdgpu_device *adev = smu->adev;
+
+ if (adev->pm.fw_version >= 0x43f1700)
+ return smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_RlcPowerNotify,
+ en ? RLC_STATUS_NORMAL : RLC_STATUS_OFF, NULL);
+ else
+ return 0;
}
static const struct pptable_funcs vangogh_ppt_funcs = {
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/pm: add pmfw version check before issuing RlcPowerNotify message
2020-12-17 2:57 [PATCH] drm/amd/pm: add pmfw version check before issuing RlcPowerNotify message Xiaomeng Hou
@ 2020-12-17 3:42 ` Huang Rui
0 siblings, 0 replies; 2+ messages in thread
From: Huang Rui @ 2020-12-17 3:42 UTC (permalink / raw)
To: Hou, Xiaomeng (Matthew); +Cc: amd-gfx@lists.freedesktop.org
On Thu, Dec 17, 2020 at 10:57:01AM +0800, Hou, Xiaomeng (Matthew) wrote:
> Only pmfw version behind v4.63.23.00 could support this message.
>
> Signed-off-by: Xiaomeng Hou <Xiaomeng.Hou@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> index 9bccf2ad038c..8cb4fcee9a2c 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> @@ -724,8 +724,13 @@ static int vangogh_set_fine_grain_gfx_freq_parameters(struct smu_context *smu)
>
> static int vangogh_system_features_control(struct smu_context *smu, bool en)
> {
> - return smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_RlcPowerNotify,
> - en ? RLC_STATUS_NORMAL : RLC_STATUS_OFF, NULL);
> + struct amdgpu_device *adev = smu->adev;
> +
> + if (adev->pm.fw_version >= 0x43f1700)
> + return smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_RlcPowerNotify,
> + en ? RLC_STATUS_NORMAL : RLC_STATUS_OFF, NULL);
> + else
> + return 0;
> }
>
> static const struct pptable_funcs vangogh_ppt_funcs = {
> --
> 2.17.1
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-17 3:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-17 2:57 [PATCH] drm/amd/pm: add pmfw version check before issuing RlcPowerNotify message Xiaomeng Hou
2020-12-17 3:42 ` Huang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox