* [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds @ 2021-01-05 7:50 Victor Zhao 2021-01-07 6:25 ` Deng, Emily 0 siblings, 1 reply; 3+ messages in thread From: Victor Zhao @ 2021-01-05 7:50 UTC (permalink / raw) To: amd-gfx; +Cc: Victor Zhao psp GFX_CTRL_CMD_ID_CONSUME_CMD different for windows and linux, according to psp, linux cmds are not correct. v2: only correct GFX_CTRL_CMD_ID_CONSUME_CMD. Signed-off-by: Victor Zhao <Victor.Zhao@amd.com> --- drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h b/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h index d65a5339d354..3ba7bdfde65d 100644 --- a/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h +++ b/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h @@ -47,7 +47,7 @@ enum psp_gfx_crtl_cmd_id GFX_CTRL_CMD_ID_DISABLE_INT = 0x00060000, /* disable PSP-to-Gfx interrupt */ GFX_CTRL_CMD_ID_MODE1_RST = 0x00070000, /* trigger the Mode 1 reset */ GFX_CTRL_CMD_ID_GBR_IH_SET = 0x00080000, /* set Gbr IH_RB_CNTL registers */ - GFX_CTRL_CMD_ID_CONSUME_CMD = 0x000A0000, /* send interrupt to psp for updating write pointer of vf */ + GFX_CTRL_CMD_ID_CONSUME_CMD = 0x00090000, /* send interrupt to psp for updating write pointer of vf */ GFX_CTRL_CMD_ID_DESTROY_GPCOM_RING = 0x000C0000, /* destroy GPCOM ring */ GFX_CTRL_CMD_ID_MAX = 0x000F0000, /* max command ID */ -- 2.25.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds 2021-01-05 7:50 [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds Victor Zhao @ 2021-01-07 6:25 ` Deng, Emily 2021-01-07 6:38 ` Deng, Emily 0 siblings, 1 reply; 3+ messages in thread From: Deng, Emily @ 2021-01-07 6:25 UTC (permalink / raw) To: Zhao, Victor, amd-gfx@lists.freedesktop.org; +Cc: Zhao, Victor [AMD Official Use Only - Internal Distribution Only] Reviewed-by: Evan Quan <evan.quan@amd.com> >-----Original Message----- >From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Victor >Zhao >Sent: Tuesday, January 5, 2021 3:51 PM >To: amd-gfx@lists.freedesktop.org >Cc: Zhao, Victor <Victor.Zhao@amd.com> >Subject: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds > >psp GFX_CTRL_CMD_ID_CONSUME_CMD different for windows and linux, >according to psp, linux cmds are not correct. > >v2: only correct GFX_CTRL_CMD_ID_CONSUME_CMD. > >Signed-off-by: Victor Zhao <Victor.Zhao@amd.com> >--- > drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h >b/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h >index d65a5339d354..3ba7bdfde65d 100644 >--- a/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h >+++ b/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h >@@ -47,7 +47,7 @@ enum psp_gfx_crtl_cmd_id > GFX_CTRL_CMD_ID_DISABLE_INT = 0x00060000, /* disable PSP-to-Gfx >interrupt */ > GFX_CTRL_CMD_ID_MODE1_RST = 0x00070000, /* trigger the Mode 1 >reset */ > GFX_CTRL_CMD_ID_GBR_IH_SET = 0x00080000, /* set Gbr >IH_RB_CNTL registers */ >- GFX_CTRL_CMD_ID_CONSUME_CMD = 0x000A0000, /* send interrupt >to psp for updating write pointer of vf */ >+ GFX_CTRL_CMD_ID_CONSUME_CMD = 0x00090000, /* send interrupt >to psp for updating write pointer of vf */ > GFX_CTRL_CMD_ID_DESTROY_GPCOM_RING = 0x000C0000, /* destroy >GPCOM ring */ > > GFX_CTRL_CMD_ID_MAX = 0x000F0000, /* max command ID */ >-- >2.25.1 > >_______________________________________________ >amd-gfx mailing list >amd-gfx@lists.freedesktop.org >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.f >reedesktop.org%2Fmailman%2Flistinfo%2Famd- >gfx&data=04%7C01%7CEmily.Deng%40amd.com%7Cb32008e7e8e1447 >797ab08d8b14eb089%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0% >7C637454298972763193%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA >wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000&s >data=2HlggVF4%2B20Ceom5OBfyr0MXYdiLMblwgUbl%2FVEeqII%3D&re >served=0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds 2021-01-07 6:25 ` Deng, Emily @ 2021-01-07 6:38 ` Deng, Emily 0 siblings, 0 replies; 3+ messages in thread From: Deng, Emily @ 2021-01-07 6:38 UTC (permalink / raw) To: Deng, Emily, Zhao, Victor, amd-gfx@lists.freedesktop.org; +Cc: Zhao, Victor [AMD Official Use Only - Internal Distribution Only] Sorry, reply the wrong message. Reviewed-by: Emily.Deng <Emily.Deng@amd.com> >-----Original Message----- >From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Deng, >Emily >Sent: Thursday, January 7, 2021 2:26 PM >To: Zhao, Victor <Victor.Zhao@amd.com>; amd-gfx@lists.freedesktop.org >Cc: Zhao, Victor <Victor.Zhao@amd.com> >Subject: RE: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds > >[AMD Official Use Only - Internal Distribution Only] > >[AMD Official Use Only - Internal Distribution Only] > >Reviewed-by: Evan Quan <evan.quan@amd.com> > >>-----Original Message----- >>From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of >>Victor Zhao >>Sent: Tuesday, January 5, 2021 3:51 PM >>To: amd-gfx@lists.freedesktop.org >>Cc: Zhao, Victor <Victor.Zhao@amd.com> >>Subject: [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds >> >>psp GFX_CTRL_CMD_ID_CONSUME_CMD different for windows and linux, >>according to psp, linux cmds are not correct. >> >>v2: only correct GFX_CTRL_CMD_ID_CONSUME_CMD. >> >>Signed-off-by: Victor Zhao <Victor.Zhao@amd.com> >>--- >> drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h >>b/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h >>index d65a5339d354..3ba7bdfde65d 100644 >>--- a/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h >>+++ b/drivers/gpu/drm/amd/amdgpu/psp_gfx_if.h >>@@ -47,7 +47,7 @@ enum psp_gfx_crtl_cmd_id >> GFX_CTRL_CMD_ID_DISABLE_INT = 0x00060000, /* disable PSP-to-Gfx >>interrupt */ >> GFX_CTRL_CMD_ID_MODE1_RST = 0x00070000, /* trigger the Mode >1 >>reset */ >> GFX_CTRL_CMD_ID_GBR_IH_SET = 0x00080000, /* set Gbr >>IH_RB_CNTL registers */ >>- GFX_CTRL_CMD_ID_CONSUME_CMD = 0x000A0000, /* send interrupt >>to psp for updating write pointer of vf */ >>+ GFX_CTRL_CMD_ID_CONSUME_CMD = 0x00090000, /* send interrupt >>to psp for updating write pointer of vf */ >> GFX_CTRL_CMD_ID_DESTROY_GPCOM_RING = 0x000C0000, /* destroy >GPCOM >>ring */ >> >> GFX_CTRL_CMD_ID_MAX = 0x000F0000, /* max command ID */ >>-- >>2.25.1 >> >>_______________________________________________ >>amd-gfx mailing list >>amd-gfx@lists.freedesktop.org >>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists >>.f >>reedesktop.org%2Fmailman%2Flistinfo%2Famd- >>gfx&data=04%7C01%7CEmily.Deng%40amd.com%7Cb32008e7e8e144 >7 >>797ab08d8b14eb089%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0% >>7C637454298972763193%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA >>wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C2000& >s >>data=2HlggVF4%2B20Ceom5OBfyr0MXYdiLMblwgUbl%2FVEeqII%3D&r >e >>served=0 >_______________________________________________ >amd-gfx mailing list >amd-gfx@lists.freedesktop.org >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.f >reedesktop.org%2Fmailman%2Flistinfo%2Famd- >gfx&data=04%7C01%7CEmily.Deng%40amd.com%7Cdbe3378304364ec2 >161208d8b2d51127%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7 >C637455975520611398%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw >MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sda >ta=lmtZ%2BZjKZEq73CsfCX%2FxEcM7rzWB7%2FuKDzuJ7j3Nx8k%3D&res >erved=0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-07 6:38 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-01-05 7:50 [PATCH v2] drm/amdgpu/psp: fix psp gfx ctrl cmds Victor Zhao 2021-01-07 6:25 ` Deng, Emily 2021-01-07 6:38 ` Deng, Emily
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox