AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amdgpu: Remove GFXOFF MASK for Vangogh
@ 2021-01-18 10:17 Jinzhou Su
  2021-01-19  3:38 ` Huang Rui
  0 siblings, 1 reply; 2+ messages in thread
From: Jinzhou Su @ 2021-01-18 10:17 UTC (permalink / raw)
  To: amd-gfx; +Cc: Jinzhou Su, ray.huang

 1. Remove PP_GFXOFF_MASK and then GFXOFF can be enabled
    by user space.
 2. GFXOFF is still disabled on Vangogh by default.
 3. When GFXOFF feature on Vangogh landed, will enable
    GFXOFF by default.
 4. GFXOFF can be enabled by debugfs interface amdgpu_gfxoff.

Signed-off-by: Jinzhou Su <Jinzhou.Su@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 4d3b30a2dd45..92b1cbdebae9 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -3775,9 +3775,6 @@ static void gfx_v10_0_check_gfxoff_flag(struct amdgpu_device *adev)
 		if (!gfx_v10_0_navi10_gfxoff_should_enable(adev))
 			adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
 		break;
-	case CHIP_VANGOGH:
-		adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
-		break;
 	default:
 		break;
 	}
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/amdgpu: Remove GFXOFF MASK for Vangogh
  2021-01-18 10:17 [PATCH] drm/amdgpu: Remove GFXOFF MASK for Vangogh Jinzhou Su
@ 2021-01-19  3:38 ` Huang Rui
  0 siblings, 0 replies; 2+ messages in thread
From: Huang Rui @ 2021-01-19  3:38 UTC (permalink / raw)
  To: Su, Jinzhou (Joe); +Cc: amd-gfx@lists.freedesktop.org

On Mon, Jan 18, 2021 at 06:17:51PM +0800, Su, Jinzhou (Joe) wrote:
>  1. Remove PP_GFXOFF_MASK and then GFXOFF can be enabled
>     by user space.
>  2. GFXOFF is still disabled on Vangogh by default.
>  3. When GFXOFF feature on Vangogh landed, will enable
>     GFXOFF by default.
>  4. GFXOFF can be enabled by debugfs interface amdgpu_gfxoff.
> 
> Signed-off-by: Jinzhou Su <Jinzhou.Su@amd.com>

Acked-by: Huang Rui <ray.huang@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> index 4d3b30a2dd45..92b1cbdebae9 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
> @@ -3775,9 +3775,6 @@ static void gfx_v10_0_check_gfxoff_flag(struct amdgpu_device *adev)
>  		if (!gfx_v10_0_navi10_gfxoff_should_enable(adev))
>  			adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
>  		break;
> -	case CHIP_VANGOGH:
> -		adev->pm.pp_feature &= ~PP_GFXOFF_MASK;
> -		break;
>  	default:
>  		break;
>  	}
> -- 
> 2.17.1
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-19  3:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-18 10:17 [PATCH] drm/amdgpu: Remove GFXOFF MASK for Vangogh Jinzhou Su
2021-01-19  3:38 ` Huang Rui

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox