[PATCH 1/2] drm/amd/display: fix comment format

[PATCH 1/2] drm/amd/display: fix comment format

[Alex Deucher]

This is not a compliant kerneldoc comment, so make it just
a regular comment.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
index c4a5f8198209..436c3545a983 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
@@ -42,7 +42,7 @@
 #define FN(reg_name, field_name) \
 	optc1->tg_shift->field_name, optc1->tg_mask->field_name
 
-/**
+/*
  * Enable CRTC
  * Enable CRTC - call ASIC Control Object to enable Timing generator.
  */
-- 
2.35.3

[PATCH 2/2] drm/amd/display: make to_dal_irq_source_dcn314 static

[Alex Deucher]

It's not used outside of irq_service_dcn314.c.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c b/drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c
index bea6f157cbb7..c923b2af8510 100644
--- a/drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c
+++ b/drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c
@@ -38,7 +38,7 @@
 
 #define DCN_BASE__INST0_SEG2                       0x000034C0
 
-enum dc_irq_source to_dal_irq_source_dcn314(
+static enum dc_irq_source to_dal_irq_source_dcn314(
 		struct irq_service *irq_service,
 		uint32_t src_id,
 		uint32_t ext_id)
-- 
2.35.3

Re: [PATCH 2/2] drm/amd/display: make to_dal_irq_source_dcn314 static

[Harry Wentland]

On 2022-07-12 10:31, Alex Deucher wrote:
> It's not used outside of irq_service_dcn314.c.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c b/drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c
> index bea6f157cbb7..c923b2af8510 100644
> --- a/drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c
> +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn314/irq_service_dcn314.c
> @@ -38,7 +38,7 @@
>  
>  #define DCN_BASE__INST0_SEG2                       0x000034C0
>  
> -enum dc_irq_source to_dal_irq_source_dcn314(
> +static enum dc_irq_source to_dal_irq_source_dcn314(
>  		struct irq_service *irq_service,
>  		uint32_t src_id,
>  		uint32_t ext_id)

Re: [PATCH 1/2] drm/amd/display: fix comment format

[André Almeida]

Hi Alex,

Às 11:31 de 12/07/22, Alex Deucher escreveu:
> This is not a compliant kerneldoc comment, so make it just
> a regular comment.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> index c4a5f8198209..436c3545a983 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> @@ -42,7 +42,7 @@
>  #define FN(reg_name, field_name) \
>  	optc1->tg_shift->field_name, optc1->tg_mask->field_name
>  
> -/**
> +/*
>   * Enable CRTC
>   * Enable CRTC - call ASIC Control Object to enable Timing generator.
>   */

This comment is placed in a random part of the file, the proper fix it
would be to place it above the function that it's describing:

static bool optc314_enable_crtc(struct timing_generator *optc)

There it could even be a correct kerneldoc comment, fixed the function
name and adding the argument description.

Re: [PATCH 1/2] drm/amd/display: fix comment format

[Christian König]

Am 12.07.22 um 16:31 schrieb Alex Deucher:
> This is not a compliant kerneldoc comment, so make it just
> a regular comment.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com> for this series.

> ---
>   drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> index c4a5f8198209..436c3545a983 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_optc.c
> @@ -42,7 +42,7 @@
>   #define FN(reg_name, field_name) \
>   	optc1->tg_shift->field_name, optc1->tg_mask->field_name
>   
> -/**
> +/*
>    * Enable CRTC
>    * Enable CRTC - call ASIC Control Object to enable Timing generator.
>    */