From: Mario Limonciello <mario.limonciello@amd.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>,
Alexander Deucher <Alexander.Deucher@amd.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: linux-acpi@vger.kernel.org,
Mario Limonciello <mario.limonciello@amd.com>,
amd-gfx@lists.freedesktop.org, Daniel Dadap <ddadap@nvidia.com>
Subject: [PATCH v2 1/3] ACPI: video: Allow GPU drivers to report no panels
Date: Wed, 7 Dec 2022 19:09:08 -0600 [thread overview]
Message-ID: <20221208010910.7621-2-mario.limonciello@amd.com> (raw)
In-Reply-To: <20221208010910.7621-1-mario.limonciello@amd.com>
The current logic for the ACPI backlight detection will create
a backlight device if no native or vendor drivers have created
8 seconds after the system has booted if the ACPI tables
included backlight control methods.
If the GPU drivers have loaded, they may be able to report whether
any LCD panels were found. Allow using this information to factor
in whether to enable the fallback logic for making an acpi_video0
backlight device.
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v1->v2:
* Cancel registration for backlight device instead (Hans)
* drop desktop check (Dan)
drivers/acpi/acpi_video.c | 11 +++++++++++
include/acpi/video.h | 1 +
2 files changed, 12 insertions(+)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 32953646caeb..f64fdb029090 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -2178,6 +2178,17 @@ static bool should_check_lcd_flag(void)
return false;
}
+/*
+ * At least one graphics driver has reported that no LCD is connected
+ * via the native interface. cancel the registration for fallback acpi_video0.
+ * If another driver still deems this necessary, it can explicitly register it.
+ */
+void acpi_video_report_nolcd(void)
+{
+ cancel_delayed_work(&video_bus_register_backlight_work);
+}
+EXPORT_SYMBOL(acpi_video_report_nolcd);
+
int acpi_video_register(void)
{
int ret = 0;
diff --git a/include/acpi/video.h b/include/acpi/video.h
index a275c35e5249..1fccb111c197 100644
--- a/include/acpi/video.h
+++ b/include/acpi/video.h
@@ -53,6 +53,7 @@ enum acpi_backlight_type {
};
#if IS_ENABLED(CONFIG_ACPI_VIDEO)
+extern void acpi_video_report_nolcd(void);
extern int acpi_video_register(void);
extern void acpi_video_unregister(void);
extern void acpi_video_register_backlight(void);
--
2.34.1
next prev parent reply other threads:[~2022-12-08 1:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 1:09 [PATCH v2 0/3] Adjust ACPI video detection fallback path Mario Limonciello
2022-12-08 1:09 ` Mario Limonciello [this message]
2022-12-08 11:32 ` [PATCH v2 1/3] ACPI: video: Allow GPU drivers to report no panels Rafael J. Wysocki
2022-12-08 1:09 ` [PATCH v2 2/3] drm/amd/display: Report to ACPI video if no panels were found Mario Limonciello
2022-12-08 11:13 ` kernel test robot
2022-12-08 13:34 ` kernel test robot
2022-12-08 1:09 ` [PATCH v2 3/3] ACPI: video: Don't enable fallback path for creating ACPI backlight by default Mario Limonciello
2022-12-08 9:43 ` [PATCH v2 0/3] Adjust ACPI video detection fallback path Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208010910.7621-2-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ddadap@nvidia.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox