From: Mario Limonciello <mario.limonciello@amd.com>
To: "Rafael J . Wysocki" <rafael@kernel.org>,
Alexander Deucher <Alexander.Deucher@amd.com>,
Hans de Goede <hdegoede@redhat.com>
Cc: linux-acpi@vger.kernel.org,
Mario Limonciello <mario.limonciello@amd.com>,
amd-gfx@lists.freedesktop.org, Daniel Dadap <ddadap@nvidia.com>
Subject: [PATCH v2 3/3] ACPI: video: Don't enable fallback path for creating ACPI backlight by default
Date: Wed, 7 Dec 2022 19:09:10 -0600 [thread overview]
Message-ID: <20221208010910.7621-4-mario.limonciello@amd.com> (raw)
In-Reply-To: <20221208010910.7621-1-mario.limonciello@amd.com>
The ACPI video detection code has a module parameter
`register_backlight_delay` which is currently configured to 8 seconds.
This means that if after 8 seconds of booting no native driver has created
a backlight device then the code will attempt to make an ACPI video
backlight device.
This was intended as a safety mechanism with the backlight overhaul that
occurred in kernel 6.1, but as it doesn't appear necesssary set it to be
disabled by default.
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v1->v2:
* New patch
drivers/acpi/acpi_video.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index f64fdb029090..0c79f463fbfd 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -70,11 +70,7 @@ module_param(device_id_scheme, bool, 0444);
static int only_lcd = -1;
module_param(only_lcd, int, 0444);
-/*
- * Display probing is known to take up to 5 seconds, so delay the fallback
- * backlight registration by 5 seconds + 3 seconds for some extra margin.
- */
-static int register_backlight_delay = 8;
+static int register_backlight_delay;
module_param(register_backlight_delay, int, 0444);
MODULE_PARM_DESC(register_backlight_delay,
"Delay in seconds before doing fallback (non GPU driver triggered) "
--
2.34.1
next prev parent reply other threads:[~2022-12-08 1:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 1:09 [PATCH v2 0/3] Adjust ACPI video detection fallback path Mario Limonciello
2022-12-08 1:09 ` [PATCH v2 1/3] ACPI: video: Allow GPU drivers to report no panels Mario Limonciello
2022-12-08 11:32 ` Rafael J. Wysocki
2022-12-08 1:09 ` [PATCH v2 2/3] drm/amd/display: Report to ACPI video if no panels were found Mario Limonciello
2022-12-08 11:13 ` kernel test robot
2022-12-08 13:34 ` kernel test robot
2022-12-08 1:09 ` Mario Limonciello [this message]
2022-12-08 9:43 ` [PATCH v2 0/3] Adjust ACPI video detection fallback path Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221208010910.7621-4-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ddadap@nvidia.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox