* [PATCH] drm/display: Include missing DPCD definitions from DP2.0 spec
@ 2022-12-08 19:25 Sung Joon Kim
2022-12-08 19:29 ` Alex Deucher
2022-12-09 21:49 ` Harry Wentland
0 siblings, 2 replies; 3+ messages in thread
From: Sung Joon Kim @ 2022-12-08 19:25 UTC (permalink / raw)
To: harry.wentland, rodrigo.siqueira, alexander.deucher
Cc: Sung Joon Kim, amd-gfx, nikola.cornij
The missing DPCD defintions from DP2.0 spec is as follows:
DOWNSPREAD_CTRL (107h):
ADAPTIVE_SYNC_SDP_EN (bit 6)
For sink devices that support Adaptive-Sync operation
and Panel Replay
DPRX_FEATURE_ENUMERATION_LIST_CONT_1 (2214h):
ADAPTIVE_SYNC_SDP_SUPPORTED (bit 0)
Bit to check sink device has Adaptive-Sync capability
AS_SDP_FIRST_HALF_LINE_OR_3840_PIXEL_CYCLE_WINDOW_NOT_SUPPORTED (bit 1)
A sink device that clears this bit will generate VSync pulse
leading edge of the HDMI output on the line count at which
Adaptive-Sync SDP is received as long as source device transmits
Adaptive-Sync SDP either in first line or first 3840 pixel cycles
of the line whichever occurs first.
VSC_EXT_SDP_FRAMEWORK_VERSION_1_SUPPORTED (bit 4)
Bit to check sink device has SDP framework version 1 capability
---
include/drm/display/drm_dp.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
index 4d0abe4c7ea9..4f33b6aeb91e 100644
--- a/include/drm/display/drm_dp.h
+++ b/include/drm/display/drm_dp.h
@@ -603,6 +603,7 @@
#define DP_DOWNSPREAD_CTRL 0x107
# define DP_SPREAD_AMP_0_5 (1 << 4)
+# define DP_ADAPTIVE_SYNC_SDP_EN (1 << 6)
# define DP_MSA_TIMING_PAR_IGNORE_EN (1 << 7) /* eDP */
#define DP_MAIN_LINK_CHANNEL_CODING_SET 0x108
@@ -1105,6 +1106,11 @@
# define DP_VSC_EXT_CEA_SDP_SUPPORTED (1 << 6) /* DP 1.4 */
# define DP_VSC_EXT_CEA_SDP_CHAINING_SUPPORTED (1 << 7) /* DP 1.4 */
+#define DP_DPRX_FEATURE_ENUMERATION_LIST_CONT_1 0x2214 /* 2.0 E11 */
+# define DP_ADAPTIVE_SYNC_SDP_SUPPORTED (1 << 0)
+# define DP_AS_SDP_FIRST_HALF_LINE_OR_3840_PIXEL_CYCLE_WINDOW_NOT_SUPPORTED (1 << 1)
+# define DP_VSC_EXT_SDP_FRAMEWORK_VERSION_1_SUPPORTED (1 << 4)
+
#define DP_128B132B_SUPPORTED_LINK_RATES 0x2215 /* 2.0 */
# define DP_UHBR10 (1 << 0)
# define DP_UHBR20 (1 << 1)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/display: Include missing DPCD definitions from DP2.0 spec
2022-12-08 19:25 [PATCH] drm/display: Include missing DPCD definitions from DP2.0 spec Sung Joon Kim
@ 2022-12-08 19:29 ` Alex Deucher
2022-12-09 21:49 ` Harry Wentland
1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2022-12-08 19:29 UTC (permalink / raw)
To: Sung Joon Kim, Maling list - DRI developers
Cc: alexander.deucher, rodrigo.siqueira, harry.wentland, amd-gfx,
nikola.cornij
+ dri-devel
On Thu, Dec 8, 2022 at 2:25 PM Sung Joon Kim <Sungjoon.Kim@amd.com> wrote:
>
> The missing DPCD defintions from DP2.0 spec is as follows:
>
> DOWNSPREAD_CTRL (107h):
> ADAPTIVE_SYNC_SDP_EN (bit 6)
> For sink devices that support Adaptive-Sync operation
> and Panel Replay
>
> DPRX_FEATURE_ENUMERATION_LIST_CONT_1 (2214h):
> ADAPTIVE_SYNC_SDP_SUPPORTED (bit 0)
> Bit to check sink device has Adaptive-Sync capability
> AS_SDP_FIRST_HALF_LINE_OR_3840_PIXEL_CYCLE_WINDOW_NOT_SUPPORTED (bit 1)
> A sink device that clears this bit will generate VSync pulse
> leading edge of the HDMI output on the line count at which
> Adaptive-Sync SDP is received as long as source device transmits
> Adaptive-Sync SDP either in first line or first 3840 pixel cycles
> of the line whichever occurs first.
> VSC_EXT_SDP_FRAMEWORK_VERSION_1_SUPPORTED (bit 4)
> Bit to check sink device has SDP framework version 1 capability
> ---
> include/drm/display/drm_dp.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
> index 4d0abe4c7ea9..4f33b6aeb91e 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -603,6 +603,7 @@
>
> #define DP_DOWNSPREAD_CTRL 0x107
> # define DP_SPREAD_AMP_0_5 (1 << 4)
> +# define DP_ADAPTIVE_SYNC_SDP_EN (1 << 6)
> # define DP_MSA_TIMING_PAR_IGNORE_EN (1 << 7) /* eDP */
>
> #define DP_MAIN_LINK_CHANNEL_CODING_SET 0x108
> @@ -1105,6 +1106,11 @@
> # define DP_VSC_EXT_CEA_SDP_SUPPORTED (1 << 6) /* DP 1.4 */
> # define DP_VSC_EXT_CEA_SDP_CHAINING_SUPPORTED (1 << 7) /* DP 1.4 */
>
> +#define DP_DPRX_FEATURE_ENUMERATION_LIST_CONT_1 0x2214 /* 2.0 E11 */
> +# define DP_ADAPTIVE_SYNC_SDP_SUPPORTED (1 << 0)
> +# define DP_AS_SDP_FIRST_HALF_LINE_OR_3840_PIXEL_CYCLE_WINDOW_NOT_SUPPORTED (1 << 1)
> +# define DP_VSC_EXT_SDP_FRAMEWORK_VERSION_1_SUPPORTED (1 << 4)
> +
> #define DP_128B132B_SUPPORTED_LINK_RATES 0x2215 /* 2.0 */
> # define DP_UHBR10 (1 << 0)
> # define DP_UHBR20 (1 << 1)
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/display: Include missing DPCD definitions from DP2.0 spec
2022-12-08 19:25 [PATCH] drm/display: Include missing DPCD definitions from DP2.0 spec Sung Joon Kim
2022-12-08 19:29 ` Alex Deucher
@ 2022-12-09 21:49 ` Harry Wentland
1 sibling, 0 replies; 3+ messages in thread
From: Harry Wentland @ 2022-12-09 21:49 UTC (permalink / raw)
To: Sung Joon Kim, rodrigo.siqueira, alexander.deucher
Cc: dri-devel, amd-gfx, nikola.cornij
The commit subject is very generic. A better one might be
"Add missing Adaptive Sync DPCD definitions"
On 12/8/22 14:25, Sung Joon Kim wrote:
> The missing DPCD defintions from DP2.0 spec is as follows:
>
> DOWNSPREAD_CTRL (107h):
> ADAPTIVE_SYNC_SDP_EN (bit 6)
> For sink devices that support Adaptive-Sync operation
> and Panel Replay
>
> DPRX_FEATURE_ENUMERATION_LIST_CONT_1 (2214h):
> ADAPTIVE_SYNC_SDP_SUPPORTED (bit 0)
> Bit to check sink device has Adaptive-Sync capability
> AS_SDP_FIRST_HALF_LINE_OR_3840_PIXEL_CYCLE_WINDOW_NOT_SUPPORTED (bit 1)
> A sink device that clears this bit will generate VSync pulse
> leading edge of the HDMI output on the line count at which
> Adaptive-Sync SDP is received as long as source device transmits
> Adaptive-Sync SDP either in first line or first 3840 pixel cycles
> of the line whichever occurs first.
> VSC_EXT_SDP_FRAMEWORK_VERSION_1_SUPPORTED (bit 4)
> Bit to check sink device has SDP framework version 1 capability
> ---
> include/drm/display/drm_dp.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h
> index 4d0abe4c7ea9..4f33b6aeb91e 100644
> --- a/include/drm/display/drm_dp.h
> +++ b/include/drm/display/drm_dp.h
> @@ -603,6 +603,7 @@
>
> #define DP_DOWNSPREAD_CTRL 0x107
> # define DP_SPREAD_AMP_0_5 (1 << 4)
> +# define DP_ADAPTIVE_SYNC_SDP_EN (1 << 6)
We tend to stick with the naming from the spec to allow
people to find things more easily. Please change this to:
DP_FIXED_VTOTAL_AS_SDP_EN_IN_PR_ACTIVE
Harry
> # define DP_MSA_TIMING_PAR_IGNORE_EN (1 << 7) /* eDP */
>
> #define DP_MAIN_LINK_CHANNEL_CODING_SET 0x108
> @@ -1105,6 +1106,11 @@
> # define DP_VSC_EXT_CEA_SDP_SUPPORTED (1 << 6) /* DP 1.4 */
> # define DP_VSC_EXT_CEA_SDP_CHAINING_SUPPORTED (1 << 7) /* DP 1.4 */
>
> +#define DP_DPRX_FEATURE_ENUMERATION_LIST_CONT_1 0x2214 /* 2.0 E11 */
> +# define DP_ADAPTIVE_SYNC_SDP_SUPPORTED (1 << 0)
> +# define DP_AS_SDP_FIRST_HALF_LINE_OR_3840_PIXEL_CYCLE_WINDOW_NOT_SUPPORTED (1 << 1)
> +# define DP_VSC_EXT_SDP_FRAMEWORK_VERSION_1_SUPPORTED (1 << 4)
> +
> #define DP_128B132B_SUPPORTED_LINK_RATES 0x2215 /* 2.0 */
> # define DP_UHBR10 (1 << 0)
> # define DP_UHBR20 (1 << 1)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-09 21:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-08 19:25 [PATCH] drm/display: Include missing DPCD definitions from DP2.0 spec Sung Joon Kim
2022-12-08 19:29 ` Alex Deucher
2022-12-09 21:49 ` Harry Wentland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox