* [PATCH] drm/amd/display: remove unused variables res_create_maximus_funcs and debug_defaults_diags
@ 2023-05-23 11:49 Tom Rix
2023-05-23 14:36 ` Hamza Mahfooz
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-05-23 11:49 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, qingqing.zhuo,
wenjing.liu, aurabindo.pillai, Samson.Tam, gpiccoli
Cc: Tom Rix, dri-devel, amd-gfx, linux-kernel
gcc with W=1 reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1069:43: error:
‘res_create_maximus_funcs’ defined but not used [-Werror=unused-const-variable=]
1069 | static const struct resource_create_funcs res_create_maximus_funcs = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:727:38: error:
‘debug_defaults_diags’ defined but not used [-Werror=unused-const-variable=]
727 | static const struct dc_debug_options debug_defaults_diags = {
| ^~~~~~~~~~~~~~~~~~~~
These variables are not used so remove them.
Signed-off-by: Tom Rix <trix@redhat.com>
---
.../drm/amd/display/dc/dcn20/dcn20_resource.c | 23 -------------------
1 file changed, 23 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
index 7dcae3183e07..6ef7e2634991 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
@@ -724,22 +724,6 @@ static const struct dc_debug_options debug_defaults_drv = {
.underflow_assert_delay_us = 0xFFFFFFFF,
};
-static const struct dc_debug_options debug_defaults_diags = {
- .disable_dmcu = false,
- .force_abm_enable = false,
- .timing_trace = true,
- .clock_trace = true,
- .disable_dpp_power_gate = true,
- .disable_hubp_power_gate = true,
- .disable_clock_gate = true,
- .disable_pplib_clock_request = true,
- .disable_pplib_wm_range = true,
- .disable_stutter = true,
- .scl_reset_length10 = true,
- .underflow_assert_delay_us = 0xFFFFFFFF,
- .enable_tri_buf = true,
-};
-
void dcn20_dpp_destroy(struct dpp **dpp)
{
kfree(TO_DCN20_DPP(*dpp));
@@ -1066,13 +1050,6 @@ static const struct resource_create_funcs res_create_funcs = {
.create_hwseq = dcn20_hwseq_create,
};
-static const struct resource_create_funcs res_create_maximus_funcs = {
- .read_dce_straps = NULL,
- .create_audio = NULL,
- .create_stream_encoder = NULL,
- .create_hwseq = dcn20_hwseq_create,
-};
-
static void dcn20_pp_smu_destroy(struct pp_smu_funcs **pp_smu);
void dcn20_clock_source_destroy(struct clock_source **clk_src)
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: remove unused variables res_create_maximus_funcs and debug_defaults_diags
2023-05-23 11:49 [PATCH] drm/amd/display: remove unused variables res_create_maximus_funcs and debug_defaults_diags Tom Rix
@ 2023-05-23 14:36 ` Hamza Mahfooz
0 siblings, 0 replies; 2+ messages in thread
From: Hamza Mahfooz @ 2023-05-23 14:36 UTC (permalink / raw)
To: Tom Rix, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
qingqing.zhuo, wenjing.liu, aurabindo.pillai, Samson.Tam,
gpiccoli
Cc: amd-gfx, dri-devel, linux-kernel
On 5/23/23 07:49, Tom Rix wrote:
> gcc with W=1 reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1069:43: error:
> ‘res_create_maximus_funcs’ defined but not used [-Werror=unused-const-variable=]
> 1069 | static const struct resource_create_funcs res_create_maximus_funcs = {
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:727:38: error:
> ‘debug_defaults_diags’ defined but not used [-Werror=unused-const-variable=]
> 727 | static const struct dc_debug_options debug_defaults_diags = {
> | ^~~~~~~~~~~~~~~~~~~~
>
> These variables are not used so remove them.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Fixes: 00df97e1df57 ("drm/amd/display: Clean FPGA code in dc")
Applied, thanks!
> ---
> .../drm/amd/display/dc/dcn20/dcn20_resource.c | 23 -------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> index 7dcae3183e07..6ef7e2634991 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> @@ -724,22 +724,6 @@ static const struct dc_debug_options debug_defaults_drv = {
> .underflow_assert_delay_us = 0xFFFFFFFF,
> };
>
> -static const struct dc_debug_options debug_defaults_diags = {
> - .disable_dmcu = false,
> - .force_abm_enable = false,
> - .timing_trace = true,
> - .clock_trace = true,
> - .disable_dpp_power_gate = true,
> - .disable_hubp_power_gate = true,
> - .disable_clock_gate = true,
> - .disable_pplib_clock_request = true,
> - .disable_pplib_wm_range = true,
> - .disable_stutter = true,
> - .scl_reset_length10 = true,
> - .underflow_assert_delay_us = 0xFFFFFFFF,
> - .enable_tri_buf = true,
> -};
> -
> void dcn20_dpp_destroy(struct dpp **dpp)
> {
> kfree(TO_DCN20_DPP(*dpp));
> @@ -1066,13 +1050,6 @@ static const struct resource_create_funcs res_create_funcs = {
> .create_hwseq = dcn20_hwseq_create,
> };
>
> -static const struct resource_create_funcs res_create_maximus_funcs = {
> - .read_dce_straps = NULL,
> - .create_audio = NULL,
> - .create_stream_encoder = NULL,
> - .create_hwseq = dcn20_hwseq_create,
> -};
> -
> static void dcn20_pp_smu_destroy(struct pp_smu_funcs **pp_smu);
>
> void dcn20_clock_source_destroy(struct clock_source **clk_src)
--
Hamza
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-23 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-23 11:49 [PATCH] drm/amd/display: remove unused variables res_create_maximus_funcs and debug_defaults_diags Tom Rix
2023-05-23 14:36 ` Hamza Mahfooz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox