AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drm/amd/display: enable more strict compile checks
@ 2023-05-24 19:19 Hamza Mahfooz
  2023-05-24 19:22 ` Alex Deucher
                   ` (2 more replies)
  0 siblings, 3 replies; 16+ messages in thread
From: Hamza Mahfooz @ 2023-05-24 19:19 UTC (permalink / raw)
  To: amd-gfx
  Cc: Leo Li, Kenny Ho, Pan, Xinhui, Rodrigo Siqueira, linux-kernel,
	dri-devel, Hamza Mahfooz, Daniel Vetter, Alex Deucher,
	David Airlie, Harry Wentland, Christian König

Currently, there are quite a number of issues that are quite easy for
the CI to catch, that slip through the cracks. Among them, there are
unused variable and indentation issues. Also, we should consider all
warnings to be compile errors, since the community will eventually end
up complaining about them. So, enable -Werror, -Wunused and
-Wmisleading-indentation for all kernel builds.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Kenny Ho <kenny.ho@amd.com>
Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
---
v2: fix grammatical error
---
 drivers/gpu/drm/amd/display/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/amd/display/Makefile b/drivers/gpu/drm/amd/display/Makefile
index 0d610cb376bb..3c44162ebe21 100644
--- a/drivers/gpu/drm/amd/display/Makefile
+++ b/drivers/gpu/drm/amd/display/Makefile
@@ -26,6 +26,8 @@
 
 AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH)
 
+subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation
+
 subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/
 subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw
 subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr
-- 
2.40.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2023-05-26  5:00 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-24 19:19 [PATCH v2] drm/amd/display: enable more strict compile checks Hamza Mahfooz
2023-05-24 19:22 ` Alex Deucher
2023-05-24 19:23   ` Ho, Kenny
2023-05-24 19:41     ` Russell, Kent
2023-05-24 19:45       ` Felix Kuehling
2023-05-24 19:50         ` Alex Deucher
2023-05-24 19:56           ` Ho, Kenny
2023-05-24 20:27           ` Hamza Mahfooz
2023-05-25  7:48             ` Jani Nikula
2023-05-25 15:37             ` Kees Cook
2023-05-25 16:26               ` Nathan Chancellor
2023-05-24 19:27   ` Hamza Mahfooz
2023-05-24 19:54     ` Harry Wentland
2023-05-24 19:57       ` Hamza Mahfooz
2023-05-25  9:43 ` Christoph Hellwig
2023-05-26  5:00 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox