From: Alex Deucher <alexander.deucher@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Likun Gao <Likun.Gao@amd.com>,
Hawking Zhang <Hawking.Zhang@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>
Subject: [PATCH 6/9] drm/amdgpu/psp: handle TMR type via flag
Date: Mon, 12 Feb 2024 12:58:46 -0500 [thread overview]
Message-ID: <20240212175849.433812-6-alexander.deucher@amd.com> (raw)
In-Reply-To: <20240212175849.433812-1-alexander.deucher@amd.com>
From: Likun Gao <Likun.Gao@amd.com>
Add flag boot_time_tmr to indicate boot time TMR or runtime TMR
instead of function.
Signed-off-by: Likun Gao <Likun.Gao@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 15 ++++-----------
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h | 2 ++
2 files changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 5e1cd4a46ab5..00a477a9e606 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -233,6 +233,9 @@ static int psp_early_init(void *handle)
return -EINVAL;
}
+ if (amdgpu_ip_version(psp->adev, MP0_HWIP, 0) == IP_VERSION(13, 0, 6))
+ psp->boot_time_tmr = true;
+
psp->adev = adev;
psp_check_pmfw_centralized_cstate_management(psp);
@@ -779,16 +782,6 @@ static int psp_load_toc(struct psp_context *psp,
return ret;
}
-static bool psp_boottime_tmr(struct psp_context *psp)
-{
- switch (amdgpu_ip_version(psp->adev, MP0_HWIP, 0)) {
- case IP_VERSION(13, 0, 6):
- return true;
- default:
- return false;
- }
-}
-
/* Set up Trusted Memory Region */
static int psp_tmr_init(struct psp_context *psp)
{
@@ -2256,7 +2249,7 @@ static int psp_hw_start(struct psp_context *psp)
if (amdgpu_sriov_vf(adev) && amdgpu_in_reset(adev))
goto skip_pin_bo;
- if (!psp_boottime_tmr(psp)) {
+ if (!psp->boot_time_tmr) {
ret = psp_tmr_init(psp);
if (ret) {
dev_err(adev->dev, "PSP tmr init failed!\n");
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
index c24b1d7462ee..ee16f134ae92 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.h
@@ -364,6 +364,8 @@ struct psp_context {
atomic_t fence_value;
/* flag to mark whether gfx fw autoload is supported or not */
bool autoload_supported;
+ /* flag to mark whether psp use runtime TMR or boottime TMR */
+ bool boot_time_tmr;
/* flag to mark whether df cstate management centralized to PMFW */
bool pmfw_centralized_cstate_management;
--
2.42.0
next prev parent reply other threads:[~2024-02-12 17:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 17:58 [PATCH 0/9] PSP 14.0 support Alex Deucher
2024-02-12 17:58 ` [PATCH 2/9] drm/amdgpu: Add psp v14_0 ip block support Alex Deucher
2024-02-12 17:58 ` [PATCH 3/9] drm/amdgpu: use spirom update wait_for helper for psp v14 Alex Deucher
2024-02-12 17:58 ` [PATCH 4/9] drm/amdgpu: support psp ip block " Alex Deucher
2024-02-12 17:58 ` [PATCH 5/9] drm/amdgpu/psp: set autoload support by default Alex Deucher
2024-02-12 17:58 ` Alex Deucher [this message]
2024-02-12 17:58 ` [PATCH 7/9] drm/amdgpu/psp: set boot_time_tmr flag Alex Deucher
2024-02-12 17:58 ` [PATCH 8/9] drm/amdgpu: add psp_timeout to limit PSP related operation Alex Deucher
2024-02-12 17:58 ` [PATCH 9/9] drm/amdgpu: support psp ip block discovery for psp v14 Alex Deucher
2024-02-16 12:26 ` [PATCH 0/9] PSP 14.0 support Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240212175849.433812-6-alexander.deucher@amd.com \
--to=alexander.deucher@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Likun.Gao@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox