AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexander.deucher@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Likun Gao <Likun.Gao@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>
Subject: [PATCH 8/9] drm/amdgpu: add psp_timeout to limit PSP related operation
Date: Mon, 12 Feb 2024 12:58:48 -0500	[thread overview]
Message-ID: <20240212175849.433812-8-alexander.deucher@amd.com> (raw)
In-Reply-To: <20240212175849.433812-1-alexander.deucher@amd.com>

From: Likun Gao <Likun.Gao@amd.com>

Add a new parameter psp_timeout to limit psp related operation
to unify the timeout limition for psp.

Signed-off-by: Likun Gao <Likun.Gao@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu.h     | 1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 2a3f12bae823..d105e4084ced 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -1096,6 +1096,7 @@ struct amdgpu_device {
 	long				sdma_timeout;
 	long				video_timeout;
 	long				compute_timeout;
+	long				psp_timeout;
 
 	uint64_t			unique_id;
 	uint64_t	df_perfmon_config_assign_mask[AMDGPU_MAX_DF_PERFMONS];
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
index 2151636d579d..f4fcef335b44 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c
@@ -239,6 +239,8 @@ static int psp_early_init(void *handle)
 
 	psp->adev = adev;
 
+	adev->psp_timeout = 20000;
+
 	psp_check_pmfw_centralized_cstate_management(psp);
 
 	if (amdgpu_sriov_vf(adev))
@@ -636,7 +638,7 @@ psp_cmd_submit_buf(struct psp_context *psp,
 {
 	int ret;
 	int index;
-	int timeout = 20000;
+	int timeout = psp->adev->psp_timeout;
 	bool ras_intr = false;
 	bool skip_unsupport = false;
 
-- 
2.42.0


  parent reply	other threads:[~2024-02-12 17:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 17:58 [PATCH 0/9] PSP 14.0 support Alex Deucher
2024-02-12 17:58 ` [PATCH 2/9] drm/amdgpu: Add psp v14_0 ip block support Alex Deucher
2024-02-12 17:58 ` [PATCH 3/9] drm/amdgpu: use spirom update wait_for helper for psp v14 Alex Deucher
2024-02-12 17:58 ` [PATCH 4/9] drm/amdgpu: support psp ip block " Alex Deucher
2024-02-12 17:58 ` [PATCH 5/9] drm/amdgpu/psp: set autoload support by default Alex Deucher
2024-02-12 17:58 ` [PATCH 6/9] drm/amdgpu/psp: handle TMR type via flag Alex Deucher
2024-02-12 17:58 ` [PATCH 7/9] drm/amdgpu/psp: set boot_time_tmr flag Alex Deucher
2024-02-12 17:58 ` Alex Deucher [this message]
2024-02-12 17:58 ` [PATCH 9/9] drm/amdgpu: support psp ip block discovery for psp v14 Alex Deucher
2024-02-16 12:26 ` [PATCH 0/9] PSP 14.0 support Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240212175849.433812-8-alexander.deucher@amd.com \
    --to=alexander.deucher@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=Likun.Gao@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox