* [PATCH] drm/amdgpu: fix invalid fence handling in amdgpu_vm_tlb_flush
@ 2024-09-02 3:03 Lang Yu
2024-09-02 9:06 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Lang Yu @ 2024-09-02 3:03 UTC (permalink / raw)
To: amd-gfx; +Cc: Christian Koenig, Lang Yu
Fixes: 5a1c27951966 ("drm/amdgpu: implement TLB flush fence")
Signed-off-by: Lang Yu <lang.yu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 1d46a5c81ec4..f93804902fd3 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -908,10 +908,12 @@ amdgpu_vm_tlb_flush(struct amdgpu_vm_update_params *params,
{
struct amdgpu_vm *vm = params->vm;
- if (!fence || !*fence)
+ tlb_cb->vm = vm;
+ if (!fence || !*fence) {
+ amdgpu_vm_tlb_seq_cb(NULL, &tlb_cb->cb);
return;
+ }
- tlb_cb->vm = vm;
if (!dma_fence_add_callback(*fence, &tlb_cb->cb,
amdgpu_vm_tlb_seq_cb)) {
dma_fence_put(vm->last_tlb_flush);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix invalid fence handling in amdgpu_vm_tlb_flush
2024-09-02 3:03 [PATCH] drm/amdgpu: fix invalid fence handling in amdgpu_vm_tlb_flush Lang Yu
@ 2024-09-02 9:06 ` Christian König
2024-09-04 13:14 ` Philip Yang
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2024-09-02 9:06 UTC (permalink / raw)
To: Lang Yu, amd-gfx
Am 02.09.24 um 05:03 schrieb Lang Yu:
> Fixes: 5a1c27951966 ("drm/amdgpu: implement TLB flush fence")
>
> Signed-off-by: Lang Yu <lang.yu@amd.com>
Ah yes, that explains why CPU based updates doesn't work reliable any more.
You need to add some explanation to the commit message, e.g. something
like "CPU based updates doesn't produce a fence."
With that done Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 1d46a5c81ec4..f93804902fd3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -908,10 +908,12 @@ amdgpu_vm_tlb_flush(struct amdgpu_vm_update_params *params,
> {
> struct amdgpu_vm *vm = params->vm;
>
> - if (!fence || !*fence)
> + tlb_cb->vm = vm;
> + if (!fence || !*fence) {
> + amdgpu_vm_tlb_seq_cb(NULL, &tlb_cb->cb);
> return;
> + }
>
> - tlb_cb->vm = vm;
> if (!dma_fence_add_callback(*fence, &tlb_cb->cb,
> amdgpu_vm_tlb_seq_cb)) {
> dma_fence_put(vm->last_tlb_flush);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: fix invalid fence handling in amdgpu_vm_tlb_flush
2024-09-02 9:06 ` Christian König
@ 2024-09-04 13:14 ` Philip Yang
0 siblings, 0 replies; 3+ messages in thread
From: Philip Yang @ 2024-09-04 13:14 UTC (permalink / raw)
To: Christian König, Lang Yu, amd-gfx
[-- Attachment #1: Type: text/html, Size: 3166 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-04 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-02 3:03 [PATCH] drm/amdgpu: fix invalid fence handling in amdgpu_vm_tlb_flush Lang Yu
2024-09-02 9:06 ` Christian König
2024-09-04 13:14 ` Philip Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox