AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Hung <alex.hung@amd.com>
To: <dri-devel@lists.freedesktop.org>, <amd-gfx@lists.freedesktop.org>
Cc: <wayland-devel@lists.freedesktop.org>, <harry.wentland@amd.com>,
	<alex.hung@amd.com>
Subject: [V7 08/45] Documentation/gpu: document drm_colorop
Date: Thu, 19 Dec 2024 21:33:14 -0700	[thread overview]
Message-ID: <20241220043410.416867-9-alex.hung@amd.com> (raw)
In-Reply-To: <20241220043410.416867-1-alex.hung@amd.com>

From: Harry Wentland <harry.wentland@amd.com>

Add kernel doc for drm_colorop objects.

Signed-off-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
---
v7:
 - Add a commit messages

v5:
 - Drop TODO

 Documentation/gpu/drm-kms.rst | 15 +++++++++++++++
 drivers/gpu/drm/drm_colorop.c | 31 +++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)

diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst
index abfe220764e1..2292e65f044c 100644
--- a/Documentation/gpu/drm-kms.rst
+++ b/Documentation/gpu/drm-kms.rst
@@ -413,6 +413,21 @@ Plane Panic Functions Reference
 .. kernel-doc:: drivers/gpu/drm/drm_panic.c
    :export:
 
+Colorop Abstraction
+===================
+
+.. kernel-doc:: drivers/gpu/drm/drm_colorop.c
+   :doc: overview
+
+Colorop Functions Reference
+---------------------------
+
+.. kernel-doc:: include/drm/drm_colorop.h
+   :internal:
+
+.. kernel-doc:: drivers/gpu/drm/drm_colorop.c
+   :export:
+
 Display Modes Function Reference
 ================================
 
diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c
index a42de0aa48e1..aaaf96d729b9 100644
--- a/drivers/gpu/drm/drm_colorop.c
+++ b/drivers/gpu/drm/drm_colorop.c
@@ -31,6 +31,37 @@
 
 #include "drm_crtc_internal.h"
 
+/**
+ * DOC: overview
+ *
+ * A colorop represents a single color operation. Colorops are chained
+ * via the NEXT property and make up color pipelines. Color pipelines
+ * are advertised and selected via the COLOR_PIPELINE &drm_plane
+ * property.
+ *
+ * A colorop will be of a certain type, advertised by the read-only TYPE
+ * property. Each type of colorop will advertise a different set of
+ * properties and is programmed in a different manner. Types can be
+ * enumerated 1D curves, 1D LUTs, 3D LUTs, matrices, etc. See the
+ * &drm_colorop_type documentation for information on each type.
+ *
+ * If a colorop advertises the BYPASS property it can be bypassed.
+ *
+ * Since colorops cannot stand-alone and are used to describe colorop
+ * operations on a plane they don't have their own locking mechanism but
+ * are locked and programmed along with their associated &drm_plane.
+ *
+ * Colorops are only advertised and valid for atomic drivers and atomic
+ * userspace that signals the DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE client
+ * cap. When a driver advertises the COLOR_PIPELINE property on a
+ * &drm_plane and userspace signals the
+ * DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE the driver shall ignore all other
+ * plane color properties, such as COLOR_ENCODING and COLOR_RANGE.
+ *
+ * More information about colorops and color pipelines can be found at
+ * rfc/color_pipeline.rst.
+ */
+
 static const struct drm_prop_enum_list drm_colorop_type_enum_list[] = {
 	{ DRM_COLOROP_1D_CURVE, "1D Curve" },
 };
-- 
2.43.0


  parent reply	other threads:[~2024-12-20  4:37 UTC|newest]

Thread overview: 127+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20  4:33 [V7 00/45] Color Pipeline API w/ VKMS Alex Hung
2024-12-20  4:33 ` [V7 01/45] drm: Add helper for conversion from signed-magnitude Alex Hung
2025-02-24 16:07   ` Louis Chauvet
2025-02-24 18:50     ` Alex Hung
2025-02-25  9:35       ` Louis Chauvet
2024-12-20  4:33 ` [V7 02/45] drm/vkms: Round fixp2int conversion in lerp_u16 Alex Hung
2025-02-24 16:07   ` Louis Chauvet
2025-02-25  9:37   ` Louis Chauvet
2025-02-25 11:28     ` Simon Ser
2025-02-25 14:05       ` Louis Chauvet
2025-02-25 14:43         ` Harry Wentland
2025-02-25 14:45           ` Simon Ser
2025-02-25 16:00             ` Louis Chauvet
2024-12-20  4:33 ` [V7 03/45] drm/vkms: Add kunit tests for VKMS LUT handling Alex Hung
2025-02-24 16:07   ` Louis Chauvet
2025-02-25  9:51   ` Louis Chauvet
2025-02-25 14:45     ` Harry Wentland
2024-12-20  4:33 ` [V7 04/45] drm/doc/rfc: Describe why prescriptive color pipeline is needed Alex Hung
2024-12-20  4:33 ` [V7 05/45] drm/colorop: Introduce new drm_colorop mode object Alex Hung
2025-01-13  8:04   ` Simon Ser
2025-02-24 16:07   ` Louis Chauvet
2025-02-25 10:05   ` Louis Chauvet
2025-02-28 15:55     ` Harry Wentland
2024-12-20  4:33 ` [V7 06/45] drm/colorop: Add TYPE property Alex Hung
2025-01-13  8:05   ` Simon Ser
2025-02-24 16:07   ` Louis Chauvet
2025-02-25 10:07   ` Louis Chauvet
2024-12-20  4:33 ` [V7 07/45] drm/colorop: Add 1D Curve subtype Alex Hung
2025-01-13  8:07   ` Simon Ser
2025-02-24 16:07   ` Louis Chauvet
2025-02-25 10:13   ` Louis Chauvet
2025-02-28  1:07     ` Alex Hung
2025-02-28  9:24       ` Louis Chauvet
2024-12-20  4:33 ` Alex Hung [this message]
2025-01-13  8:18   ` [V7 08/45] Documentation/gpu: document drm_colorop Simon Ser
2025-02-10 22:03     ` Harry Wentland
2025-02-15 14:40       ` Simon Ser
2025-02-21 16:18         ` Harry Wentland
2025-02-21 16:42           ` Simon Ser
2025-02-21 18:41             ` Harry Wentland
2025-02-21 18:48               ` Simon Ser
2024-12-20  4:33 ` [V7 09/45] drm/colorop: Add BYPASS property Alex Hung
2025-01-13 17:49   ` Simon Ser
2025-02-24 16:07   ` Louis Chauvet
2025-02-25 10:15   ` Louis Chauvet
2024-12-20  4:33 ` [V7 10/45] drm/colorop: Add NEXT property Alex Hung
2025-01-13 17:54   ` Simon Ser
2025-02-24 16:07   ` Louis Chauvet
2025-02-25 10:21   ` Louis Chauvet
2024-12-20  4:33 ` [V7 11/45] drm/colorop: Add atomic state print for drm_colorop Alex Hung
2025-01-13 17:55   ` Simon Ser
2024-12-20  4:33 ` [V7 12/45] drm/plane: Add COLOR PIPELINE property Alex Hung
2025-01-13 18:08   ` Simon Ser
2024-12-20  4:33 ` [V7 13/45] drm/colorop: Introduce DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE Alex Hung
2025-01-13 18:23   ` Simon Ser
2025-01-22 19:48     ` Harry Wentland
2025-01-22 20:05       ` Simon Ser
2024-12-20  4:33 ` [V7 14/45] drm/vkms: Add enumerated 1D curve colorop Alex Hung
2025-02-25 11:18   ` Louis Chauvet
2025-03-10 19:43     ` Harry Wentland
2024-12-20  4:33 ` [V7 15/45] drm/vkms: Add kunit tests for linear and sRGB LUTs Alex Hung
2025-02-25 11:19   ` Louis Chauvet
2025-03-10 15:09     ` Harry Wentland
2024-12-20  4:33 ` [V7 16/45] drm/colorop: Add 3x4 CTM type Alex Hung
2025-01-13 18:19   ` Simon Ser
2025-02-25 11:20   ` Louis Chauvet
2024-12-20  4:33 ` [V7 17/45] drm/vkms: Use s32 for internal color pipeline precision Alex Hung
2024-12-20  4:33 ` [V7 18/45] drm/vkms: add 3x4 matrix in color pipeline Alex Hung
2025-02-25 11:21   ` Louis Chauvet
2024-12-20  4:33 ` [V7 19/45] drm/tests: Add a few tests around drm_fixed.h Alex Hung
2024-12-20  4:33 ` [V7 20/45] drm/vkms: Add tests for CTM handling Alex Hung
2024-12-20  4:33 ` [V7 21/45] drm/colorop: pass plane_color_pipeline client cap to atomic check Alex Hung
2024-12-20  4:33 ` [V7 22/45] drm/colorop: define a new macro for_each_new_colorop_in_state Alex Hung
2025-01-15  7:48   ` Simon Ser
2024-12-20  4:33 ` [V7 23/45] drm/amd/display: Ignore deprecated props when plane_color_pipeline set Alex Hung
2025-01-15  7:56   ` Simon Ser
2025-01-22 21:05     ` Harry Wentland
2025-01-23 20:29       ` Simon Ser
2024-12-20  4:33 ` [V7 24/45] drm/amd/display: Add bypass COLOR PIPELINE Alex Hung
2024-12-20  4:33 ` [V7 25/45] drm/amd/display: Skip color pipeline initialization for cursor plane Alex Hung
2024-12-20  4:33 ` [V7 26/45] drm/amd/display: Add support for sRGB EOTF in DEGAM block Alex Hung
2025-02-13 15:35   ` Leo Li
2024-12-20  4:33 ` [V7 27/45] drm/amd/display: Add support for sRGB Inverse EOTF in SHAPER block Alex Hung
2024-12-20  4:33 ` [V7 28/45] drm/amd/display: Add support for sRGB EOTF in BLND block Alex Hung
2024-12-20  4:33 ` [V7 29/45] drm/colorop: Add PQ 125 EOTF and its inverse Alex Hung
2025-01-15  8:00   ` Simon Ser
2025-01-23 20:06     ` Harry Wentland
2025-01-23 20:33       ` Simon Ser
2025-01-17  9:04   ` Pekka Paalanen
2025-01-23 20:09     ` Harry Wentland
2024-12-20  4:33 ` [V7 30/45] drm/amd/display: Enable support for PQ 125 EOTF and Inverse Alex Hung
2024-12-20  4:33 ` [V7 31/45] drm/colorop: add BT2020/BT709 OETF and Inverse OETF Alex Hung
2025-01-15  8:04   ` Simon Ser
2025-01-23 20:13     ` Harry Wentland
2025-01-16  8:56   ` Pekka Paalanen
2025-01-17  9:06     ` Pekka Paalanen
2025-01-23 20:16       ` Harry Wentland
2025-01-27 12:05         ` Pekka Paalanen
2024-12-20  4:33 ` [V7 32/45] drm/amd/display: Add support for BT.709 and BT.2020 TFs Alex Hung
2025-02-12 23:03   ` Leo Li
2024-12-20  4:33 ` [V7 33/45] drm/colorop: Add 1D Curve Custom LUT type Alex Hung
2025-01-15  8:14   ` Simon Ser
2025-01-16 23:33     ` Alex Hung
2025-01-18 13:54       ` Simon Ser
2025-01-15 15:48   ` Simon Ser
2024-12-20  4:33 ` [V7 34/45] drm/amd/display: add shaper and blend colorops for 1D Curve Custom LUT Alex Hung
2025-02-12 23:44   ` Leo Li
2025-02-21 16:28     ` Harry Wentland
2024-12-20  4:33 ` [V7 35/45] drm/amd/display: add 3x4 matrix colorop Alex Hung
2025-02-13 17:16   ` Leo Li
2024-12-20  4:33 ` [V7 36/45] drm/colorop: Add mutliplier type Alex Hung
2025-01-15 15:54   ` Simon Ser
2024-12-20  4:33 ` [V7 37/45] drm/amd/display: add multiplier colorop Alex Hung
2024-12-20  4:33 ` [V7 38/45] drm/amd/display: Swap matrix and multiplier Alex Hung
2024-12-20  4:33 ` [V7 39/45] drm/colorop: Define LUT_1D interpolation Alex Hung
2025-01-20  7:48   ` Simon Ser
2024-12-20  4:33 ` [V7 40/45] drm/colorop: allow non-bypass colorops Alex Hung
2024-12-20  4:33 ` [V7 41/45] drm/colorop: Add 3D LUT supports to color pipeline Alex Hung
2025-01-20 21:16   ` Simon Ser
2024-12-20  4:33 ` [V7 42/45] drm/amd/display: add 3D LUT colorop Alex Hung
2025-02-13 18:21   ` Leo Li
2025-02-21 21:05     ` Harry Wentland
2024-12-20  4:33 ` [V7 43/45] drm/amd/display: Add AMD color pipeline doc Alex Hung
2025-01-17  9:19   ` Pekka Paalanen
2025-01-23 20:52     ` Harry Wentland
2024-12-20  4:33 ` [V7 44/45] drm/colorop: Add kernel doc for data blob Alex Hung
2024-12-20  4:33 ` [V7 45/45] drm/colorop: Add destroy functions for color pipeline Alex Hung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241220043410.416867-9-alex.hung@amd.com \
    --to=alex.hung@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=harry.wentland@amd.com \
    --cc=wayland-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox