AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Demers <alexandre.f.demers@gmail.com>
To: amd-gfx@lists.freedesktop.org
Subject: [PATCH 00/18] Properly wire defines, shifts and masks in SI and cleanup
Date: Fri, 21 Mar 2025 21:46:42 -0400	[thread overview]
Message-ID: <20250322014700.62356-1-alexandre.f.demers@gmail.com> (raw)

The following series is intented to remove duplicated defines, shifts and masks or
to classify them where they belong. si_enums.h has been used as a garbage can
for anything and everything when moving SI code from radeon to amdgpu. 

Where needed, the defines found under sid.h and si_enums.h were ported to DCE6,
GFX6 and GMC6 defines, shifts and masks. There location was based on CIK and
later.

However, most of them were already available, but not used where they could be.

This series is running on my PITCAIRN setup without any visible drawbacks.

V2: Drop unneeded comments.
Remove "ix" prefix on some defines, since they are not indexes.
Make sure each patch has a description.

Alexandre Demers (18):
  drm/amdgpu: move GFX6 defines into gfx_v6_0.c
  drm/amdgpu: wire up defines, shifts and masks through SI code
  drm/amdgpu: use proper defines, shifts and masks in DCE6 code
  drm/amdgpu: remove PACKET3 duplicated defines from si_enums.h
  drm/admgpu: move si_ih.c away from sid.h defines
  drm/amdgpu: use GRPH_SECONDARY_SURFACE_ADDRESS_MASK with
    GRPH_SECONDARY_SURFACE_ADDRESS in DCE6
  drm/amdgpu: move DCE6 away from sid.h and si_enums.h defines
  drm/amdgpu: add missing DMA defines, shifts and masks
  drm/amdgpu: add missing GFX6 defines
  drm/amdgpu: add missing SMU6 defines, shifts and masks
  drm/pm/legacy-dpm: move SI away from sid.h and si_enums.h
  drm/amdgpu: fix GFX6 variables for sid.h cleanup
  drm/amdgpu: move si.c away from sid.h
  drm/amdgpu: move si_dma.c away from sid.h and si_enums.h
  drm/amdgpu: huge sid.h cleanup, drop substituted defines.
  drm/amdgpu: keep removing sid.h dependency from si_dma.c
  drm/amdgpu: cleanup DCE6 a bit more
  drm/amdgpu: continue cleaning up sid.h and si_enums.h

 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c         |  176 +-
 drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c         |   15 +-
 drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c         |    2 +-
 drivers/gpu/drm/amd/amdgpu/si.c               |  387 +++--
 drivers/gpu/drm/amd/amdgpu/si_dma.c           |  116 +-
 drivers/gpu/drm/amd/amdgpu/si_enums.h         |  234 +--
 drivers/gpu/drm/amd/amdgpu/si_ih.c            |   17 +-
 drivers/gpu/drm/amd/amdgpu/sid.h              | 1546 ++---------------
 .../include/asic_reg/dce/dce_6_0_sh_mask.h    |    4 +-
 .../drm/amd/include/asic_reg/gca/gfx_6_0_d.h  |    2 +
 .../drm/amd/include/asic_reg/oss/oss_1_0_d.h  |   23 +-
 .../include/asic_reg/oss/oss_1_0_sh_mask.h    |   43 +
 .../drm/amd/include/asic_reg/smu/smu_6_0_d.h  |   44 +
 .../include/asic_reg/smu/smu_6_0_sh_mask.h    |  190 +-
 drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c    |  358 ++--
 drivers/gpu/drm/amd/pm/legacy-dpm/si_smc.c    |   42 +-
 16 files changed, 1001 insertions(+), 2198 deletions(-)

-- 
2.48.1


             reply	other threads:[~2025-03-22  1:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-22  1:46 Alexandre Demers [this message]
2025-03-22  1:46 ` [PATCH 01/18] drm/amdgpu: move GFX6 defines into gfx_v6_0.c Alexandre Demers
2025-03-22  1:46 ` [PATCH 02/18] drm/amdgpu: wire up defines, shifts and masks through SI code Alexandre Demers
2025-03-22  1:46 ` [PATCH 03/18] drm/amdgpu: use proper defines, shifts and masks in DCE6 code Alexandre Demers
2025-03-22  1:46 ` [PATCH 04/18] drm/amdgpu: remove PACKET3 duplicated defines from si_enums.h Alexandre Demers
2025-03-22  1:46 ` [PATCH 05/18] drm/admgpu: move si_ih.c away from sid.h defines Alexandre Demers
2025-03-22  1:46 ` [PATCH 06/18] drm/amdgpu: use GRPH_SECONDARY_SURFACE_ADDRESS_MASK with GRPH_SECONDARY_SURFACE_ADDRESS in DCE6 Alexandre Demers
2025-03-22  1:46 ` [PATCH 07/18] drm/amdgpu: move DCE6 away from sid.h and si_enums.h defines Alexandre Demers
2025-03-22  1:46 ` [PATCH 08/18] drm/amdgpu: add missing DMA defines, shifts and masks Alexandre Demers
2025-03-22  1:46 ` [PATCH 09/18] drm/amdgpu: add missing GFX6 defines Alexandre Demers
2025-03-22  1:46 ` [PATCH 10/18] drm/amdgpu: add missing SMU6 defines, shifts and masks Alexandre Demers
2025-03-24 19:03   ` Alex Deucher
2025-03-27  4:21     ` Alexandre Demers
2025-03-22  1:46 ` [PATCH 11/18] drm/pm/legacy-dpm: move SI away from sid.h and si_enums.h Alexandre Demers
2025-03-22  1:46 ` [PATCH 12/18] drm/amdgpu: make GFX6 easier to read Alexandre Demers
2025-03-22  1:46 ` [PATCH 13/18] drm/amdgpu: move si.c away from sid.h Alexandre Demers
2025-03-22  1:46 ` [PATCH 14/18] drm/amdgpu: move si_dma.c away from sid.h and si_enums.h Alexandre Demers
2025-03-22  1:46 ` [PATCH 15/18] drm/amdgpu: huge sid.h cleanup, drop substituted defines Alexandre Demers
2025-03-22  1:46 ` [PATCH 16/18] drm/amdgpu: keep removing sid.h dependency from si_dma.c Alexandre Demers
2025-03-22  1:46 ` [PATCH 17/18] drm/amdgpu: cleanup DCE6 a bit more Alexandre Demers
2025-03-22  1:47 ` [PATCH 18/18] drm/amdgpu: continue cleaning up sid.h and si_enums.h Alexandre Demers
2025-03-22 16:16 ` [PATCH v2 00/18] Properly wire defines, shifts and masks in SI and cleanup Alexandre Demers
2025-03-24 19:26 ` [PATCH " Alex Deucher
  -- strict thread matches above, loose matches on Subject: below --
2025-03-17  6:06 Alexandre Demers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250322014700.62356-1-alexandre.f.demers@gmail.com \
    --to=alexandre.f.demers@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox