AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v] drm/amd/pm: Enable VCN reset for pgm=4 with appropriate FW version
@ 2026-03-19 10:45 Jesse.Zhang
  2026-03-19 13:14 ` Alex Deucher
  2026-03-19 13:52 ` Lazar, Lijo
  0 siblings, 2 replies; 3+ messages in thread
From: Jesse.Zhang @ 2026-03-19 10:45 UTC (permalink / raw)
  To: amd-gfx
  Cc: Alexander.Deucher, Christian Koenig, Lijo Lazar, Jesse.Zhang,
	Jesse Zhang

Extend the VCN reset capability to include pgm=4 variants when the
firmware version meets the required threshold (>= 0x04557100). This
follows the existing pattern for pgm=0 and pgm=7, ensuring that VCN
reset is enabled only on configurations where it is supported by the
firmware.

Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index 5b9580034641..deb8f827abcc 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -461,6 +461,7 @@ static void smu_v13_0_6_init_caps(struct smu_context *smu)
 		smu_v13_0_6_cap_set(smu, SMU_CAP(SDMA_RESET));
 
 	if ((pgm == 0 && fw_ver >= 0x00558200) ||
+	    (pgm == 4 && fw_ver >= 0x04557100) ||
 	    (pgm == 7 && fw_ver >= 0x07551400))
 		smu_v13_0_6_cap_set(smu, SMU_CAP(VCN_RESET));
 }
-- 
2.49.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v] drm/amd/pm: Enable VCN reset for pgm=4 with appropriate FW version
  2026-03-19 10:45 [PATCH v] drm/amd/pm: Enable VCN reset for pgm=4 with appropriate FW version Jesse.Zhang
@ 2026-03-19 13:14 ` Alex Deucher
  2026-03-19 13:52 ` Lazar, Lijo
  1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2026-03-19 13:14 UTC (permalink / raw)
  To: Jesse.Zhang; +Cc: amd-gfx, Alexander.Deucher, Christian Koenig, Lijo Lazar

On Thu, Mar 19, 2026 at 6:54 AM Jesse.Zhang <Jesse.Zhang@amd.com> wrote:
>
> Extend the VCN reset capability to include pgm=4 variants when the
> firmware version meets the required threshold (>= 0x04557100). This
> follows the existing pattern for pgm=0 and pgm=7, ensuring that VCN
> reset is enabled only on configurations where it is supported by the
> firmware.
>
> Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>

Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 5b9580034641..deb8f827abcc 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -461,6 +461,7 @@ static void smu_v13_0_6_init_caps(struct smu_context *smu)
>                 smu_v13_0_6_cap_set(smu, SMU_CAP(SDMA_RESET));
>
>         if ((pgm == 0 && fw_ver >= 0x00558200) ||
> +           (pgm == 4 && fw_ver >= 0x04557100) ||
>             (pgm == 7 && fw_ver >= 0x07551400))
>                 smu_v13_0_6_cap_set(smu, SMU_CAP(VCN_RESET));
>  }
> --
> 2.49.0
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v] drm/amd/pm: Enable VCN reset for pgm=4 with appropriate FW version
  2026-03-19 10:45 [PATCH v] drm/amd/pm: Enable VCN reset for pgm=4 with appropriate FW version Jesse.Zhang
  2026-03-19 13:14 ` Alex Deucher
@ 2026-03-19 13:52 ` Lazar, Lijo
  1 sibling, 0 replies; 3+ messages in thread
From: Lazar, Lijo @ 2026-03-19 13:52 UTC (permalink / raw)
  To: Jesse.Zhang, amd-gfx; +Cc: Alexander.Deucher, Christian Koenig



On 19-Mar-26 4:15 PM, Jesse.Zhang wrote:
> Extend the VCN reset capability to include pgm=4 variants when the
> firmware version meets the required threshold (>= 0x04557100). This
> follows the existing pattern for pgm=0 and pgm=7, ensuring that VCN
> reset is enabled only on configurations where it is supported by the
> firmware.
> 
> Signed-off-by: Jesse Zhang <jesse.zhang@amd.com>

Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 5b9580034641..deb8f827abcc 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -461,6 +461,7 @@ static void smu_v13_0_6_init_caps(struct smu_context *smu)
>   		smu_v13_0_6_cap_set(smu, SMU_CAP(SDMA_RESET));
>   
>   	if ((pgm == 0 && fw_ver >= 0x00558200) ||
> +	    (pgm == 4 && fw_ver >= 0x04557100) ||
>   	    (pgm == 7 && fw_ver >= 0x07551400))
>   		smu_v13_0_6_cap_set(smu, SMU_CAP(VCN_RESET));
>   }


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-03-19 13:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-19 10:45 [PATCH v] drm/amd/pm: Enable VCN reset for pgm=4 with appropriate FW version Jesse.Zhang
2026-03-19 13:14 ` Alex Deucher
2026-03-19 13:52 ` Lazar, Lijo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox