From: Sunil Khatri <sunil.khatri@amd.com>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Cc: amd-gfx@lists.freedesktop.org, Sunil Khatri <sunil.khatri@amd.com>
Subject: [Patch v1 2/4] drm/amdgpu/userq: no need to use local variable here for return
Date: Thu, 26 Mar 2026 14:25:59 +0530 [thread overview]
Message-ID: <20260326085601.2665215-3-sunil.khatri@amd.com> (raw)
In-Reply-To: <20260326085601.2665215-1-sunil.khatri@amd.com>
In function amdgpu_userq_restore_worker use directly
the function's return value in the if condition instead
of local variable ret.
Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
index 2a1832fce6d2..2b07c3941927 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
@@ -1222,20 +1222,17 @@ static void amdgpu_userq_restore_worker(struct work_struct *work)
struct amdgpu_userq_mgr *uq_mgr = work_to_uq_mgr(work, resume_work.work);
struct amdgpu_fpriv *fpriv = uq_mgr_to_fpriv(uq_mgr);
struct dma_fence *ev_fence;
- int ret;
ev_fence = amdgpu_evf_mgr_get_fence(&fpriv->evf_mgr);
if (!dma_fence_is_signaled(ev_fence))
goto put_fence;
- ret = amdgpu_userq_vm_validate(uq_mgr);
- if (ret) {
+ if (amdgpu_userq_vm_validate(uq_mgr)) {
drm_file_err(uq_mgr->file, "Failed to validate BOs to restore\n");
goto put_fence;
}
- ret = amdgpu_userq_restore_all(uq_mgr);
- if (ret)
+ if (amdgpu_userq_restore_all(uq_mgr))
drm_file_err(uq_mgr->file, "Failed to restore all queues\n");
put_fence:
--
2.34.1
next prev parent reply other threads:[~2026-03-26 8:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 8:55 [Patch v1 0/4] Bunch of patches to do trivial clean up and Sunil Khatri
2026-03-26 8:55 ` [Patch v1 1/4] drm/amdgpu/userq: no need to use local variable ret Sunil Khatri
2026-03-26 12:08 ` Christian König
2026-03-26 12:26 ` Khatri, Sunil
2026-03-26 12:52 ` Christian König
2026-03-26 8:55 ` Sunil Khatri [this message]
2026-03-26 12:09 ` [Patch v1 2/4] drm/amdgpu/userq: no need to use local variable here for return Christian König
2026-03-26 12:30 ` Khatri, Sunil
2026-03-26 12:55 ` Christian König
2026-03-26 8:56 ` [Patch v1 3/4] " Sunil Khatri
2026-03-26 12:11 ` Christian König
2026-03-26 12:32 ` Khatri, Sunil
2026-03-26 8:56 ` [Patch v1 4/4] drm/amdgpu/userq: Fix the code alignment for readability Sunil Khatri
2026-03-26 12:12 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260326085601.2665215-3-sunil.khatri@amd.com \
--to=sunil.khatri@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox