Re: [Patch v1 4/4] drm/amdgpu/userq: Fix the code alignment for readability

["Christian König" <christian.koenig@amd.com>]

On 3/26/26 09:56, Sunil Khatri wrote:
> Fix the code alignment for if condition and also provide
> a line space between multiline if condition and next
> statement.
> 
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> index 48cb2e21ce56..7cdfe3adcbae 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> @@ -1454,17 +1454,19 @@ int amdgpu_userq_start_sched_for_enforce_isolation(struct amdgpu_device *adev,
>  
>  	if (!adev->userq_halt_for_enforce_isolation)
>  		dev_warn(adev->dev, "userq scheduling already started!\n");
> +
>  	adev->userq_halt_for_enforce_isolation = false;
> +
>  	xa_for_each(&adev->userq_doorbell_xa, queue_id, queue) {
>  		uqm = queue->userq_mgr;
>  		mutex_lock(&uqm->userq_mutex);
> -			if (((queue->queue_type == AMDGPU_HW_IP_GFX) ||
> -			     (queue->queue_type == AMDGPU_HW_IP_COMPUTE)) &&
> -			    (queue->xcp_id == idx)) {
> +		if (((queue->queue_type == AMDGPU_HW_IP_GFX) ||
> +		     (queue->queue_type == AMDGPU_HW_IP_COMPUTE)) &&
> +		    (queue->xcp_id == idx)) {
>  			r = amdgpu_userq_restore_helper(queue);
>  			if (r)
>  				ret = r;
> -			}
> +		}
>  		mutex_unlock(&uqm->userq_mutex);
>  	}
>