From: <sunpeng.li@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <Harry.Wentland@amd.com>, <mario.limonciello@amd.com>,
<wiagn233@outlook.com>, <sysdadmin@m1k.cloud>,
<timur.kristof@gmail.com>, <xaver.hugl@kde.org>,
<mario.kleiner.de@gmail.com>, <michel.daenzer@mailbox.org>,
<matthew.schwartz@linux.dev>, <chris@kode54.net>,
Leo Li <sunpeng.li@amd.com>, <stable@vger.kernel.org>
Subject: [PATCH v3 3/3] Revert "drm/amd/display: Restore 5s vbl offdelay for NV3x+ DGPUs"
Date: Tue, 30 Jun 2026 14:03:01 -0400 [thread overview]
Message-ID: <20260630180301.362070-4-sunpeng.li@amd.com> (raw)
In-Reply-To: <20260630180301.362070-1-sunpeng.li@amd.com>
From: Leo Li <sunpeng.li@amd.com>
Now that proper fixes have been found, let's revert this workaround.
This reverts commit 751414c12388ff2b475e15c15d3c817dcf563635.
Cc: stable@vger.kernel.org
Signed-off-by: Leo Li <sunpeng.li@amd.com>
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 18 +++---------------
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 754fedbdd7460..43a786f08516e 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -3526,21 +3526,9 @@ static void manage_dm_interrupts(struct amdgpu_device *adev,
if (acrtc_state) {
timing = &acrtc_state->stream->timing;
- if (amdgpu_ip_version(adev, DCE_HWIP, 0) >=
- IP_VERSION(3, 2, 0) &&
- !(adev->flags & AMD_IS_APU)) {
- /*
- * DGPUs NV3x and newer that support idle optimizations
- * experience intermittent flip-done timeouts on cursor
- * updates. Restore 5s offdelay behavior for now.
- *
- * Discussion on the issue:
- * https://lore.kernel.org/amd-gfx/20260217191632.1243826-1-sysdadmin@m1k.cloud/
- */
- config.offdelay_ms = 5000;
- config.disable_immediate = false;
- } else if (amdgpu_ip_version(adev, DCE_HWIP, 0) <
- IP_VERSION(3, 5, 0)) {
+ if (amdgpu_ip_version(adev, DCE_HWIP, 0) <
+ IP_VERSION(3, 5, 0) ||
+ !(adev->flags & AMD_IS_APU)) {
/*
* Older HW and DGPU have issues with instant off;
* use a 2 frame offdelay.
--
2.54.0
next prev parent reply other threads:[~2026-06-30 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 18:02 [PATCH v3 0/3] Fixes for flip_done timed outs and PSR/Replay corruption sunpeng.li
2026-06-30 18:02 ` [PATCH v3 1/3] drm/amd/display: consolidate DCN vblank/flip handling onto vupdate_no_lock sunpeng.li
2026-06-30 18:03 ` [PATCH v3 2/3] drm/amd/display: check GRPH_FLIP status before sending event sunpeng.li
2026-06-30 18:03 ` sunpeng.li [this message]
2026-07-01 21:09 ` [PATCH v3 0/3] Fixes for flip_done timed outs and PSR/Replay corruption Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630180301.362070-4-sunpeng.li@amd.com \
--to=sunpeng.li@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=chris@kode54.net \
--cc=mario.kleiner.de@gmail.com \
--cc=mario.limonciello@amd.com \
--cc=matthew.schwartz@linux.dev \
--cc=michel.daenzer@mailbox.org \
--cc=stable@vger.kernel.org \
--cc=sysdadmin@m1k.cloud \
--cc=timur.kristof@gmail.com \
--cc=wiagn233@outlook.com \
--cc=xaver.hugl@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox