Re: [PATCH v3 0/3] Fixes for flip_done timed outs and PSR/Replay corruption

[Mario Limonciello <superm1@kernel.org>]

On 6/30/26 13:02, sunpeng.li@amd.com wrote:
> From: Leo Li <sunpeng.li@amd.com>
> 
> v1 here:
> https://lore.kernel.org/amd-gfx/20260616201828.389985-1-sunpeng.li@amd.com/
> v2 here:
> https://lore.kernel.org/amd-gfx/20260622171752.73374-1-sunpeng.li@amd.com/
> 
> Summary of changes since v2:
> 
> * Fixed a regression in kms_vrr@flip-basic, which exposed a scenario in
>    optimistic event delivery where wrong vblank timestamps were attached.
>    See new docstrings in patch 2/3 for details.
> * Readability cleanups in patch 2/3, thanks Michel!
> 
> v7.0.y based branch here (drops the revert and resolves merge conflicts
> due to recent refactor of IRQ handlers from amdgpu_dm.c into
> amdgpu_dm_irq.c):
> https://gitlab.freedesktop.org/leoli/linux-asdn/-/commits/lileo/flip_done_timeout_corruption_fixes?ref_type=heads
> 
> A Note on LLM use:
> 
> Claude helped with code plumbing and IGT testing. The effort of
> reporting, debugging, spinning up fixes, and testing them, were from
> humans. Kudos to individuals who collaborated on the amd-gfx mailing
> list, gitlab, 2026 Display Hackfest, and AMD internal chats, to finally
> nail down a fix.
> 

Having been one of those being able to readily reproduce issues at the 
hackfest with PSR I'm happy to report that I tested a backport of this 
series on a clean 7.2-rc1 where I don't observe any issues.  Due to 
changes in the codebase it's not purely the same as your content headed 
to drm-next.

The branch of what I tested is here though if anyone else would like to 
test on 7.2 as well.

https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git/log/?h=lileo/flip_done_timeout_corruption_fixes-7.2

So my tag isn't purely this series, but I guess at least close enough 
with the backport if you want to carry it forward.

Tested-by: Mario Limonciello (AMD) <superm1@kernel.org>

Also as I reviewed the series nothing stands out to me, you obviously 
know this part of the code base better than anyone though.

Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>

Since I had a hard time applying this even to 7.2, I suspect after we 
land this we'll need to do some custom/manual backports for each of the 
applicable stable series at the time it actually lands in mainline.

> 
> Leo Li (3):
>    drm/amd/display: consolidate DCN vblank/flip handling onto
>      vupdate_no_lock
>    drm/amd/display: check GRPH_FLIP status before sending event
>    Revert "drm/amd/display: Restore 5s vbl offdelay for NV3x+ DGPUs"
> 
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 234 +++++++++++---
>   .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c    |  70 ++--
>   .../drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 299 +++++++++---------
>   drivers/gpu/drm/amd/display/dc/core/dc.c      |  45 +++
>   drivers/gpu/drm/amd/display/dc/dc.h           |   1 +
>   5 files changed, 417 insertions(+), 232 deletions(-)
> 
> --
> 2.54.0
>