From: Kevin Wang <kevin.wang@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <alexander.deucher@amd.com>, <hawking.zhang@amd.com>,
<kenneth.feng@amd.com>
Subject: [PATCH 6/7] drm/amd/pm: stage od reset for smu 15.0.8
Date: Mon, 31 Aug 2026 12:35:06 +0800 [thread overview]
Message-ID: <20260831043507.523599-7-kevin.wang@amd.com> (raw)
In-Reply-To: <20260831043507.523599-1-kevin.wang@amd.com>
SMU 15.0.8 applies default GFXCLK and UCLK ranges directly from reset.
Stage the defaults instead, leaving c as the only PMFW update operation.
Only stage and commit UCLK when its DPM feature is enabled. This matches
the edit path and avoids sending an unsupported UCLK limit command.
Signed-off-by: Kevin Wang <kevin.wang@amd.com>
---
.../drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c | 50 ++++++++++---------
1 file changed, 27 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
index db0e0733588d..0f7a8b4585d2 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu15/smu_v15_0_8_ppt.c
@@ -2072,6 +2072,28 @@ static int smu_v15_0_8_set_soft_freq_limited_range(struct smu_context *smu,
return ret;
}
+static void smu_v15_0_8_stage_default_dpm_limits(struct smu_context *smu)
+{
+ struct smu_dpm_context *smu_dpm = &smu->smu_dpm;
+ struct smu_15_0_dpm_context *dpm_context = smu_dpm->dpm_context;
+ struct smu_umd_pstate_table *pstate_table = &smu->pstate_table;
+
+ pstate_table->gfxclk_pstate.custom.min =
+ SMU_DPM_TABLE_MIN(&dpm_context->dpm_tables.gfx_table);
+ pstate_table->gfxclk_pstate.custom.max =
+ SMU_DPM_TABLE_MAX(&dpm_context->dpm_tables.gfx_table);
+
+ if (smu_cmn_feature_is_enabled(smu, SMU_FEATURE_DPM_UCLK_BIT)) {
+ pstate_table->uclk_pstate.custom.min =
+ SMU_DPM_TABLE_MIN(&dpm_context->dpm_tables.uclk_table);
+ pstate_table->uclk_pstate.custom.max =
+ SMU_DPM_TABLE_MAX(&dpm_context->dpm_tables.uclk_table);
+ } else {
+ pstate_table->uclk_pstate.custom.min = 0;
+ pstate_table->uclk_pstate.custom.max = 0;
+ }
+}
+
static int smu_v15_0_8_od_edit_dpm_table(struct smu_context *smu,
enum PP_OD_DPM_TABLE_COMMAND type,
long input[], uint32_t size)
@@ -2159,27 +2181,7 @@ static int smu_v15_0_8_od_edit_dpm_table(struct smu_context *smu,
return -EINVAL;
}
- /* Use the default frequencies for manual mode */
- min_clk = SMU_DPM_TABLE_MIN(&dpm_context->dpm_tables.gfx_table);
- max_clk = SMU_DPM_TABLE_MAX(&dpm_context->dpm_tables.gfx_table);
-
- ret = smu_v15_0_8_set_soft_freq_limited_range(smu,
- SMU_GFXCLK,
- min_clk, max_clk,
- false);
- if (ret)
- return ret;
-
- min_clk = SMU_DPM_TABLE_MIN(&dpm_context->dpm_tables.uclk_table);
- max_clk = SMU_DPM_TABLE_MAX(&dpm_context->dpm_tables.uclk_table);
- ret = smu_v15_0_8_set_soft_freq_limited_range(smu,
- SMU_UCLK,
- min_clk, max_clk,
- false);
- if (ret)
- return ret;
-
- smu_cmn_reset_custom_level(smu);
+ smu_v15_0_8_stage_default_dpm_limits(smu);
break;
case PP_OD_COMMIT_DPM_TABLE:
if (size != 0) {
@@ -2207,8 +2209,10 @@ static int smu_v15_0_8_od_edit_dpm_table(struct smu_context *smu,
return ret;
/* Commit UCLK custom range (only max supported) */
- if (pstate_table->uclk_pstate.custom.max) {
- min_clk = pstate_table->uclk_pstate.curr.min;
+ if (pstate_table->uclk_pstate.custom.max &&
+ smu_cmn_feature_is_enabled(smu, SMU_FEATURE_DPM_UCLK_BIT)) {
+ min_clk = pstate_table->uclk_pstate.custom.min ?:
+ pstate_table->uclk_pstate.curr.min;
max_clk = pstate_table->uclk_pstate.custom.max;
ret = smu_v15_0_8_set_soft_freq_limited_range(smu,
SMU_UCLK,
--
2.55.0
next prev parent reply other threads:[~2026-08-31 4:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 4:35 [PATCH 0/7] drm/amd/pm: stage OD reset until commit Kevin Wang
2026-08-31 4:35 ` [PATCH 1/7] drm/amd/pm: stage od reset for smu 11.0.7 Kevin Wang
2026-08-31 4:35 ` [PATCH 2/7] drm/amd/pm: stage od reset for smu 13.0.2 Kevin Wang
2026-08-31 4:35 ` [PATCH 3/7] drm/amd/pm: stage od reset for smu 13.0.0/13.0.7 Kevin Wang
2026-08-31 4:35 ` [PATCH 4/7] drm/amd/pm: stage od reset for smu 13.0.6 Kevin Wang
2026-08-31 10:51 ` Lazar, Lijo
2026-08-31 4:35 ` [PATCH 5/7] drm/amd/pm: stage od reset for smu 14.0.2 Kevin Wang
2026-08-31 4:35 ` Kevin Wang [this message]
2026-08-31 4:35 ` [PATCH 7/7] drm/amd/pm: stage od reset for smu vega20 Kevin Wang
2026-08-31 8:09 ` [PATCH 0/7] drm/amd/pm: stage OD reset until commit Feng, Kenneth
2026-08-31 8:23 ` Wang, Kevin
2026-08-31 10:55 ` Lazar, Lijo
2026-08-31 11:05 ` Lazar, Lijo
2026-08-31 12:06 ` Wang, Kevin
2026-08-31 12:21 ` Lazar, Lijo
2026-08-31 12:47 ` Wang, Kevin
2026-09-01 6:44 ` Feng, Kenneth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260831043507.523599-7-kevin.wang@amd.com \
--to=kevin.wang@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=hawking.zhang@amd.com \
--cc=kenneth.feng@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox