AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Joerg Roedel <joro@8bytes.org>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	amd-gfx@lists.freedesktop.org,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	Vasant Hegde <vasant.hegde@amd.com>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	"open list:AMD IOMMU (AMD-VI)" <iommu@lists.linux.dev>,
	Jatin Kataria <jkataria@netflix.com>,
	Boqun Feng <boqunf@netflix.com>,
	"Derek J . Clark" <derekjohn.clark@gmail.com>
Subject: Re: [PATCH v2 1/2] iommu/amd: Add PerfOpt IOMMU performance optimization support
Date: Fri, 25 Sep 2026 09:28:48 -0300	[thread overview]
Message-ID: <20260925122848.GD163130@ziepe.ca> (raw)
In-Reply-To: <arYf3iJW7hfTua__@8bytes.org>

On Fri, Sep 25, 2026 at 09:20:02AM +0200, Joerg Roedel wrote:
> On Thu, Sep 24, 2026 at 07:50:18PM -0300, Jason Gunthorpe wrote:
> > Why does the GPU driver have to request this? Why can't the iommu
> > driver know that this is a special device that can use this magic fast
> > path and then auto set it when identity is asked for?
> 
> This is a layering violation either way. Either the IOMMU driver needs to poke
> into device details and their relations or the device driver needs to poke into
> IOMMU details.

There are no device details, this is just a module option in the gpu
driver.

> This is not perfect but to some degree unavoidable with these highly integrated
> SOCs.

This is exactly the sort of hacky thing ACPI should describe so the
drivers can just turn things on automatically.

Who is ever going to track down and figure out it is OK to set these
kinds of module options in the first place? There is general negative
sentiment in the kernel to doing things like this with modue options.

How does Windows do it? There certainly isn't a "module option" there?

Jason

  reply	other threads:[~2026-09-25 12:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08  4:12 [PATCH v2 0/2] IOMMU Performance Optimization support Mario Limonciello
2026-09-08  4:12 ` [PATCH v2 1/2] iommu/amd: Add PerfOpt IOMMU performance optimization support Mario Limonciello
2026-09-24 22:50   ` Jason Gunthorpe
2026-09-25  0:03     ` Mario Limonciello
2026-09-25  0:17       ` Jason Gunthorpe
2026-09-25  0:21         ` Mario Limonciello
2026-09-25  7:20     ` Joerg Roedel
2026-09-25 12:28       ` Jason Gunthorpe [this message]
2026-09-25 13:11         ` Mario Limonciello
2026-09-25 22:39           ` Jason Gunthorpe
2026-09-26  0:33             ` Mario Limonciello
2026-09-28 12:08               ` Jason Gunthorpe
2026-09-28 15:32                 ` Mario Limonciello
2026-09-28 17:11                   ` Jason Gunthorpe
2026-09-28 17:15                     ` Mario Limonciello
2026-09-29  2:53                       ` Deucher, Alexander
2026-09-28  5:17     ` Christoph Hellwig
2026-09-25  7:30   ` Joerg Roedel
2026-09-08  4:12 ` [PATCH v2 2/2] drm/amdgpu: Enable PerfOpt IOMMU perf optimization when GPU in identity domain Mario Limonciello
2026-09-20 14:10 ` [PATCH v2 0/2] IOMMU Performance Optimization support Mario Limonciello
2026-09-20 16:27 ` Boqun Feng
2026-09-24 11:42 ` Joerg Roedel
2026-09-24 13:01   ` Deucher, Alexander
2026-09-24 13:50     ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260925122848.GD163130@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=boqunf@netflix.com \
    --cc=derekjohn.clark@gmail.com \
    --cc=iommu@lists.linux.dev \
    --cc=jkataria@netflix.com \
    --cc=joro@8bytes.org \
    --cc=mario.limonciello@amd.com \
    --cc=robin.murphy@arm.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=vasant.hegde@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox