Re: [PATCH v1 3/4] drm/amdgpu: use AMDGPU_GPU_PAGE_SHIFT instead of PAGE_SHIFT

["Christian König" <christian.koenig@amd.com>]

On 8/27/26 17:48, Sunil Khatri wrote:
> For different address types the variable PAGE_SHIFT might
> not work well and it's better to use the GPU specific one
> 
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>

Oh good catch, Reviewed-by: Christian König <christian.koenig@amd.com>

This patch might need a CC stable as well.

Regards,
Christian.

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index c8d1f2624b1b..dbdcd57e5b6b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2090,7 +2090,7 @@ int amdgpu_vm_bo_clear_mappings(struct amdgpu_device *adev,
>  			after->start = eaddr + 1;
>  			after->last = tmp->last;
>  			after->offset = tmp->offset;
> -			after->offset += (after->start - tmp->start) << PAGE_SHIFT;
> +			after->offset += (after->start - tmp->start) << AMDGPU_GPU_PAGE_SHIFT;
>  			after->flags = tmp->flags;
>  			after->bo_va = tmp->bo_va;
>  			list_add(&after->list, &tmp->bo_va->invalids);