AMD-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Sunil Khatri <sunil.khatri@amd.com>,
	Alex Deucher <alexander.deucher@amd.com>
Cc: amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v1 2/4] drm/amdgpu/userq: update the kernel docs for amdgpu_userq_fence_read_wptr
Date: Fri, 28 Aug 2026 09:33:40 +0200	[thread overview]
Message-ID: <5c85279f-e28a-45cb-9e5a-df0dda163ded@amd.com> (raw)
In-Reply-To: <20260827154849.1021013-2-sunil.khatri@amd.com>

On 8/27/26 17:48, Sunil Khatri wrote:
> update the kernel docs for amdgpu_userq_fence_read_wptr.
> 
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
> index 5b936d12c55b..c270635c907b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
> @@ -361,7 +361,7 @@ static const struct dma_fence_ops amdgpu_userq_fence_ops = {
>   *
>   * Read the wptr value from userq's MQD. The userq signal IOCTL
>   * creates a dma_fence for the shared buffers that expects the
> - * RPTR value written to seq64 memory >= WPTR.
> + * fence_val written to seq64 fence address >= WPTR.

Mhm, that isn't ideal either. Maybe use something like this:

Read the wptr value from userq's MQD. This value will become
the rptr when the HW executes the commands and written it to
the seq64 memory. This way the wptr can be used a seq_no to
create a dma_fence.

Regards,
Christian.

>   *
>   * Returns wptr value on success, error on failure.
>   */


  reply	other threads:[~2026-08-28  7:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 15:48 [PATCH v1 1/4] drm/amdgpu: make amdgpu_vm_bo_lookup_mapping() take a raw address Sunil Khatri
2026-08-27 15:48 ` [PATCH v1 2/4] drm/amdgpu/userq: update the kernel docs for amdgpu_userq_fence_read_wptr Sunil Khatri
2026-08-28  7:33   ` Christian König [this message]
2026-08-27 15:48 ` [PATCH v1 3/4] drm/amdgpu: use AMDGPU_GPU_PAGE_SHIFT instead of PAGE_SHIFT Sunil Khatri
2026-08-28  7:33   ` Christian König
2026-08-27 15:48 ` [PATCH v1 4/4] drm/amdgpu: fix Idle BOs list in VM debugfs status info Sunil Khatri
2026-08-27 16:31   ` Alex Deucher
2026-08-28  7:34   ` Christian König
2026-08-28  7:29 ` [PATCH v1 1/4] drm/amdgpu: make amdgpu_vm_bo_lookup_mapping() take a raw address Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c85279f-e28a-45cb-9e5a-df0dda163ded@amd.com \
    --to=christian.koenig@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=sunil.khatri@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox