Re: [PATCH 1/3] drm/amdgpu/pm: add missing revision check for CI

["Timur Kristóf" <timur.kristof@gmail.com>]

On 2026. április 28., kedd 16:56:18 közép-európai nyári idő Alex Deucher 
wrote:
> The ci_populate_all_memory_levels() workaround only
> applies to revision 0 SKUs.
> 
> Link: https://gitlab.freedesktop.org/drm/amd/-/work_items/1816
> Fixes: 9f4b35411cfe ("drm/amd/powerplay: add CI asics support to smumgr
> (v3)") Reviewed-by: Kent Russell <kent.russell@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

Thank you Alex!

Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
for all 3 patches in this series


> ---
>  drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c
> b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c index
> 69d8b05ef2457..6e89a032e3dcf 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c
> @@ -1333,8 +1333,9 @@ static int ci_populate_all_memory_levels(struct
> pp_hwmgr *hwmgr)
> 
>  	dev_id = adev->pdev->device;
> 
> -	if ((dpm_table->mclk_table.count >= 2)
> -		&& ((dev_id == 0x67B0) ||  (dev_id == 0x67B1))) {
> +	if ((dpm_table->mclk_table.count >= 2) &&
> +	    ((dev_id == 0x67B0) ||  (dev_id == 0x67B1)) &&
> +	    (adev->pdev->revision == 0)) {
>  		smu_data->smc_state_table.MemoryLevel[1].MinVddci =
>  				smu_data-
>smc_state_table.MemoryLevel[0].MinVddci;
>  		smu_data->smc_state_table.MemoryLevel[1].MinMvdd =