* [PATCH 6/8] drm/amdkfd: remove dead code in the function svm_range_get_pte_flags
@ 2024-05-30 3:49 Jesse Zhang
2024-05-30 20:53 ` Felix Kuehling
0 siblings, 1 reply; 3+ messages in thread
From: Jesse Zhang @ 2024-05-30 3:49 UTC (permalink / raw)
To: amd-gfx
Cc: Alexander.Deucher, Christian Koenig, Felix Kuehling, jonathan.kim,
Tim.Huang, Jesse Zhang, Jesse Zhang
The varible uncached set false, the condition uncached cannot be true.
So remove the dead code, mapping flags will set the flag AMDGPU_VM_MTYPE_UC in else.
Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 407636a68814..bd9c2921e0dc 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -1171,7 +1171,6 @@ svm_range_get_pte_flags(struct kfd_node *node,
bool snoop = (domain != SVM_RANGE_VRAM_DOMAIN);
bool coherent = flags & (KFD_IOCTL_SVM_FLAG_COHERENT | KFD_IOCTL_SVM_FLAG_EXT_COHERENT);
bool ext_coherent = flags & KFD_IOCTL_SVM_FLAG_EXT_COHERENT;
- bool uncached = false; /*flags & KFD_IOCTL_SVM_FLAG_UNCACHED;*/
unsigned int mtype_local;
if (domain == SVM_RANGE_VRAM_DOMAIN)
@@ -1220,9 +1219,7 @@ svm_range_get_pte_flags(struct kfd_node *node,
mtype_local = amdgpu_mtype_local == 1 ? AMDGPU_VM_MTYPE_NC :
amdgpu_mtype_local == 2 ? AMDGPU_VM_MTYPE_CC : AMDGPU_VM_MTYPE_RW;
snoop = true;
- if (uncached) {
- mapping_flags |= AMDGPU_VM_MTYPE_UC;
- } else if (domain == SVM_RANGE_VRAM_DOMAIN) {
+ if (domain == SVM_RANGE_VRAM_DOMAIN) {
/* local HBM region close to partition */
if (bo_node->adev == node->adev &&
(!bo_node->xcp || !node->xcp || bo_node->xcp->mem_id == node->xcp->mem_id))
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 6/8] drm/amdkfd: remove dead code in the function svm_range_get_pte_flags
2024-05-30 3:49 [PATCH 6/8] drm/amdkfd: remove dead code in the function svm_range_get_pte_flags Jesse Zhang
@ 2024-05-30 20:53 ` Felix Kuehling
0 siblings, 0 replies; 3+ messages in thread
From: Felix Kuehling @ 2024-05-30 20:53 UTC (permalink / raw)
To: Jesse Zhang, amd-gfx
Cc: Alexander.Deucher, Christian Koenig, jonathan.kim, Tim.Huang
On 2024-05-29 23:49, Jesse Zhang wrote:
> The varible uncached set false, the condition uncached cannot be true.
> So remove the dead code, mapping flags will set the flag AMDGPU_VM_MTYPE_UC in else.
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index 407636a68814..bd9c2921e0dc 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -1171,7 +1171,6 @@ svm_range_get_pte_flags(struct kfd_node *node,
> bool snoop = (domain != SVM_RANGE_VRAM_DOMAIN);
> bool coherent = flags & (KFD_IOCTL_SVM_FLAG_COHERENT | KFD_IOCTL_SVM_FLAG_EXT_COHERENT);
> bool ext_coherent = flags & KFD_IOCTL_SVM_FLAG_EXT_COHERENT;
> - bool uncached = false; /*flags & KFD_IOCTL_SVM_FLAG_UNCACHED;*/
> unsigned int mtype_local;
>
> if (domain == SVM_RANGE_VRAM_DOMAIN)
> @@ -1220,9 +1219,7 @@ svm_range_get_pte_flags(struct kfd_node *node,
> mtype_local = amdgpu_mtype_local == 1 ? AMDGPU_VM_MTYPE_NC :
> amdgpu_mtype_local == 2 ? AMDGPU_VM_MTYPE_CC : AMDGPU_VM_MTYPE_RW;
> snoop = true;
> - if (uncached) {
> - mapping_flags |= AMDGPU_VM_MTYPE_UC;
> - } else if (domain == SVM_RANGE_VRAM_DOMAIN) {
> + if (domain == SVM_RANGE_VRAM_DOMAIN) {
> /* local HBM region close to partition */
> if (bo_node->adev == node->adev &&
> (!bo_node->xcp || !node->xcp || bo_node->xcp->mem_id == node->xcp->mem_id))
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 6/8] drm/amdkfd: remove dead code in the function svm_range_get_pte_flags
@ 2024-05-30 3:49 Jesse Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Jesse Zhang @ 2024-05-30 3:49 UTC (permalink / raw)
To: amd-gfx
Cc: Alexander.Deucher, Christian Koenig, Felix Kuehling, jonathan.kim,
Tim.Huang, Jesse Zhang, Jesse Zhang
The varible uncached set false, the condition uncached cannot be true.
So remove the dead code, mapping flags will set the flag AMDGPU_VM_MTYPE_UC in else.
Signed-off-by: Jesse Zhang <Jesse.Zhang@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 407636a68814..bd9c2921e0dc 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -1171,7 +1171,6 @@ svm_range_get_pte_flags(struct kfd_node *node,
bool snoop = (domain != SVM_RANGE_VRAM_DOMAIN);
bool coherent = flags & (KFD_IOCTL_SVM_FLAG_COHERENT | KFD_IOCTL_SVM_FLAG_EXT_COHERENT);
bool ext_coherent = flags & KFD_IOCTL_SVM_FLAG_EXT_COHERENT;
- bool uncached = false; /*flags & KFD_IOCTL_SVM_FLAG_UNCACHED;*/
unsigned int mtype_local;
if (domain == SVM_RANGE_VRAM_DOMAIN)
@@ -1220,9 +1219,7 @@ svm_range_get_pte_flags(struct kfd_node *node,
mtype_local = amdgpu_mtype_local == 1 ? AMDGPU_VM_MTYPE_NC :
amdgpu_mtype_local == 2 ? AMDGPU_VM_MTYPE_CC : AMDGPU_VM_MTYPE_RW;
snoop = true;
- if (uncached) {
- mapping_flags |= AMDGPU_VM_MTYPE_UC;
- } else if (domain == SVM_RANGE_VRAM_DOMAIN) {
+ if (domain == SVM_RANGE_VRAM_DOMAIN) {
/* local HBM region close to partition */
if (bo_node->adev == node->adev &&
(!bo_node->xcp || !node->xcp || bo_node->xcp->mem_id == node->xcp->mem_id))
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-30 20:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-30 3:49 [PATCH 6/8] drm/amdkfd: remove dead code in the function svm_range_get_pte_flags Jesse Zhang
2024-05-30 20:53 ` Felix Kuehling
-- strict thread matches above, loose matches on Subject: below --
2024-05-30 3:49 Jesse Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox