* Re: [PATCH] drm/amdgpu: fix warning in pr_debug
2021-10-26 15:36 [PATCH] drm/amdgpu: fix warning in pr_debug Alex Deucher
@ 2021-10-26 16:21 ` Felix Kuehling
2021-10-26 16:27 ` Alex Deucher
2021-10-27 7:18 ` Christian König
2 siblings, 0 replies; 4+ messages in thread
From: Felix Kuehling @ 2021-10-26 16:21 UTC (permalink / raw)
To: Alex Deucher, amd-gfx; +Cc: Philip Yang
Am 2021-10-26 um 11:36 a.m. schrieb Alex Deucher:
> In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:52:
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c: In function ‘amdgpu_ttm_tt_get_user_pages’:
> drivers/gpu/drm/amd/amdgpu/amdgpu.h:35:21: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
> 35 | #define pr_fmt(fmt) "amdgpu: " fmt
> | ^~~~~~~~~~
> ./include/linux/dynamic_debug.h:134:15: note: in expansion of macro ‘pr_fmt’
> 134 | func(&id, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> ./include/linux/dynamic_debug.h:152:2: note: in expansion of macro ‘__dynamic_func_call’
> 152 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:162:2: note: in expansion of macro ‘_dynamic_func_call’
> 162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
> | ^~~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:424:2: note: in expansion of macro ‘dynamic_pr_debug’
> 424 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:697:3: note: in expansion of macro ‘pr_debug’
> 697 | pr_debug("failed %d to get user pages 0x%llx\n", r, start);
> | ^~~~~~~~
>
> Fixes: 702dde19d4b0e7 ("drm/amdkfd: restore userptr ignore bad address error")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Philip Yang <Philip.Yang@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index ae6694f2c73d..881a91a6ab13 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -694,7 +694,7 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages)
> ttm->num_pages, >t->range, readonly,
> false, NULL);
> if (r)
> - pr_debug("failed %d to get user pages 0x%llx\n", r, start);
> + pr_debug("failed %d to get user pages 0x%lux\n", r, start);
>
> out_putmm:
> mmput(mm);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amdgpu: fix warning in pr_debug
2021-10-26 15:36 [PATCH] drm/amdgpu: fix warning in pr_debug Alex Deucher
2021-10-26 16:21 ` Felix Kuehling
@ 2021-10-26 16:27 ` Alex Deucher
2021-10-27 7:18 ` Christian König
2 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2021-10-26 16:27 UTC (permalink / raw)
To: Alex Deucher; +Cc: amd-gfx list, Philip Yang
On Tue, Oct 26, 2021 at 11:36 AM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:52:
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c: In function ‘amdgpu_ttm_tt_get_user_pages’:
> drivers/gpu/drm/amd/amdgpu/amdgpu.h:35:21: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
> 35 | #define pr_fmt(fmt) "amdgpu: " fmt
> | ^~~~~~~~~~
> ./include/linux/dynamic_debug.h:134:15: note: in expansion of macro ‘pr_fmt’
> 134 | func(&id, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> ./include/linux/dynamic_debug.h:152:2: note: in expansion of macro ‘__dynamic_func_call’
> 152 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:162:2: note: in expansion of macro ‘_dynamic_func_call’
> 162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
> | ^~~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:424:2: note: in expansion of macro ‘dynamic_pr_debug’
> 424 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:697:3: note: in expansion of macro ‘pr_debug’
> 697 | pr_debug("failed %d to get user pages 0x%llx\n", r, start);
> | ^~~~~~~~
>
> Fixes: 702dde19d4b0e7 ("drm/amdkfd: restore userptr ignore bad address error")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Philip Yang <Philip.Yang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index ae6694f2c73d..881a91a6ab13 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -694,7 +694,7 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages)
> ttm->num_pages, >t->range, readonly,
> false, NULL);
> if (r)
> - pr_debug("failed %d to get user pages 0x%llx\n", r, start);
> + pr_debug("failed %d to get user pages 0x%lux\n", r, start);
Actually this should be 0x%lx. Will fix that up locally.
Alex
>
> out_putmm:
> mmput(mm);
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amdgpu: fix warning in pr_debug
2021-10-26 15:36 [PATCH] drm/amdgpu: fix warning in pr_debug Alex Deucher
2021-10-26 16:21 ` Felix Kuehling
2021-10-26 16:27 ` Alex Deucher
@ 2021-10-27 7:18 ` Christian König
2 siblings, 0 replies; 4+ messages in thread
From: Christian König @ 2021-10-27 7:18 UTC (permalink / raw)
To: Alex Deucher, amd-gfx; +Cc: Philip Yang
Am 26.10.21 um 17:36 schrieb Alex Deucher:
> In file included from drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:52:
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c: In function ‘amdgpu_ttm_tt_get_user_pages’:
> drivers/gpu/drm/amd/amdgpu/amdgpu.h:35:21: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
> 35 | #define pr_fmt(fmt) "amdgpu: " fmt
> | ^~~~~~~~~~
> ./include/linux/dynamic_debug.h:134:15: note: in expansion of macro ‘pr_fmt’
> 134 | func(&id, ##__VA_ARGS__); \
> | ^~~~~~~~~~~
> ./include/linux/dynamic_debug.h:152:2: note: in expansion of macro ‘__dynamic_func_call’
> 152 | __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:162:2: note: in expansion of macro ‘_dynamic_func_call’
> 162 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
> | ^~~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:424:2: note: in expansion of macro ‘dynamic_pr_debug’
> 424 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
> | ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:697:3: note: in expansion of macro ‘pr_debug’
> 697 | pr_debug("failed %d to get user pages 0x%llx\n", r, start);
> | ^~~~~~~~
>
> Fixes: 702dde19d4b0e7 ("drm/amdkfd: restore userptr ignore bad address error")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Philip Yang <Philip.Yang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> index ae6694f2c73d..881a91a6ab13 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
> @@ -694,7 +694,7 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *bo, struct page **pages)
> ttm->num_pages, >t->range, readonly,
> false, NULL);
> if (r)
> - pr_debug("failed %d to get user pages 0x%llx\n", r, start);
> + pr_debug("failed %d to get user pages 0x%lux\n", r, start);
>
> out_putmm:
> mmput(mm);
^ permalink raw reply [flat|nested] 4+ messages in thread