* [PATCH] drm/amd/amdgpu: Add newlines in drm_dbg format strings
@ 2026-09-28 13:30 Ed Maste
2026-09-28 16:20 ` Mario Limonciello
0 siblings, 1 reply; 2+ messages in thread
From: Ed Maste @ 2026-09-28 13:30 UTC (permalink / raw)
To: Alex Deucher, Christian König, Mario Limonciello (AMD)
Cc: amd-gfx, Ed Maste
From: Ed Maste <emaste@FreeBSD.org>
Signed-off-by: Ed Maste <emaste@FreeBSD.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
index 1e21e3444802..c283087bb560 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
@@ -311,7 +311,7 @@ static int amdgpu_atomfirmware_get_uma_carveout_info_v2_3(struct amdgpu_device *
if (nr_uma_options > MAX_UMA_OPTION_ENTRIES) {
drm_dbg(adev_to_drm(adev),
- "Number of UMA options exceeds max table size. Options will not be parsed");
+ "Number of UMA options exceeds max table size. Options will not be parsed\n");
return -EINVAL;
}
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
index 62f5c5cbd7f9..d23de711d8cf 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
@@ -720,13 +720,13 @@ static int amdgpu_discovery_init(struct amdgpu_device *adev)
/* Read from file if it is the preferred option */
fw_name = amdgpu_discovery_get_fw_name(adev);
if (fw_name != NULL) {
- drm_dbg(&adev->ddev, "use ip discovery information from file");
+ drm_dbg(&adev->ddev, "use ip discovery information from file\n");
r = amdgpu_discovery_read_binary_from_file(adev, discovery_bin,
fw_name);
if (r)
goto out;
} else {
- drm_dbg(&adev->ddev, "use ip discovery information from memory");
+ drm_dbg(&adev->ddev, "use ip discovery information from memory\n");
r = amdgpu_discovery_read_binary_from_mem(adev, discovery_bin,
is_tmr_in_sysmem);
if (r)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index 59ea338b554c..0a8dd7241750 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -1428,7 +1428,7 @@ static int amdgpu_display_framebuffer_init(struct drm_device *dev,
ret = convert_tiling_flags_to_modifier_gfx6(rfb);
if (ret) {
- drm_dbg_kms(dev, "Failed to convert tiling flags 0x%llX to a modifier",
+ drm_dbg_kms(dev, "Failed to convert tiling flags 0x%llX to a modifier\n",
rfb->tiling_flags);
return ret;
}
diff --git a/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c b/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
index 485ecdec9618..363266f3e0a3 100644
--- a/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
+++ b/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
@@ -235,7 +235,7 @@ static int isp_v4_1_1_hw_init(struct amdgpu_isp *isp)
r = amdgpu_acpi_get_isp4_dev(&acpi_dev);
if (r) {
- drm_dbg(&adev->ddev, "Invalid isp platform detected (%d)", r);
+ drm_dbg(&adev->ddev, "Invalid isp platform detected (%d)\n", r);
/* allow GPU init to progress */
return 0;
}
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/amdgpu: Add newlines in drm_dbg format strings
2026-09-28 13:30 [PATCH] drm/amd/amdgpu: Add newlines in drm_dbg format strings Ed Maste
@ 2026-09-28 16:20 ` Mario Limonciello
0 siblings, 0 replies; 2+ messages in thread
From: Mario Limonciello @ 2026-09-28 16:20 UTC (permalink / raw)
To: Ed Maste, Alex Deucher, Christian König; +Cc: amd-gfx
On 9/28/26 08:30, Ed Maste wrote:
> From: Ed Maste <emaste@FreeBSD.org>
>
> Signed-off-by: Ed Maste <emaste@FreeBSD.org>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Applied to amd-staging-drm-next, thanks.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
> index 1e21e3444802..c283087bb560 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c
> @@ -311,7 +311,7 @@ static int amdgpu_atomfirmware_get_uma_carveout_info_v2_3(struct amdgpu_device *
>
> if (nr_uma_options > MAX_UMA_OPTION_ENTRIES) {
> drm_dbg(adev_to_drm(adev),
> - "Number of UMA options exceeds max table size. Options will not be parsed");
> + "Number of UMA options exceeds max table size. Options will not be parsed\n");
> return -EINVAL;
> }
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 62f5c5cbd7f9..d23de711d8cf 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -720,13 +720,13 @@ static int amdgpu_discovery_init(struct amdgpu_device *adev)
> /* Read from file if it is the preferred option */
> fw_name = amdgpu_discovery_get_fw_name(adev);
> if (fw_name != NULL) {
> - drm_dbg(&adev->ddev, "use ip discovery information from file");
> + drm_dbg(&adev->ddev, "use ip discovery information from file\n");
> r = amdgpu_discovery_read_binary_from_file(adev, discovery_bin,
> fw_name);
> if (r)
> goto out;
> } else {
> - drm_dbg(&adev->ddev, "use ip discovery information from memory");
> + drm_dbg(&adev->ddev, "use ip discovery information from memory\n");
> r = amdgpu_discovery_read_binary_from_mem(adev, discovery_bin,
> is_tmr_in_sysmem);
> if (r)
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 59ea338b554c..0a8dd7241750 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -1428,7 +1428,7 @@ static int amdgpu_display_framebuffer_init(struct drm_device *dev,
> ret = convert_tiling_flags_to_modifier_gfx6(rfb);
>
> if (ret) {
> - drm_dbg_kms(dev, "Failed to convert tiling flags 0x%llX to a modifier",
> + drm_dbg_kms(dev, "Failed to convert tiling flags 0x%llX to a modifier\n",
> rfb->tiling_flags);
> return ret;
> }
> diff --git a/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c b/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
> index 485ecdec9618..363266f3e0a3 100644
> --- a/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
> +++ b/drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c
> @@ -235,7 +235,7 @@ static int isp_v4_1_1_hw_init(struct amdgpu_isp *isp)
>
> r = amdgpu_acpi_get_isp4_dev(&acpi_dev);
> if (r) {
> - drm_dbg(&adev->ddev, "Invalid isp platform detected (%d)", r);
> + drm_dbg(&adev->ddev, "Invalid isp platform detected (%d)\n", r);
> /* allow GPU init to progress */
> return 0;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-29 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-28 13:30 [PATCH] drm/amd/amdgpu: Add newlines in drm_dbg format strings Ed Maste
2026-09-28 16:20 ` Mario Limonciello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox