From: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
To: Melissa Wen <mwen@igalia.com>, <airlied@gmail.com>,
<alexander.deucher@amd.com>, <christian.koenig@amd.com>,
<harry.wentland@amd.com>, <maarten.lankhorst@linux.intel.com>,
<mripard@kernel.org>, <simona@ffwll.ch>, <siqueira@igalia.com>,
<sunpeng.li@amd.com>, <tzimmermann@suse.de>
Cc: Alex Hung <alex.hung@amd.com>, Simon Ser <contact@emersion.fr>,
"Uma Shankar" <uma.shankar@intel.com>,
Xaver Hugl <xaver.hugl@kde.org>,
"Pekka Paalanen" <pekka.paalanen@collabora.com>,
Louis Chauvet <louis.chauvet@bootlin.com>,
Matthew Schwartz <matthew.schwartz@linux.dev>,
<amd-gfx@lists.freedesktop.org>, <kernel-dev@igalia.com>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
"Abhinav Kumar" <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
"Sean Paul" <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
<linux-arm-msm@vger.kernel.org>,
<freedreno@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v5 3/6] drm/colorop: Remove read-only comments from interpolation fields
Date: Mon, 18 May 2026 17:12:56 +0530 [thread overview]
Message-ID: <2ec56a27-4c2a-40ec-82bc-bc4e05a8e143@intel.com> (raw)
In-Reply-To: <20260506192633.16066-4-mwen@igalia.com>
On 5/7/2026 12:53 AM, Melissa Wen wrote:
> From: Alex Hung <alex.hung@amd.com>
>
> The lut1d_interpolation and lut3d_interpolation fields and their
> associated properties were marked as read-only, but userspace
> can set them via drm_atomic_colorop_set_property().
>
> Signed-off-by: Alex Hung <alex.hung@amd.com>
LGTM.
Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
> include/drm/drm_colorop.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/include/drm/drm_colorop.h b/include/drm/drm_colorop.h
> index bd082854ca74..61cc8206b4c4 100644
> --- a/include/drm/drm_colorop.h
> +++ b/include/drm/drm_colorop.h
> @@ -309,7 +309,6 @@ struct drm_colorop {
> /**
> * @lut1d_interpolation:
> *
> - * Read-only
> * Interpolation for DRM_COLOROP_1D_LUT
> */
> enum drm_colorop_lut1d_interpolation_type lut1d_interpolation;
> @@ -317,7 +316,6 @@ struct drm_colorop {
> /**
> * @lut3d_interpolation:
> *
> - * Read-only
> * Interpolation for DRM_COLOROP_3D_LUT
> */
> enum drm_colorop_lut3d_interpolation_type lut3d_interpolation;
> @@ -325,7 +323,7 @@ struct drm_colorop {
> /**
> * @lut1d_interpolation_property:
> *
> - * Read-only property for DRM_COLOROP_1D_LUT interpolation
> + * Property for DRM_COLOROP_1D_LUT interpolation
> */
> struct drm_property *lut1d_interpolation_property;
>
> @@ -353,7 +351,7 @@ struct drm_colorop {
> /**
> * @lut3d_interpolation_property:
> *
> - * Read-only property for DRM_COLOROP_3D_LUT interpolation
> + * Property for DRM_COLOROP_3D_LUT interpolation
> */
> struct drm_property *lut3d_interpolation_property;
>
next prev parent reply other threads:[~2026-05-18 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 19:23 [PATCH v5 0/6] drm/atomic: track individual colorop updates Melissa Wen
2026-05-06 19:23 ` [PATCH v5 1/6] drm/atomic: only add colorop state from active color pipeline Melissa Wen
2026-05-18 11:42 ` Borah, Chaitanya Kumar
2026-05-06 19:23 ` [PATCH v5 2/6] drm/atomic: don't set colorop properties of inactive color pipelines Melissa Wen
2026-05-18 11:42 ` Borah, Chaitanya Kumar
2026-05-19 12:50 ` Melissa Wen
2026-05-06 19:23 ` [PATCH v5 3/6] drm/colorop: Remove read-only comments from interpolation fields Melissa Wen
2026-05-18 11:42 ` Borah, Chaitanya Kumar [this message]
2026-05-06 19:23 ` [PATCH v5 4/6] drm/colorop: make lut(1/3)d_interpolation mutable Melissa Wen
2026-05-18 11:43 ` Borah, Chaitanya Kumar
2026-05-06 19:23 ` [PATCH v5 5/6] drm/atomic: track individual colorop updates Melissa Wen
2026-05-18 11:44 ` Borah, Chaitanya Kumar
2026-05-06 19:23 ` [PATCH v5 6/6] drm/amd/display: use plane color_mgmt_changed to track colorop changes Melissa Wen
2026-05-18 11:06 ` [PATCH v5 0/6] drm/atomic: track individual colorop updates Melissa Wen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ec56a27-4c2a-40ec-82bc-bc4e05a8e143@intel.com \
--to=chaitanya.kumar.borah@intel.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=contact@emersion.fr \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=jesszhan0024@gmail.com \
--cc=kernel-dev@igalia.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=matthew.schwartz@linux.dev \
--cc=mripard@kernel.org \
--cc=mwen@igalia.com \
--cc=pekka.paalanen@collabora.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=tzimmermann@suse.de \
--cc=uma.shankar@intel.com \
--cc=xaver.hugl@kde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox